Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Shai Malin <smalin@marvell.com>
To:     Adrian Bunk <bunk@kernel.org>, Ariel Elior <aelior@marvell.com>,
        Sudarsana Reddy Kalluru <skalluru@marvell.com>,
        GR-everest-linux-l2 <GR-everest-linux-l2@marvell.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] bnx2x: Fix enabling network interfaces without VFs
Thread-Topic: [PATCH] bnx2x: Fix enabling network interfaces without VFs
Thread-Index: Adeodmr4RYh0k8HgSU6+CKbfKaKGGA==
Date:   Mon, 13 Sep 2021 08:14:33 +0000
Message-ID: <SJ0PR18MB38825BC9620238DE3327C64FCCD99@SJ0PR18MB3882.namprd18.prod.outlook.com>
Accept-Language: he-IL, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?CyDCRtNHbynMs374wsA03/Ynlqfjk+a8voFMYBnPt7dMjOeYD6//Xi47hkiD?=
 =?us-ascii?Q?ZJR24sIQV8o4pVzgfOdKe+GIoVCMOYAUMTiKTNbc7v6Yjia/6VqwF/RvUZxZ?=
 =?us-ascii?Q?uXVMZ3P6F7BC4H8N0T/emuOWTRnoml6W9IqS6fIHRmNN/NWfl+B6z9qbILRW?=
 =?us-ascii?Q?fIj3QB9kRTMdj4XJSHcG5wKmsjrJ2t+/5aZXNhjm5RJaEiv3SOk6eFMJhy/y?=
 =?us-ascii?Q?M+1efzMk9Rc0c1x+pJWOXRsle+xnW5JMXEPQGimRlCGVcaVc+fhqVZ0mjgPW?=
 =?us-ascii?Q?y8Fyib+zH1wj/3qok3yVYM0EE61rUruz26177TppQCxHeVpWVKs9dgmuY3ks?=
 =?us-ascii?Q?0rkNzgfogVyguphk0FCBCGFDeGb/rZYsROJOVpUKJcdm3n4VPuJ48DmZqmHE?=
 =?us-ascii?Q?LnYbvrMG+Vq1dKT8iwVZK9Ui8fHEvaVTdEgbCsDiwOy5O2PNnTstgqd8Bh7j?=
 =?us-ascii?Q?PobCYAXjg15mSeL/eVrzj0JMhf2Z/Btj6Jn+nWEPesMj+D7VHl/5dhw3IAE/?=
 =?us-ascii?Q?i68h9F8Le9Dd3xBI2ZBVYyIfCjz5cloAJQSTXp8kz0wAhsUi/TyYKF6Mm4D1?=
 =?us-ascii?Q?wOPCp7GQc7tfPmvl2nhoE0ctZI6rXg1oq/lmOEuvx4ZIW/kxAgLnoYlJNWiy?=
 =?us-ascii?Q?xfMWZdlKUERWOWrY0717MffRfsT/8TUDKRmjorkJHEQbsc9FDok932dZwdXN?=
 =?us-ascii?Q?P2b3NuBdNOnROVtGvI4K8FSaUQ3vK3fdCVt+23GXHxrLmDCKLRav7eT+kH0j?=
 =?us-ascii?Q?9Rr8vVGmLWLc2mS1HtlKIuhWNHyw4gXo2c/9/CO+/+i2bKPzOkYbR5JOebHf?=
 =?us-ascii?Q?4FbuMCgazv9wpkakCA1HzXkL1tVy6SsI5Ruye5HEYEx3VxD16vbSSQBOY6IQ?=
 =?us-ascii?Q?ViZXzoarMYNE0VWuYj4k0pq61IkZ1CHdhpSDbyMN+i6ysOS7xGhUeV1biOE/?=
 =?us-ascii?Q?D3K8+a0nc3v+fVeQpIry+7wnLi68qIIa8RtrxPHTD417wFxbnmRPdKryOsWy?=
 =?us-ascii?Q?66efbH8S2D4Q1ZdPE0HkVmkc30NfueFnOqCUtpYXybdZwIgwNRsurnICvw42?=
 =?us-ascii?Q?sEvnHonjjks8iZC3xJjvA/dOEErM5/7Cbz6HvkuteU1XTYvYEirMosWZ/5ST?=
 =?us-ascii?Q?r36VqoGHDgwNJI/ERgHyOy//4sfSlk5nVJpXBXXD4/liU9yeNoNAxFByJ8Xr?=
 =?us-ascii?Q?T18Jm9nG4vkl5CciKfTlOhdyRqmEBStYr5pBINHlw0SLqn6jTyWiUYZqHQqE?=
 =?us-ascii?Q?tGDsTriOEm3PdhEeGX+FhhxMcgAoYyBnxQ/DmJMIjCv7DOgnHDDGLZEwWGX/?=
 =?us-ascii?Q?q3ultVH6AEgC/uvz6ZlS9Adl?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR18MB3882.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a9740260-7047-4254-5649-08d9768e84b0
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Sep 2021 08:14:33.2611
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 8rNSOpgbBbnkIsEBbEOZ5JBh8t8lWy/bFY7BI7M4CRMbzShMKnMnu3D9mu+GJ5LjMrY8qJgRRjMKNqf6ZUCW9Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2391
X-Proofpoint-GUID: JpIaFQer2tQwXHq0DEyiWDDS_leLtXcA
X-Proofpoint-ORIG-GUID: JpIaFQer2tQwXHq0DEyiWDDS_leLtXcA
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475
 definitions=2021-09-13_03,2021-09-09_01,2020-04-07_01
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 9/12/2021 at 10:08PM, Adrian Bunk Wrote:
> This function is called to enable SR-IOV when available,
> not enabling interfaces without VFs was a regression.
>=20
> Fixes: 65161c35554f ("bnx2x: Fix missing error code in bnx2x_iov_init_one=
()")
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
> Reported-by: YunQiang Su <wzssyqa@gmail.com>
> Tested-by: YunQiang Su <wzssyqa@gmail.com>
> Cc: stable@vger.kernel.org
> ---
>  drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
> b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
> index f255fd0b16db..6fbf735fca31 100644
> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
> @@ -1224,7 +1224,7 @@ int bnx2x_iov_init_one(struct bnx2x *bp, int
> int_mode_param,
>=20
>  	/* SR-IOV capability was enabled but there are no VFs*/
>  	if (iov->total =3D=3D 0) {
> -		err =3D -EINVAL;
> +		err =3D 0;
>  		goto failed;
>  	}

Thanks for reporting this issue!
But the complete fix should also not use "goto failed".
Instead, please create a new "goto skip_vfs" so it will skip=20
the log of "Failed err=3D".

>=20
> --
> 2.20.1