Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 13 Sep 2021 10:31:25 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Len Baker <len.baker@gmx.com>
Cc:     Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Kees Cook <keescook@chromium.org>,
        "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        oss-drivers@corigine.com, netdev@vger.kernel.org,
        linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nfp: Prefer struct_size over open coded arithmetic
Message-ID: <20210913083124.GB30223@corigine.com>
References: <20210912131057.2285-1-len.baker@gmx.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210912131057.2285-1-len.baker@gmx.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?GZd69KRbXK5ZE4BSiFn7a44UZIPKIK0QNrZdFUn5d0rewOYio/TIIW3nvTMt?=
 =?us-ascii?Q?q4sG7FaGeamK34ax4M2gIRwTRWsbdtqMY4al2lzMB+sr7ri5vng+IKOlNVbJ?=
 =?us-ascii?Q?UhvvUlQYpAXTtZI5IpB5qIeEsh0X5m4/9tuesLp0KewxAwQhXWm3vMTD12EG?=
 =?us-ascii?Q?igBoKHh+ruB91Kq8o6sAAmsFw3Iwvrjyhh66wRZNNCYT7eJyA/o5pGU88tYU?=
 =?us-ascii?Q?n2OwOZFbYj34NzolAkg///FIA1maptf9d5A26Tus3BIHypHmrTGZF/k/Hukr?=
 =?us-ascii?Q?lNjw8JRkG6p/tmQ41+wfIrepuaEfus0I0Czjd5WFTJvqcf4JhDJe0rvhqjcf?=
 =?us-ascii?Q?3Rk0/v9k/IE+g0cuDh1cUCPrcnsbvCBXpMV7JE/ogfJT4nNhzia8R6Ddi5TL?=
 =?us-ascii?Q?QYi8rACYQCzTBbzgxLtDynvezWBgRYIFPz9/S+GtlTpIabhfA3zEqNkhLaLF?=
 =?us-ascii?Q?YyZwrydTxnLCfnCtSndpP1mdDstDLu7Zwnsa4KT8+HxkWf39h6Avh1dIs77H?=
 =?us-ascii?Q?Rv+jXP8Ol6iVLFCMLw/yhVsiC8ERvPcS6kpoV3+A2j9xaclze+9Y7vUYoREF?=
 =?us-ascii?Q?fhxCO95ilZqw7NnVRIk85xzWkfhJSIffhMtXlKADbPcJTHdEhrABlruXkOxn?=
 =?us-ascii?Q?c9xseF6TDXe7gCbkFum5pg7yl5MDrGUU5KKRP8Iex9uUPdNtV5NUHDfos/zE?=
 =?us-ascii?Q?gnl87egfsN0Mwjo/d6O8gKAba5+MgqA2zZksaJxaiBInSQajZv7b5aaC/z5P?=
 =?us-ascii?Q?HPeVxQ7gstbbWh98HJ3Ps1wkvQJiUhQrX1MaY7Bo5z1QH5e7Hz78H37DpESs?=
 =?us-ascii?Q?1XmFKBUvDerESaznWnGlbbWSieofZBAz2kYEhmDosiRZ2FBcFf9UP9gCy7/9?=
 =?us-ascii?Q?JZXe83dfETS7Gfd3+ZhKAT+sN1iUbVMRoKJGtR25xWU2cMMzPkUhh/FDGjTQ?=
 =?us-ascii?Q?CJiiPttQijqJ8VctEv9q+GSl8imBEH1hj1iF9ZyJDq9ZyaoxxamqM2XAEwwP?=
 =?us-ascii?Q?gDtnSmAWVFUw1/xyMNMRgS6gKtWmo1r3nho6+w7FRmuqpPY0qKw2twmLVrS6?=
 =?us-ascii?Q?nxGxtu6VmIqYs3JMDL6dZRCXhMG+ggx9kR8ncoXE1JGIZwudVEsoGwZu+itC?=
 =?us-ascii?Q?atrFEzil/jFYV5paKDW/F7t4mQFtcc0JJE3W4UiYeCd6W+J6zYgCoS6aH8Wm?=
 =?us-ascii?Q?sE+dB/JKpD/DdgMEJN+pEQphj5itZNGWjessU57pAj4GrgGPqrawJVVT5PXF?=
 =?us-ascii?Q?Sffef97BnWlOvhmNmPA39+bPxKPwR26L4RroeC+4OlN1K+kFtMuCmXrTzPfb?=
 =?us-ascii?Q?SzYqDrCbEtiz92Tfkv5gT8aoZ2ExaGzV13F02h23fXFbJUMOMt+SpHnwavEx?=
 =?us-ascii?Q?U02XkaypcF0oeHyNK5yzDXRdwnsL?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1c5ff7dc-5157-4631-be04-08d97690e303
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2021 08:31:30.6882
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: j9aKx0PsDpDLXckZLDNffHx5iQea/C6GWr8W99m2kq400VYqlDJZ7C9wgqLYmiZe/4p/G+Nb3JK4imOUHta0PTZwMPmT9Ss3C52u/+RbDaw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR13MB4780
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Sep 12, 2021 at 03:10:57PM +0200, Len Baker wrote:
> As noted in the "Deprecated Interfaces, Language Features, Attributes,
> and Conventions" documentation [1], size calculations (especially
> multiplication) should not be performed in memory allocator (or similar)
> function arguments due to the risk of them overflowing. This could lead
> to values wrapping around and a smaller allocation being made than the
> caller was expecting. Using those allocations could lead to linear
> overflows of heap memory and other misbehaviors.
> 
> So, use the struct_size() helper to do the arithmetic instead of the
> argument "size + count * size" in the kzalloc() function.
> 
> [1] https://www.kernel.org/doc/html/v5.14/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments
> 
> Signed-off-by: Len Baker <len.baker@gmx.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>

> ---
>  drivers/net/ethernet/netronome/nfp/nfp_net_repr.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c b/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c
> index 3b8e675087de..369f6ae700c7 100644
> --- a/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c
> +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c
> @@ -499,8 +499,7 @@ struct nfp_reprs *nfp_reprs_alloc(unsigned int num_reprs)
>  {
>  	struct nfp_reprs *reprs;
> 
> -	reprs = kzalloc(sizeof(*reprs) +
> -			num_reprs * sizeof(struct net_device *), GFP_KERNEL);
> +	reprs = kzalloc(struct_size(reprs, reprs, num_reprs), GFP_KERNEL);
>  	if (!reprs)
>  		return NULL;
>  	reprs->num_reprs = num_reprs;
> --
> 2.25.1
>