Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] mm/memory_hotplug: Add static qualifier for
 online_policy_to_str
To:     Tang Yizhou <tangyizhou@huawei.com>
Cc:     osalvador@suse.de, mhocko@kernel.org, akpm@linux-foundation.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
References: <20210913024534.26161-1-tangyizhou@huawei.com>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat
Message-ID: <db765394-e893-c93d-a54a-52d36a17afd8@redhat.com>
Date:   Mon, 13 Sep 2021 10:39:50 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210913024534.26161-1-tangyizhou@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 13.09.21 04:45, Tang Yizhou wrote:
> online_policy_to_str is only used in memory_hotplug.c and should be
> defined as static.
> 
> Signed-off-by: Tang Yizhou <tangyizhou@huawei.com>
> ---
>   mm/memory_hotplug.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index 0488eed3327c..4ea91c3ff768 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -57,7 +57,7 @@ enum {
>   	ONLINE_POLICY_AUTO_MOVABLE,
>   };
>   
> -const char *online_policy_to_str[] = {
> +static const char * const online_policy_to_str[] = {
>   	[ONLINE_POLICY_CONTIG_ZONES] = "contig-zones",
>   	[ONLINE_POLICY_AUTO_MOVABLE] = "auto-movable",
>   };
> 

Indeed, thanks

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Thanks,

David / dhildenb