Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/2] drm/amdgpu: Clarify that TMZ unsupported message is
 due to hardware
To:     Paul Menzel <pmenzel@molgen.mpg.de>,
        Alex Deucher <alexander.deucher@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>
Cc:     amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20210913083411.11215-1-pmenzel@molgen.mpg.de>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
Message-ID: <e9e4e529-b3af-2862-eb38-8e5415108ba4@amd.com>
Date:   Mon, 13 Sep 2021 10:39:34 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
In-Reply-To: <20210913083411.11215-1-pmenzel@molgen.mpg.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bW82bnl4dVoyZFdXVnV1b0pGZVBoRlZtbzFHMXJ6LzFOMXJwd2lsMDNkT2dS?=
 =?utf-8?B?SEdpQzFDT3NYVTVKcTc0L0owR1JIWHd3MEFoY0RsaHVRQ1F2SExmUjlvcm5I?=
 =?utf-8?B?VU9NbUR1dkhxbVMxK1F2NDhOSDllc3ozSTJMd3V5OU8xQ2VFd0plaTNSRHVP?=
 =?utf-8?B?QWdLV1pRN3BDempUZWhzWFZuUmZuK1htYXVMVVJTU3dtVkNGMDJ6ZEZ1bWJv?=
 =?utf-8?B?RDIrMDZrakpmYmZ6c1FLa3Zkam14Wm5hS2ZKcUVoYTNLeTh5UVJIZmpORnFU?=
 =?utf-8?B?cXR5TjFGbG5IU1RpQkVkZkJlK2VqL2dxKyt0bzhBMjdaVFRpV0dUcVVDWFFZ?=
 =?utf-8?B?eXlOaVQ2eGt5QkRDTkliMStqRHpiSVNCQ2t3M3RJeTF0R3F1QmJJQlhwTC9r?=
 =?utf-8?B?WXdwTUdnQVRiUXFtZW9iOStETDJXek1wdHNjaDIvc3lIRXlWUzRqYi9Kc0pY?=
 =?utf-8?B?T1BIMjBwb3JLWWdOUHZ0UUpDZDZJVGhsMlFxc1FTMUFVeVU2R0txMDNPVlo4?=
 =?utf-8?B?NU5KYTZ3MThQQ0dxTGxreGIwbzFaQVRKc0VwZ1lmbDVIa0ZQa0t5S0xlL2oz?=
 =?utf-8?B?Q0liK0thL09RbVdDL3NMS1ROWWQxaWtSSFpzZWF4NVRZNHlpbHVZd0pMTnpY?=
 =?utf-8?B?Z3JKaWtiMlhtcW9TVDhnNElVODc3TElzdzdaZGlaYWRtWnFUbUE2RllHL3g3?=
 =?utf-8?B?NTdDWUtzT2Y4bm44S0xQTWpqZHBjN3QwVXFLK3IzUHVjamdVcmZkcTFjMVNI?=
 =?utf-8?B?d0g4UWJRNGV1bkVpR3FkZkJxM3ptUEI0anZwejZtc2M1eXZlVEZZNFE2d2FK?=
 =?utf-8?B?Z0ZpWlpHQkg5Y1BmVllHNGhZMnR3YmtXdjRBMDBYYnExaWJ1akp5R2FpZFk0?=
 =?utf-8?B?Q2JDTEtkaURINEo1OXlxaklxNkpKR0dMK0xCTSsyWXZ3K3Fwb1E0Q0VhRjBE?=
 =?utf-8?B?NjJFYWZtNnRpRDZZZFczb2VJNy9YUmJZc0ZYMTdCM29WckFFTVVxYnpLYkZk?=
 =?utf-8?B?aERQdjU4a2FiY3QvK2xDbHZickMrZ3NZUXF5K3VQSk1pdWhLdjRVNnU0WnZU?=
 =?utf-8?B?UW10UHNtbzZEeE93SUswOGtnaVdkTHpjelVSdG9VcWIySG9nb2s5Nm1mN1FJ?=
 =?utf-8?B?RlUya2hqUTN6QURBazlBaklqd2V4bEwrYnVSK1FmeTZSNTZhTmJkY0ZrMUlk?=
 =?utf-8?B?RkZmamo5VGFvTXBPc3lCald1eVhpT1VMMWxJRVVEMnlpbHYzV2l1Z21NTTBN?=
 =?utf-8?B?TUZDZTV5ZE13SVZlV0VPSEo5TXE4MFZRRWRpOFlUc1ZaUXlpYk5xWjVjMHV2?=
 =?utf-8?B?UUZMSkwzbkJMd1VDWG10c3RNOG4rU2QrUkE3dWYvTDNKbENMdHBYVkJFS1RQ?=
 =?utf-8?B?SUtYem9FSUN1bVJFM2pmaUh3dHhSNW1Ld2VwZk1PTUNZZ2RraHV6dWY2eHYz?=
 =?utf-8?B?OVRjTkw5TEV5RXlNZGpNZVl6OE9qZitkZlVzeDI5TGk3TWdqNkRPeUFyMGVR?=
 =?utf-8?B?ZUszU2xHamNoTE9YWmE0N01lWHJlOHl6WmFnWHYzN2YxaksyaUVrcWh5cEUz?=
 =?utf-8?B?cWtVVVc2SFhEYnYrYkFwSGxRODdNeElkUjZ3U2NBdlVLRXlGL0E3cEVaUTVX?=
 =?utf-8?B?NUhQUHlnZVllcnZvcVpXWmRMK3RjSVdZYy92eXZreUVNU2pIajFFbjhYaHhJ?=
 =?utf-8?B?dEpXcDIvV29kR1pnSmYyaWtDU3NaaElKRUtrdWg2TnpXQXBuV0hMNXgzTjA0?=
 =?utf-8?Q?1xF7OewvsonINhGo1Kl3Exb+by/r32QV5o0301Y?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 72e57981-0da9-4a53-4134-08d9769205e5
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3775.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2021 08:39:38.8097
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: L7kiBcJPDxXflfQVM+Wuni1vYY6zvTUFFi7dW9LreUYzQZkuoDGV6Zt7UfSG8Gq8
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3950
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 13.09.21 um 10:34 schrieb Paul Menzel:
> The warning
>
>      amdgpu 0000:05:00.0: amdgpu: Trusted Memory Zone (TMZ) feature not supported
>
> leaves the reader wondering, if anything can be done about it. As it’s
> unsupported in the hardware, and nothing can be done about, mention that
> in the log message.
>
>      amdgpu 0000:05:00.0: amdgpu: Trusted Memory Zone (TMZ) feature not supported by hardware

I think we should just completely remove the message instead.

Christian.

>
> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
> index c7797eac83c3..c4c56c57b0c0 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
> @@ -599,7 +599,7 @@ void amdgpu_gmc_tmz_set(struct amdgpu_device *adev)
>   	default:
>   		adev->gmc.tmz_enabled = false;
>   		dev_warn(adev->dev,
> -			 "Trusted Memory Zone (TMZ) feature not supported\n");
> +			 "Trusted Memory Zone (TMZ) feature not supported by hardware\n");
>   		break;
>   	}
>   }