Received: by 2002:a05:6a10:6d25:0:0:0:0 with SMTP id gq37csp1629868pxb; Mon, 13 Sep 2021 01:48:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzi9Fqq51YP+7orSZt6Egv4bLDh+VnqC1cwn5dhuTRIdJqTDv6kcLiwfHES4mdMkHu2JAVj X-Received: by 2002:aa7:cd92:: with SMTP id x18mr11885611edv.325.1631522930136; Mon, 13 Sep 2021 01:48:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631522930; cv=none; d=google.com; s=arc-20160816; b=FE7kqZCk++m8gAykgZ8FaavykeKQqE6AGtiJrIRR+xFXMSu9inUQ4SVJtGW9beA6/P tuORxtRrkovH7tEASFK2gy4EyuMQFQpX/uZynmpMKpeH3WV00g0lYFxFwHzIU5CNAFIP /NexCkU0nFgsUqYBjdcOCnmEAP2i4k2jFpZXJHn23KZ1miatFLD7xy8fxmH1+PaA4OI6 MdomfHwtHl91CvI1ZrVfsETNQMZ1keKuOgyPnd83Li2xYWNC5AZz3/nMwzw1S6GbeaEi EMSyp1Sal4IgRt2TC14keQLT81bnODRCEBPkq56GT5z+7yHAnFrjFBBVimjeHOcoZUqu Nxhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=qBEtqyBRKy0FvVPGp0L6p55j5QPlsxKY9JnLfBHA49E=; b=KKFPKXKyAYqVX38899guyqDJ6J4jym9ZZ7/iWysaQ2AAKl4510caRKNMD4PHutUR6w 4gIf6cRTkkY1bm0C7CLjUxoI4igrJivBIkt2RJ+U3fxGWllkK396Qmihg4IuhIzHNYDC t24CZaDOPxKGFP10qRfWrxmcIXJRxrffiMJLNI9sBniJQd7IzcuTbZDHhwKrbu4bZExY pT92QW22n5lzuMs85yYYtY26DDQz037ymDLwhz8p9neVRboPCMVXwMkASgCqS49753Cv IaYeNv4x/g+SzaPCNnyeV+GMtC+cprUeHWsFsri3Jt8K6X9kU0nPNLGwUpGzgsnDKh5f 6Mfw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=i0ArtbFc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i18si7806111edc.541.2021.09.13.01.48.26; Mon, 13 Sep 2021 01:48:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=i0ArtbFc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238148AbhIMIr5 (ORCPT + 99 others); Mon, 13 Sep 2021 04:47:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236022AbhIMIr5 (ORCPT ); Mon, 13 Sep 2021 04:47:57 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A41EFC061574; Mon, 13 Sep 2021 01:46:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=qBEtqyBRKy0FvVPGp0L6p55j5QPlsxKY9JnLfBHA49E=; b=i0ArtbFcISHx/+zkmIgm9gt9eP 8DqMOV0idSMksIUuIZj/5KqUCMLiYoWJxKpzHTV7pK/VUBLpoZb7ahqlRERcFzwH31HDQaThxVl43 BZvPQRj5iBZqwL2T/X2KCzYFz0j/3GoScGq0++Eb02HmjkihQ2sBvXKJJXRioffdFXEOLam9/rU9X ipcuTGkZWu9Dg+3jT6k5KgkNr4qzz9MPEjbkzDKNHvHZtDrNHhaBhta5KZXk82X8Vyy9+cmZ5g8BI IEugeXG4i3WpSD+Vv0rkJlgg7wQBZIDAnAOJSN+yZ7Ch4D58iAdfkcRZbZYqDGE8EyForyC75s6mY QB3m2e2A==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mPhXw-00DKDH-Aa; Mon, 13 Sep 2021 08:42:46 +0000 Date: Mon, 13 Sep 2021 09:42:36 +0100 From: Christoph Hellwig To: Jan H??ppner Cc: Luis Chamberlain , axboe@kernel.dk, gregkh@linuxfoundation.org, chaitanya.kulkarni@wdc.com, atulgopinathan@gmail.com, hare@suse.de, maximlevitsky@gmail.com, oakad@yahoo.com, ulf.hansson@linaro.org, colin.king@canonical.com, shubhankarvk@gmail.com, baijiaju1990@gmail.com, trix@redhat.com, dongsheng.yang@easystack.cn, ceph-devel@vger.kernel.org, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, sth@linux.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com, borntraeger@de.ibm.com, oberpar@linux.ibm.com, tj@kernel.org, linux-s390@vger.kernel.org, linux-mtd@lists.infradead.org, linux-mmc@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/9] s390/block/dasd_genhd: add error handling support for add_disk() Message-ID: References: <20210902174105.2418771-1-mcgrof@kernel.org> <20210902174105.2418771-7-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 13, 2021 at 10:17:48AM +0200, Jan H??ppner wrote: > I think, just like with some of the other changes, there is some > cleanup required before returning. I'll prepare a patch and > come back to you. If you are touching the dasd probe path anyway, can you look insto switching to use blk_mq_alloc_disk as well? Right now dasd allocates the request_queue and gendisk separately in different stages of initialization, but unlike SCSI which needs to probe using just the request_queue I can't find a good reason for that.