Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 13 Sep 2021 11:47:51 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     kbuild@lists.01.org, Yafang Shao <laoar.shao@gmail.com>
Cc:     lkp@intel.com, kbuild-all@lists.01.org,
        linux-kernel@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>
Subject: [peterz-queue:sched/core 13/19] kernel/sched/debug.c:453
 print_cfs_group_stats() warn: variable dereferenced before check 'se' (see
 line 444)
Message-ID: <202109111001.XChyxkS3-lkp@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?t0Sb7aToH9ivzu+58QJ2l5R3lHl4zVXjIJgPX8JLB58ezfuMoxIzfIIwTwL9?=
 =?us-ascii?Q?mJgdgZGNye5IiVS9QAiM9YEOwUDMofiveEqXvNvW2WOIWDR5sxTC0a1PUCSe?=
 =?us-ascii?Q?mXCDOREBmOIYN/WPZmskaJuBVavyPj4T0Gm3JH5tcV7o/Oro7HfiIjbsnxBX?=
 =?us-ascii?Q?iwgtQHOR9K3tvbzn2oMjYfVYiLCIO6kPeueXRiuIPe5r7SFEGvsI/P3+OLPY?=
 =?us-ascii?Q?vKeyxZ58Nu2J1w88Zb4aU3Brq2CqXGDktXEO4bFU114Fs2zKYGpyqNwUnXQf?=
 =?us-ascii?Q?m1R5TX8vg288JQtcMYFCcdXQIL4DqzrYJr4yDGm6zVjXF2KWw6MY0EkCuW0s?=
 =?us-ascii?Q?5LJbrNVaMRO+e0df/n3qhc2AQYWvCv6OTHz2m7S+BbK1sD/gBEe3dziSgz6x?=
 =?us-ascii?Q?nNljSiXIr6CogMit/DnXNhLIZF9FfdhJ6kH4Bxu/W+zUrMQJ90X2jcKL8JHk?=
 =?us-ascii?Q?bXQRAzaoMHL8eK365Mu7Xl7o0OTxIf36R/lLRPNGa7RPCo8nzUcRcs8oFFRM?=
 =?us-ascii?Q?4PN5H3M7TzqiGDSNILqiUvqvT+w+iEGcMJj2YV6CzW3FGJofSMmny7XBv8Ip?=
 =?us-ascii?Q?hywBXSPJ9cc3RAeD+8K4P9Rut5uIaVWcFMbOYgUoBszfePYGLFWi2RQd0Eqd?=
 =?us-ascii?Q?bq15EAIccIZ3tbVJU7QhJtEzh9Ci/PVl9fYCcWJmhOjq+OROUfxKVcv7fqWq?=
 =?us-ascii?Q?ODolKXQv5ylW+bJ5U1s+H+UgWsV0HeI2xuLI4o77enO96ijRetK6ZwtCp/qq?=
 =?us-ascii?Q?Wh0/AldsRB934gB571vlZWjMwTiV1VHpq8+1eCeiS++aIkkAwUE5pzdBQd2D?=
 =?us-ascii?Q?KtT9F2dl+ZWsD7M6CGIHvLWgHZDn7EdJUx+e/t72Yn3qMmv+Bl5Bw6r97acK?=
 =?us-ascii?Q?67DTJuK7jeleCOMhs2IMzRh31aE0FfFy8oK/UUxSWnXBWf+LHWktw8RmHIGL?=
 =?us-ascii?Q?mrvMmq+q+qZWAZPBWBLU0rkvSJ6EG/O+2tesZUEw9I8Nx5ZMlnqkUKbUu5G9?=
 =?us-ascii?Q?DMiYy+r1tP8FKoiIfpVdE3xsHhhWSaP9TJTrEHKWeNPpwprzNKhzDOpGBq6r?=
 =?us-ascii?Q?eiIWwUJy0WzZiF0pnqSvS2RxTrlVLqtQLCTPrlszI3lrzyKEi5MD8YwokW6t?=
 =?us-ascii?Q?5h1sIZIbVt4KAvoj0XMl3m5gMHE+YaQGHDzjevon4DGKkMLcjwd671tPxTDu?=
 =?us-ascii?Q?6TJacNOj8r6q/sUW1kHy9+olPCYwqm6/2cMrSyo6f8SPXxJBuBGecuxf/n7z?=
 =?us-ascii?Q?x0fCQKYugpfaIfkntVqVBlIZMdYYixEub6WLIbGWRPbC7qpuvFX6mSeBTphr?=
 =?us-ascii?Q?l7ahptI42FV0nU1GX9qP04iI?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 01867fa1-fd5c-4d4a-542b-08d9769335fb
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2021 08:48:08.8728
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VfX6wRlsuX8XzTvPbp41bcd0PyH8ZZGdNcuuqesJcur3FO7lvdt4T0chPcPmjo/pWSGYEu9zEKzrIY12cAZtMyl+En7euTcr6/yOucJ/01o=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1485
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10105 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 suspectscore=0
 phishscore=0 mlxlogscore=999 malwarescore=0 mlxscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109030001
 definitions=main-2109130058
X-Proofpoint-GUID: bOJPjSFtzwQd6DU56QwgFZ6ibx8ca0TM
X-Proofpoint-ORIG-GUID: bOJPjSFtzwQd6DU56QwgFZ6ibx8ca0TM
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git sched/core
head:   2dfdb3d20ad50e2ae2cb84cbceb0f0fc75e79e5d
commit: 445d9e8ba05d5e9e4b26956b7fe529223e29d8d1 [13/19] sched: make struct sched_statistics independent of fair sched class
config: x86_64-randconfig-m001-20210910 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
kernel/sched/debug.c:453 print_cfs_group_stats() warn: variable dereferenced before check 'se' (see line 444)

vim +/se +453 kernel/sched/debug.c

3866e845ed5222 kernel/sched/debug.c Steven Rostedt (Red Hat  2016-02-22  439) 
ff9b48c3598732 kernel/sched_debug.c Bharata B Rao            2008-11-10  440  #ifdef CONFIG_FAIR_GROUP_SCHED
5091faa449ee0b kernel/sched_debug.c Mike Galbraith           2010-11-30  441  static void print_cfs_group_stats(struct seq_file *m, int cpu, struct task_group *tg)
ff9b48c3598732 kernel/sched_debug.c Bharata B Rao            2008-11-10  442  {
ff9b48c3598732 kernel/sched_debug.c Bharata B Rao            2008-11-10  443  	struct sched_entity *se = tg->se[cpu];
445d9e8ba05d5e kernel/sched/debug.c Yafang Shao              2021-09-05 @444  	struct sched_statistics *stats = __schedstats_from_se(se);
                                                                                                                                      ^^
New unchecked dereference.

ff9b48c3598732 kernel/sched_debug.c Bharata B Rao            2008-11-10  445  
97fb7a0a8944bd kernel/sched/debug.c Ingo Molnar              2018-03-03  446  #define P(F)		SEQ_printf(m, "  .%-30s: %lld\n",	#F, (long long)F)
445d9e8ba05d5e kernel/sched/debug.c Yafang Shao              2021-09-05  447  #define P_SCHEDSTAT(F)	SEQ_printf(m, "  .%-30s: %lld\n",	\
445d9e8ba05d5e kernel/sched/debug.c Yafang Shao              2021-09-05  448  		#F, (long long)schedstat_val(stats->F))
97fb7a0a8944bd kernel/sched/debug.c Ingo Molnar              2018-03-03  449  #define PN(F)		SEQ_printf(m, "  .%-30s: %lld.%06ld\n", #F, SPLIT_NS((long long)F))
445d9e8ba05d5e kernel/sched/debug.c Yafang Shao              2021-09-05  450  #define PN_SCHEDSTAT(F)	SEQ_printf(m, "  .%-30s: %lld.%06ld\n", \
445d9e8ba05d5e kernel/sched/debug.c Yafang Shao              2021-09-05  451  		#F, SPLIT_NS((long long)schedstat_val(stats->F)))
ff9b48c3598732 kernel/sched_debug.c Bharata B Rao            2008-11-10  452  
cd126afe838d7e kernel/sched/debug.c Yuyang Du                2015-07-15 @453  	if (!se)
                                                                                    ^^^
The old code assumed "se" can be NULL.

18bf2805d9b30c kernel/sched/debug.c Ben Segall               2012-10-04  454  		return;
18bf2805d9b30c kernel/sched/debug.c Ben Segall               2012-10-04  455  
ff9b48c3598732 kernel/sched_debug.c Bharata B Rao            2008-11-10  456  	PN(se->exec_start);
ff9b48c3598732 kernel/sched_debug.c Bharata B Rao            2008-11-10  457  	PN(se->vruntime);

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org