Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 13 Sep 2021 11:21:43 +0200
From:   Jens Wiklander <jens.wiklander@linaro.org>
To:     Daniel Thompson <daniel.thompson@linaro.org>
Cc:     CGEL <cgel.zte@gmail.com>, Sumit Garg <sumit.garg@linaro.org>,
        op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org,
        jing yangyang <jing.yangyang@zte.com.cn>,
        Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH linux-next] tee/optee/shm_pool: fix application of sizeof
 to pointer
Message-ID: <20210913092143.GA165502@jade>
References: <c66fd6f831571b53b741350513e36405bba6c666.1629211976.git.jing.yangyang@zte.com.cn>
 <20210902103428.bdbkybvi6he6mgy2@maple.lan>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20210902103428.bdbkybvi6he6mgy2@maple.lan>
Precedence: bulk

On Thu, Sep 02, 2021 at 11:34:28AM +0100, Daniel Thompson wrote:
> On Thu, Aug 19, 2021 at 08:21:27PM -0700, CGEL wrote:
> > From: jing yangyang <jing.yangyang@zte.com.cn>
> > 
> > sizeof when applied to a pointer typed expression gives the size of
> > the pointer.
> > 
> > ./drivers/tee/optee/shm_pool.c:38:28-34: ERROR application of sizeof to pointer
> > 
> > This issue was detected with the help of Coccinelle.
> > 
> > Reported-by: Zeal Robot <zealci@zte.com.cn>
> > Signed-off-by: jing yangyang <jing.yangyang@zte.com.cn>
> 
> This should not affect code generation since both pages and *pages are
> pointers but the change looks good to me.
> 
> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>

Thanks for reviewing, I agree with your analysis. 
I'm picking this up as a bugfix for V5.15.

Cheers,
Jens