Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: NAK: [PATCH][next] media: pvrusb2: add newline between two
 statements
To:     Colin Ian King <colin.king@canonical.com>,
        Mike Isely <isely@pobox.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-media@vger.kernel.org
Cc:     kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20210902220112.55824-1-colin.king@canonical.com>
 <52c324ad-2467-9edc-c386-bc5a086cecbc@canonical.com>
From:   Hans Verkuil <hverkuil@xs4all.nl>
Message-ID: <82d125bd-9d16-803d-754b-48aa79fde06c@xs4all.nl>
Date:   Mon, 13 Sep 2021 13:00:54 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <52c324ad-2467-9edc-c386-bc5a086cecbc@canonical.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 03/09/2021 00:02, Colin Ian King wrote:
> On 02/09/2021 23:01, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> There are two statements on the same line, add a newline to clean
>> this up.
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>>  drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
>> index d38dee1792e4..ca00b7fe1e7f 100644
>> --- a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
>> +++ b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
>> @@ -1727,7 +1727,8 @@ int pvr2_hdw_set_streaming(struct pvr2_hdw *hdw,int enable_flag)
>>  				   enable_flag ? "enable" : "disable");
>>  		}
>>  		pvr2_hdw_state_sched(hdw);
>> -	} while (0); LOCK_GIVE(hdw->big_lock);
>> +	} while (0);
>> +	LOCK_GIVE(hdw->big_lock);
>>  	if ((ret = pvr2_hdw_wait(hdw,0)) < 0) return ret;
>>  	if (enable_flag) {
>>  		while ((st = hdw->master_state) != PVR2_STATE_RUN) {
>>
> 
> ignore, V2 being sent in a moment.

I haven't seen a V2 yet... In any case, I've rejected this patch in patchwork.

Regards,

	Hans