Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com;
Date:   Mon, 13 Sep 2021 19:29:45 +0800
From:   Huang Rui <ray.huang@amd.com>
To:     Shuah Khan <skhan@linuxfoundation.org>
CC:     "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Borislav Petkov <bp@suse.de>, Ingo Molnar <mingo@kernel.org>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "Sharma, Deepak" <Deepak.Sharma@amd.com>,
        "Deucher, Alexander" <Alexander.Deucher@amd.com>,
        "Limonciello, Mario" <Mario.Limonciello@amd.com>,
        "Fontenot, Nathan" <Nathan.Fontenot@amd.com>,
        "Su, Jinzhou (Joe)" <Jinzhou.Su@amd.com>,
        "Du, Xiaojian" <Xiaojian.Du@amd.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH 13/19] cpupower: add the function to check amd-pstate
 enabled
Message-ID: <20210913112945.GE3731830@hr-amd>
References: <20210908150001.3702552-1-ray.huang@amd.com>
 <20210908150001.3702552-14-ray.huang@amd.com>
 <50412248-179d-3548-aeb0-d912a14a152f@linuxfoundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <50412248-179d-3548-aeb0-d912a14a152f@linuxfoundation.org>
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2021 11:29:53.1255
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 87bd1362-60cf-4119-8eda-08d976a9ce4b
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT039.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB4984
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Sep 10, 2021 at 06:16:21AM +0800, Shuah Khan wrote:
> On 9/8/21 8:59 AM, Huang Rui wrote:
> > Introduce the cpupower_amd_pstate_enabled() to check whether the kernel
> > mode enables amd-pstate.
> > 
> 
> What does "kernel mode" mean? Are you referring to kernel vs.
> firmware mode?

I am referring kernel. In fact, the proccessor which supports the AMD
P-States also supports the legacy ACPI P-States as well. So this API is to
check whether the kernel driver is using amd-pstate or acpi-cpufreq.

I would have explained this, sorry to make you confused, I will explain the
details in the commit log at V2.

Thanks,
Ray

> 
> > Signed-off-by: Huang Rui <ray.huang@amd.com>
> > ---
> >   tools/power/cpupower/utils/helpers/helpers.h |  5 +++++
> >   tools/power/cpupower/utils/helpers/misc.c    | 20 ++++++++++++++++++++
> >   2 files changed, 25 insertions(+)
> > 
> > diff --git a/tools/power/cpupower/utils/helpers/helpers.h b/tools/power/cpupower/utils/helpers/helpers.h
> > index b4813efdfb00..eb43c14d1728 100644
> > --- a/tools/power/cpupower/utils/helpers/helpers.h
> > +++ b/tools/power/cpupower/utils/helpers/helpers.h
> > @@ -136,6 +136,11 @@ extern int decode_pstates(unsigned int cpu, int boost_states,
> >   
> >   extern int cpufreq_has_boost_support(unsigned int cpu, int *support,
> >   				     int *active, int * states);
> > +
> > +/* AMD PSTATE enabling **************************/
> > +
> > +extern unsigned long cpupower_amd_pstate_enabled(unsigned int cpu);
> > +
> >   /*
> >    * CPUID functions returning a single datum
> >    */
> > diff --git a/tools/power/cpupower/utils/helpers/misc.c b/tools/power/cpupower/utils/helpers/misc.c
> > index fc6e34511721..07d80775fb68 100644
> > --- a/tools/power/cpupower/utils/helpers/misc.c
> > +++ b/tools/power/cpupower/utils/helpers/misc.c
> > @@ -83,6 +83,26 @@ int cpupower_intel_set_perf_bias(unsigned int cpu, unsigned int val)
> >   	return 0;
> >   }
> >   
> > +unsigned long cpupower_amd_pstate_enabled(unsigned int cpu)
> > +{
> > +	char linebuf[MAX_LINE_LEN];
> > +	char path[SYSFS_PATH_MAX];
> > +	unsigned long val;
> > +	char *endp;
> > +
> > +	snprintf(path, sizeof(path),
> > +		 PATH_TO_CPU "cpu%u/cpufreq/is_amd_pstate_enabled", cpu);
> > +
> > +	if (cpupower_read_sysfs(path, linebuf, MAX_LINE_LEN) == 0)
> > +		return 0;
> > +
> > +	val = strtoul(linebuf, &endp, 0);
> > +	if (endp == linebuf || errno == ERANGE)
> > +		return 0;
> > +
> > +	return val;
> > +}
> > +
> >   #endif /* #if defined(__i386__) || defined(__x86_64__) */
> >   
> >   /* get_cpustate
> > 
>