Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 13 Sep 2021 13:05:02 +0100
From:   Stefan Hajnoczi <stefanha@redhat.com>
To:     Jason Wang <jasowang@redhat.com>
Cc:     mst@redhat.com, virtualization@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org, f.hetzelt@tu-berlin.de,
        david.kaplan@amd.com, konrad.wilk@oracle.com,
        Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 1/9] virtio-blk: validate num_queues during probe
Message-ID: <YT8+bhzt5uy3PBzD@stefanha-x1.localdomain>
References: <20210913055353.35219-1-jasowang@redhat.com>
 <20210913055353.35219-2-jasowang@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="TYQ9xRefSpUSapXV"
Content-Disposition: inline
In-Reply-To: <20210913055353.35219-2-jasowang@redhat.com>
Precedence: bulk


--TYQ9xRefSpUSapXV
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Sep 13, 2021 at 01:53:45PM +0800, Jason Wang wrote:
> If an untrusted device neogitates BLK_F_MQ but advertises a zero
> num_queues, the driver may end up trying to allocating zero size
> buffers where ZERO_SIZE_PTR is returned which may pass the checking
> against the NULL. This will lead unexpected results.
>=20
> Fixing this by using single queue if num_queues is zero.
>=20
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
> ---
>  drivers/block/virtio_blk.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

--TYQ9xRefSpUSapXV
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmE/Pm4ACgkQnKSrs4Gr
c8iH2AgAu2/zVPkm3h8QB33TiU7b3MgZx1rNvvDlWVmPXVNk5z/ibtU893Zqbz5k
5b/ir6SryiQCzsNHJ6dWLWZkpeEb5/puRlX3TrkOIKCvRXwW99C3v+F5H7PSmsHK
suAQ3qOXr8d0wKP3abOEbuA6Kc1/IOESqt8R46x5WY/ivrSO0+Hv3T9Q8qARJDof
bS/1hEea6dVAYGCtqENC0qQn/utltrIlReSohiKgQcKWwdq+M8iSiOc4BjLHZLnm
/vBvQbyGF9bhgHavnJ4UdHHG+3rV/rIxpL/JvAtk2EldNxyWqFinm+hKTlXVt814
4YMu8qCcYN4fZrklAyED5F5xFl1wJw==
=47Nn
-----END PGP SIGNATURE-----

--TYQ9xRefSpUSapXV--