Received: by 2002:a05:6a10:6d25:0:0:0:0 with SMTP id gq37csp1814663pxb; Mon, 13 Sep 2021 06:12:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzLe/BmAynudT0QG94WBi5W6LvPSj4pkDwwlIogKKsVPvqStAVa4BAzFH08t6mSXmPcshmj X-Received: by 2002:a17:906:3542:: with SMTP id s2mr12907021eja.379.1631538720963; Mon, 13 Sep 2021 06:12:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631538720; cv=none; d=google.com; s=arc-20160816; b=r5Yc11yuziWeLJK07d8wQyGpG8c53nRZJftXu08AUWwoLs2xUCGriTTHt/TMKLg4vQ R6fiDm+eY3nuLhK9eEbP8oVMKTPMHaLeVq03VVSDoWdedoCYywmvUIpVqAOTAssk2XwU xA4Y3J8c20vLf49UnLwgqT88DKO+kM1b3Lgjw27yaGPpFHyqGrk7BTnJM5fP/vGSi40/ Zkx8EYhWkfr4jj2yg4RxOgdBUMip7iRZVdKTVrr3B5PKJuU4fKXmQOVQIU2dgQY2o23U WvpsoDgzUSSv8+SLH/0qICqXLVz3G2hxTcn9EfavCtyOSICoj9Z/RcTr2rhf4p1ESOwK pjhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ttLJKLYi5pA+YcY2I7cFti2sz8nubJ1m8ZVVm6G8PV0=; b=O/NZ0S52VxpJv3H++Ey4M+h/6aG9eUFhPEW4ch7VyhwSma5vO2wz7bZp+4BeGS+Oqe Fh73JZJ3piJtV93RwwVOLPwOppkndZ+DCCy8gPJaSopbs+NIcEK7hDIWoRa6MVyQyPSq CBKpY1wpRc/dRA0ooSTmNS/jsBfRigkBG9OSaIHMa/JBN3GNDD5YFXVuj/1VBku43Qa+ 0DgU94g2c4mYL2jA+lyJc6q4VvPfwr9PJ1eP7FaQKunoYQt/nnVruFV/Q1r2NRPC7uyC E4S9XBew8xFub3RFCbe8XfymEQyTRg8A4EDVcH0WEYnRqcM52r1LpD2yaArjz8eN7mXr XFFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b="A1SS7/b6"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z21si7825256eji.707.2021.09.13.06.11.31; Mon, 13 Sep 2021 06:12:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b="A1SS7/b6"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238985AbhIMNIH (ORCPT + 99 others); Mon, 13 Sep 2021 09:08:07 -0400 Received: from mail.skyhub.de ([5.9.137.197]:51946 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238976AbhIMNGO (ORCPT ); Mon, 13 Sep 2021 09:06:14 -0400 Received: from zn.tnic (p200300ec2f097300d78cc1b25aec21e2.dip0.t-ipconnect.de [IPv6:2003:ec:2f09:7300:d78c:c1b2:5aec:21e2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 5BB911EC04E4; Mon, 13 Sep 2021 15:04:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1631538290; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=ttLJKLYi5pA+YcY2I7cFti2sz8nubJ1m8ZVVm6G8PV0=; b=A1SS7/b6jTZkO71Imi/1eJaJjRRpqn5FVqXGEw9yqppuvQ93HnXlCDFn99Z8nCzGK+MLZ/ Dwma2jcfQL5iutHcSs1pUm7945jiXM5VdKE+/4YZxvUDVfA06qEUNl+6fLX60j7nUAJGgB YVMP/zW1Kb455o7FxbLWKq6WBy8dI5I= Date: Mon, 13 Sep 2021 15:04:42 +0200 From: Borislav Petkov To: Huang Rui Cc: "Rafael J . Wysocki" , Viresh Kumar , Shuah Khan , Ingo Molnar , "linux-pm@vger.kernel.org" , "Sharma, Deepak" , "Deucher, Alexander" , "Limonciello, Mario" , "Fontenot, Nathan" , "Su, Jinzhou (Joe)" , "Du, Xiaojian" , "linux-kernel@vger.kernel.org" , "x86@kernel.org" Subject: Re: [PATCH 01/19] x86/cpufreatures: add AMD CPPC extension feature flag Message-ID: References: <20210908150001.3702552-1-ray.huang@amd.com> <20210908150001.3702552-2-ray.huang@amd.com> <20210913094851.GB3731830@hr-amd> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210913094851.GB3731830@hr-amd> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 13, 2021 at 05:48:51PM +0800, Huang Rui wrote: > This feature flag indicates the full MSR hardware solution of AMD > P-States, if it is not set, that means we will go with in shared > memory hardware solution. So we name this as extension. Nobody cares whether it is an extension except you guys. Also, having AMD_CPPC_EXT suggests there already is AMD_CPPC. But there isn't. So call it X86_FEATURE_AMD_CPPC, please, for simplicity's sake. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette