Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762931AbWLKONN (ORCPT ); Mon, 11 Dec 2006 09:13:13 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1762930AbWLKONM (ORCPT ); Mon, 11 Dec 2006 09:13:12 -0500 Received: from outpipe-village-512-1.bc.nu ([81.2.110.250]:52024 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1762918AbWLKONL (ORCPT ); Mon, 11 Dec 2006 09:13:11 -0500 Date: Mon, 11 Dec 2006 14:19:56 +0000 From: Alan To: Tejun Heo Cc: Jeff Garzik , linux-ide@vger.kernel.org, Catalin Marinas , Linux Kernel Mailing List Subject: Re: [PATCH] ata_piix: use piix_host_stop() in ich_pata_ops Message-ID: <20061211141956.5d161c9f@localhost.localdomain> In-Reply-To: <20061211132625.GA18947@htj.dyndns.org> References: <20061211132625.GA18947@htj.dyndns.org> X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 712 Lines: 18 On Mon, 11 Dec 2006 22:26:25 +0900 Tejun Heo wrote: > piix_init_one() allocates host private data which should be freed by > piix_host_stop(). ich_pata_ops wasn't converted to piix_host_stop() > while merging, leaking 4 bytes on driver detach. Fix it. > > This was spotted using Kmemleak by Catalin Marinas. > > Signed-off-by: Tejun Heo > Cc: Catalin Marinas Acked-by: Alan Cox - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/