Received: by 2002:a05:6a10:6d25:0:0:0:0 with SMTP id gq37csp1865249pxb; Mon, 13 Sep 2021 07:11:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxpBWbhwRT01nxli5qzBHL7vG3QL99YBCmlnQeQAqeRJ0LKW0EAxOuhP7w6yrFD9Jbeze1j X-Received: by 2002:a6b:5a1a:: with SMTP id o26mr9245921iob.40.1631542269553; Mon, 13 Sep 2021 07:11:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631542269; cv=none; d=google.com; s=arc-20160816; b=FfgNxh1F3gDEAiuDmK1t5p9C3ZTsnZvPeZQI1v2LQCvQ3ZyYSx5QcPxGvl0WJ8jowH vCjJEyoEXczIuYmvO2MwjyyE9UfUgU+dgNgH51z6XuIaVee2w7Y0c9TcvbAtHIBNV9Eo jeVGcAfJGmgSUnWUivwgzlbn8wa+tmXF57s0t3bWIBMPMWzlPMJJYYFMp9xgM/n90ynx KIYEg8wd+x2kfFiS1NFEo8qo4zz+P9hi+bKY33jT5I8vQ/ujxWRmYi6Q4zfLcSNOprCS T9s+7nxw2WT6P3IKnE1xbppkuvGSoWJosfmcTdR+V1FwUqxJECHNf7ilcEDQ995x5zOm 4png== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=2nWk3qJ7v7NSvJclUzkKsHrNg+aiww+3758YoiSW+Jc=; b=H0lVUFbQxkJFWkf5L8RgEdGQAiPFkV0xcPamQcl1+55rbbKl8iD7peBLJxaM4IHSrx CXlGQPQ/6RQQoU33v4nxyHZB6l+4c/MbCZ+vL0p2chPbEiDGydbsnGJrap7O+GK7UmSj Gd1EighRajuQtudGZ/mKt5Uojxxj/W1zv/KYbhQpusW2v2dml2aGtsc34qs5eVo7KDiX uF11POBKgnMPvchCkQvcI5phmyt6tpwWcdCuHg4VmyeQWmxBHOs6tUiJXU5YJebrkEGo 9zIkiqdk9CjL+tBGtsjf5JOyFbV6jhl1T+xw91l7wk9QBkSLP4ZRfWiTWJkBXQOgwGRG mphg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Eb+7NBO4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q7si8286603ilu.111.2021.09.13.07.10.54; Mon, 13 Sep 2021 07:11:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Eb+7NBO4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343666AbhIMOId (ORCPT + 99 others); Mon, 13 Sep 2021 10:08:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:55990 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344551AbhIMOFJ (ORCPT ); Mon, 13 Sep 2021 10:05:09 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 874F061A59; Mon, 13 Sep 2021 13:39:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631540368; bh=4kCv7o3DyBpw7GqvoIMxTDt9C8B3zSsa+dFEur62VKU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Eb+7NBO4bpDl4yc80JXsGnXHdLtO5Wgpg827wzRpIpmGiFyQp9BqQyrsytj0s9a5W CMaI53CV8//barowbsdSL0Heg1tsI8wlS0PvV4rkv/0o4/AdZYcB9VpnxtAxHYtPxY Y6hbcyGNjA394BR+XfqWYxGmMUl65tjsVjNFnR/8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Laurent Pinchart , Kieran Bingham , Sasha Levin Subject: [PATCH 5.13 133/300] drm: rcar-du: Dont put reference to drm_device in rcar_du_remove() Date: Mon, 13 Sep 2021 15:13:14 +0200 Message-Id: <20210913131113.884016854@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210913131109.253835823@linuxfoundation.org> References: <20210913131109.253835823@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Laurent Pinchart [ Upstream commit c29b6b0b126e9ee69a5d6339475e831a149295bd ] The reference to the drm_device that was acquired by devm_drm_dev_alloc() is released automatically by the devres infrastructure. It must not be released manually, as that causes a reference underflow.. Fixes: ea6aae151887 ("drm: rcar-du: Embed drm_device in rcar_du_device") Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham Signed-off-by: Sasha Levin --- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index bfbff90588cb..c22551c2facb 100644 --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c @@ -556,8 +556,6 @@ static int rcar_du_remove(struct platform_device *pdev) drm_kms_helper_poll_fini(ddev); - drm_dev_put(ddev); - return 0; } -- 2.30.2