Received: by 2002:a05:6a10:6d25:0:0:0:0 with SMTP id gq37csp1865566pxb; Mon, 13 Sep 2021 07:11:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzKcPtuqWAhtxYb6KmQxTZCubLsYI1yIPrDY1y4sLgbZjRu0KHgjY7JDCm4zF171Ul5W8pO X-Received: by 2002:a92:444e:: with SMTP id a14mr8431894ilm.152.1631542287179; Mon, 13 Sep 2021 07:11:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631542287; cv=none; d=google.com; s=arc-20160816; b=h3uQYBqdfi784OmPQw4HC5aMzXrYDD5OL67CEIBY3yE6fhxfdxCSxZJO+yYy9Ii/mi 4QVEk8GscRalPqb4MoEzOO5X7um79uza6IZd7MXaKXKf/FMaY0HNu0Wxk2Q1MxQifA/G CQ2q3kVuqb3K83UnlFpERE/xyl9SZxO2L4eLP6bjRizGlMJaYRMuoDc3sSQ8ayQUZS4+ F8qMTlb/b92rpmjanpHb5A03YyjOtqDBDbswWWIjWI1qzgM+dQXMHUf2drrClnpV/dCg VhDDu80Sgfl8QPcTSCkZZ+7yjBJxnuT4ChqjdxhN1YuZORP+n2PuO6EXpHkRDVnhjJVL 76Dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Q3wcDtvUUhODqcXqUiMrf26cbGURCZApbLND7jUUnHM=; b=uQjI5547wEJa9SduVVva+hTdVtR1c093g39hDsP8vPLVzI+jfsFFIU5OvFKZ3rlpvd AWvSkh5PR4SvVXK0TCOrHongO6AbEQJmcwP1PQspXkrddBhZbFH6NYdsy3ueI9w/DtfN 1fsSZbtI28d0ECNJJrVDQxnWhRFAViW7FvP366AQA5v/xdM/kQRcc8lzu9KfY2NYoAyW fBU8POneLrIAuXUmgcRDBXRzEt65M0g/t3DM2Y3g36VaVJF4ca1wxlX+lOKS8TsH0X64 bbCb4blVS+Ae5mRph82LBNQmi8i2IcsJKdsOv6amSwrE8A5ABI+ZJboK6XJidgMfGURM uglw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=VIBBizvg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h15si7026634ili.36.2021.09.13.07.11.14; Mon, 13 Sep 2021 07:11:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=VIBBizvg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243551AbhIMOKU (ORCPT + 99 others); Mon, 13 Sep 2021 10:10:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:55996 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343979AbhIMOHJ (ORCPT ); Mon, 13 Sep 2021 10:07:09 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 42EAF61A82; Mon, 13 Sep 2021 13:40:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631540418; bh=HVmiHrBeFNiqaH8sduhcxvABJ2yP4wydtgEcHmO945o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VIBBizvgW207SSLmHygibgyxxMlsKwptqZO6jhnAoIRIIWtbd/qrGFTZmwJOqdGpc PgtM7vqULB1cE46Qefo9LODcuWiusYFclu3xKhmoZBQ07HFjjSadhkOPpjimLQAx5w v0YSgcsBjdEUBUs7nbE5GvSSMx+pBNk5UNRrcE/M= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Felipe Balbi , Sergey Shtylyov , Sasha Levin Subject: [PATCH 5.13 185/300] usb: phy: twl6030: add IRQ checks Date: Mon, 13 Sep 2021 15:14:06 +0200 Message-Id: <20210913131115.641811586@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210913131109.253835823@linuxfoundation.org> References: <20210913131109.253835823@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sergey Shtylyov [ Upstream commit 0881e22c06e66af0b64773c91c8868ead3d01aa1 ] The driver neglects to check the result of platform_get_irq()'s calls and blithely passes the negative error codes to request_threaded_irq() (which takes *unsigned* IRQ #), causing them both to fail with -EINVAL, overriding an original error code. Stop calling request_threaded_irq() with the invalid IRQ #s. Fixes: c33fad0c3748 ("usb: otg: Adding twl6030-usb transceiver driver for OMAP4430") Acked-by: Felipe Balbi Signed-off-by: Sergey Shtylyov Link: https://lore.kernel.org/r/9507f50b-50f1-6dc4-f57c-3ed4e53a1c25@omp.ru Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/phy/phy-twl6030-usb.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/usb/phy/phy-twl6030-usb.c b/drivers/usb/phy/phy-twl6030-usb.c index 8ba6c5a91557..ab3c38a7d8ac 100644 --- a/drivers/usb/phy/phy-twl6030-usb.c +++ b/drivers/usb/phy/phy-twl6030-usb.c @@ -348,6 +348,11 @@ static int twl6030_usb_probe(struct platform_device *pdev) twl->irq2 = platform_get_irq(pdev, 1); twl->linkstat = MUSB_UNKNOWN; + if (twl->irq1 < 0) + return twl->irq1; + if (twl->irq2 < 0) + return twl->irq2; + twl->comparator.set_vbus = twl6030_set_vbus; twl->comparator.start_srp = twl6030_start_srp; -- 2.30.2