Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934424AbWLKOWn (ORCPT ); Mon, 11 Dec 2006 09:22:43 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S934487AbWLKOWn (ORCPT ); Mon, 11 Dec 2006 09:22:43 -0500 Received: from mx1.redhat.com ([66.187.233.31]:55479 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934424AbWLKOWm (ORCPT ); Mon, 11 Dec 2006 09:22:42 -0500 From: David Howells In-Reply-To: <20061211132540.GA4629@APFDCB5C> References: <20061211132540.GA4629@APFDCB5C> <29447.1165840536@redhat.com> To: Akinobu Mita Cc: David Howells , torvalds@osdl.org, akpm@osdl.org, linux-kernel@vger.kernel.org Subject: Re: Mark bitrevX() functions as const X-Mailer: MH-E 8.0; nmh 1.1; GNU Emacs 22.0.50 Date: Mon, 11 Dec 2006 14:22:30 +0000 Message-ID: <17788.1165846950@redhat.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 661 Lines: 16 Akinobu Mita wrote: > __attribute_pure__ ? I'm not sure "pure" is better than const in this case. Although it *does* look at a global variable (byte_rev_table), that variable is constant. In effect, the functions output does only depend on its input. The R/O data it requires is no different to its out of line code. You'd have to consult a compiler wrangler to be sure, though. David - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/