Received: by 2002:a05:6a10:6d25:0:0:0:0 with SMTP id gq37csp1866621pxb; Mon, 13 Sep 2021 07:12:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyBVrc3hkZZAx5Pvg69yeFN/bZCWSbeYlGV5PgUnuBqExnuQ70FYdb7cSsdBzvDlCtcuELG X-Received: by 2002:a02:2452:: with SMTP id q18mr9883885jae.116.1631542345997; Mon, 13 Sep 2021 07:12:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631542345; cv=none; d=google.com; s=arc-20160816; b=k/u7vfdTHOwgFDV80J4V+TS8Mea7prTM/Ysq7vZEWEwwdT8pgxf0ujmR0tfKQv+9B8 ddzUGGLpcvUFN5OOFewByTpIb8MgUai230TAENbjaxahPngOlZyPPW5uATET6tviSBKO obu84PFMawr7TwchtovOqxSqgRHXtvVtg+KUUPgKL1ps69VOIa9YKO7h6XNc0XKKCeKY 01O0DgcVBHB+l9ss7CEEJR4OCB4niqt9HosYrkEZqoWcahWAkRfyG7xO9xBK+KbGXEuc CH4WgbJACg2usGPxM605mTXzts+l/4+lsJsxKX5jYXjY5btpDqVSjRVX3QVgWjVyGgJ2 b7Nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Zj+UDhNxwHVt43+/c7KDRwf1NGGCGyaKEdVux+guE+4=; b=SuBpEC0TKZFaC6kuWGfnu09HBVca6QdIvOfRIWv/FdClV2X1Z+3DoicTz8mnGMpTcQ dpTai7IJYpQ8Jo9xHw+u9W1cDaO6SpSn3HgWfCc4c/Xevq3NoDTcHw3lDcnDh43B8cMy t58L+rGotxIOZHC5QYahNY5yNHjfX7Rr9Nag9zc5S/nSX0PtR5mfP3bdK+V/s46abxlr bR9Yamih0RRyiwUXFPy8YF3U3Feg0aSyYE0NV0fzp27y0hf2qShQ4ARovjPKN9RMgQms GaEtyGlg9PCZ2sy6osgybIXrQi7Jbf7t3ayL6Zb7+h2blvEyDZnlVAaQH2QW+OvwbH0I hyFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=h2M9dbxe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w16si8061287iol.0.2021.09.13.07.12.12; Mon, 13 Sep 2021 07:12:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=h2M9dbxe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343538AbhIMOKn (ORCPT + 99 others); Mon, 13 Sep 2021 10:10:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:58336 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244661AbhIMOHQ (ORCPT ); Mon, 13 Sep 2021 10:07:16 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C3AB661A7F; Mon, 13 Sep 2021 13:40:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631540433; bh=JBQB5X22bH4OzR+eKPJgzLOALvNt7tgd3bqA+ZtKwIc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=h2M9dbxeRz0h9bp66rp134CKaisdqc0+ScZxIWokMPRzn2CxP253smQE0Yyg5fMLE SNN5wcgmBsBWRCRLDWNK4t9sNwXtrv8c1UFoiIiLOjjLOqpwfyiqDvv7JXfWamDKXc Vd0SqQiqKb85OKqdyZ5i6Ef6Jgvc0Mw5gsX1ihoQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Voon Weifeng , Vijayakannan Ayyathurai , "David S. Miller" , Sasha Levin Subject: [PATCH 5.13 190/300] net: stmmac: fix INTR TBU status affecting irq count statistic Date: Mon, 13 Sep 2021 15:14:11 +0200 Message-Id: <20210913131115.803296796@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210913131109.253835823@linuxfoundation.org> References: <20210913131109.253835823@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Voon Weifeng [ Upstream commit 1975df880b959e30f28d66148a12d77b458abd76 ] DMA channel status "Transmit buffer unavailable(TBU)" bit is not considered as a successful dma tx. Hence, it should not affect all the irq count statistic. Fixes: 1103d3a5531c ("net: stmmac: dwmac4: Also use TBU interrupt to clean TX path") Signed-off-by: Voon Weifeng Signed-off-by: Vijayakannan Ayyathurai Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c index e63270267578..f83db62938dd 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c @@ -172,11 +172,12 @@ int dwmac4_dma_interrupt(void __iomem *ioaddr, x->rx_normal_irq_n++; ret |= handle_rx; } - if (likely(intr_status & (DMA_CHAN_STATUS_TI | - DMA_CHAN_STATUS_TBU))) { + if (likely(intr_status & DMA_CHAN_STATUS_TI)) { x->tx_normal_irq_n++; ret |= handle_tx; } + if (unlikely(intr_status & DMA_CHAN_STATUS_TBU)) + ret |= handle_tx; if (unlikely(intr_status & DMA_CHAN_STATUS_ERI)) x->rx_early_irq++; -- 2.30.2