Received: by 2002:a05:6a10:6d25:0:0:0:0 with SMTP id gq37csp1870956pxb; Mon, 13 Sep 2021 07:17:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyI3RdjQIai0L52jn10QuyLJmNQu6XFQXP8zVe4N+cSHEnUSBi0SRIPGsA4lUYgyiLgIX6u X-Received: by 2002:a05:6638:5b5:: with SMTP id b21mr9749325jar.109.1631542621526; Mon, 13 Sep 2021 07:17:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631542621; cv=none; d=google.com; s=arc-20160816; b=m5ZLe/9RgnvBY8brmuKGgUfbxR2oRmou0I+1DZYyVE5mepxuvZSZ+b0jBYRm288eEI ng2P4sxHewytDn74C0qTEJ5b/N5vwQA368eCjIdmBBufv3jm79JyW6uDubsjZFYvAeT4 BvVqmndrx5jiom15iqZGZV4zRU12rJYGD5ePZbEUSkguTMLKK6e8tUHOXjdsDfQqr0oX aq4nbqFDmzYuy/Kr5zWeDzXXVJa64FNIGosV2jwAXCOplEnG6k4L3NuArhHl6/uuBllt omqLjVeJBCZPkbpCi9j4IVCmh7HB5yOSzdoty2m7o3jVwryvXL3A7e0+x4n/g6s7MF4w Ectw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=monV/tE6SsI97SuK2pTkFpY60y36ACGoG6CVB6kg6Aw=; b=Z/GK6shYBGaJg6IPmTehP6kt82Rt6y/lkFBJf7bFiP65QWFO8bKxuUr3Wbiv307MLG dvBAAu1T7d5J0w4sTPY7h2cAQxFu+uSXaDwLYkbQbXONJ4W+UCsAX8q6h8RnMxWw2Pnr 1lR5NUO1P0SIjAjIFBrxsfB+8wmZHclAGpb8IKbdOFYo1n14+RdehJiXgNwH+wHUFKPu UInX9SuE7qyjS1xhhsQONEnDnHVvGK5JJrhJ00wrmWSHBDhBhxKAnPy4RD9CvYS9Uzok fAjPBJI2LgnYsJy/aksmB7nYCIAUDxggYBbWQlr+tcFkzGu7I4iBiNbzMERWoaJ88+Bd MzrQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=m6hfJRb7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 71si6596038jaw.105.2021.09.13.07.16.46; Mon, 13 Sep 2021 07:17:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=m6hfJRb7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344523AbhIMOQq (ORCPT + 99 others); Mon, 13 Sep 2021 10:16:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:37086 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344141AbhIMOOC (ORCPT ); Mon, 13 Sep 2021 10:14:02 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 546DA61AD2; Mon, 13 Sep 2021 13:43:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631540594; bh=FltRV8KHzsOVrWpAWAy6a7ugXJ2SGONGtUiGl0BMM4Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=m6hfJRb7G0hd2aXbN8G6gBGUSblezg2CMWINJXawXwFbifsp4F+xEU+yUq4nWdD2c XubVxYf9Jc0Y9eUbRQlfgZWiypSIFNUD9wCyCRUIHugpsNNcE/BX68uTI75pIoHNvT /BOxzA1GVvLP8a47AoM4MX6BMUNJOsoeqvWDzm7Q= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Michael Heimpold , Stefan Wahren , "David S. Miller" , Sasha Levin Subject: [PATCH 5.13 257/300] net: qualcomm: fix QCA7000 checksum handling Date: Mon, 13 Sep 2021 15:15:18 +0200 Message-Id: <20210913131118.025473694@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210913131109.253835823@linuxfoundation.org> References: <20210913131109.253835823@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Stefan Wahren [ Upstream commit 429205da6c834447a57279af128bdd56ccd5225e ] Based on tests the QCA7000 doesn't support checksum offloading. So assume ip_summed is CHECKSUM_NONE and let the kernel take care of the checksum handling. This fixes data transfer issues in noisy environments. Reported-by: Michael Heimpold Fixes: 291ab06ecf67 ("net: qualcomm: new Ethernet over SPI driver for QCA7000") Signed-off-by: Stefan Wahren Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/qualcomm/qca_spi.c | 2 +- drivers/net/ethernet/qualcomm/qca_uart.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qualcomm/qca_spi.c index ab9b02574a15..38018f024823 100644 --- a/drivers/net/ethernet/qualcomm/qca_spi.c +++ b/drivers/net/ethernet/qualcomm/qca_spi.c @@ -434,7 +434,7 @@ qcaspi_receive(struct qcaspi *qca) skb_put(qca->rx_skb, retcode); qca->rx_skb->protocol = eth_type_trans( qca->rx_skb, qca->rx_skb->dev); - qca->rx_skb->ip_summed = CHECKSUM_UNNECESSARY; + skb_checksum_none_assert(qca->rx_skb); netif_rx_ni(qca->rx_skb); qca->rx_skb = netdev_alloc_skb_ip_align(net_dev, net_dev->mtu + VLAN_ETH_HLEN); diff --git a/drivers/net/ethernet/qualcomm/qca_uart.c b/drivers/net/ethernet/qualcomm/qca_uart.c index bcdeca7b3366..ce3f7ce31adc 100644 --- a/drivers/net/ethernet/qualcomm/qca_uart.c +++ b/drivers/net/ethernet/qualcomm/qca_uart.c @@ -107,7 +107,7 @@ qca_tty_receive(struct serdev_device *serdev, const unsigned char *data, skb_put(qca->rx_skb, retcode); qca->rx_skb->protocol = eth_type_trans( qca->rx_skb, qca->rx_skb->dev); - qca->rx_skb->ip_summed = CHECKSUM_UNNECESSARY; + skb_checksum_none_assert(qca->rx_skb); netif_rx_ni(qca->rx_skb); qca->rx_skb = netdev_alloc_skb_ip_align(netdev, netdev->mtu + -- 2.30.2