Received: by 2002:a05:6a10:6d25:0:0:0:0 with SMTP id gq37csp1875216pxb; Mon, 13 Sep 2021 07:21:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz3VngLMmRXKQ/eMfzpGbt2dPrOSqRdma6qTVGUgY4CYVY5W4GMgkF4mLL49FfrP2Xg+aqp X-Received: by 2002:a05:6602:2ac7:: with SMTP id m7mr9234990iov.66.1631542875192; Mon, 13 Sep 2021 07:21:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631542875; cv=none; d=google.com; s=arc-20160816; b=NmiAOeQ+F4HpZzczsBkmmhsmkl3tHCdR5DTknbzo2+cZ8lyLrPF6XUHDRICr+BsbRf JTAYcnl0hMdBdD0xM+/M7UsBhdbyW5A3kPLjebyTc0dluUC/1Its4tPjbIO/KOIjRNYi j56dFQYtQ4/2TqZwdHf64pVcX2Fuss8dBRZQzNj/HmU9IIOWJwlzcCgJjf7AFdOBmhtk cktx0WiWKspNFKikSLv/u9z3l2t5ey+HeU8LWRWJjbF/y5qUkMW+7CYDnaAgLp+EpS8J 3zN9mi0edXy2nTld/NHkMW1eyDfYKhnrhBc0zsJERJbzTAiEknshtNwTKbQSvTOtXQIY mLRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=wtF/OaM7fp7U6S9sdFPIcvCBXBfwz64AlwC+cI5U4kw=; b=AOUZ3ikGqvudqvSgWQnnIj4F8CUyaXivnmObg4hzOdRO6DOapI5awI8R2moRHcQRmQ X0ss3XlACYb2vp5Nzmk+QJGiqe1raBUrQExFZ/eIjdoxx83lI2pbuUsX1+loPUFrIySI rqDch5ul1OetP9cruR+MX2LWMnJBbJiAssA7gikhj6vsIMi4k7GVEJZYVtAwF/3Trv9F 9pUMzKMxpHCTZKoAHMSPlOPvIai2T5E7sx4qdINVsJUiUlvIZokNI7mWx7VJkkfkb7LZ 8Rdr/zh1RBSgGWTa8DPX6FCcEqZz5Z+RkNiqPNkc9svQkO0v1w75tNQzKSHVlWKIiWeV qVnQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="Jt1Jl9/D"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a21si5728352jao.47.2021.09.13.07.21.02; Mon, 13 Sep 2021 07:21:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="Jt1Jl9/D"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344155AbhIMOTO (ORCPT + 99 others); Mon, 13 Sep 2021 10:19:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:33910 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344781AbhIMOOl (ORCPT ); Mon, 13 Sep 2021 10:14:41 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E386461407; Mon, 13 Sep 2021 13:43:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631540617; bh=4tF9IjJY9YncUcD7vJWy/zhfzoF/ywSY1A/tB1XiNLY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Jt1Jl9/DBbCt8/rUJRn0N8EpuOUiDK4D1FkX4qLG94MAcxNNj5JAoqKDVvO8ociiw C4GTqTIPOqeRmqI6ISZw3Wgh+HTBwM98XfqjGTv3s4uSAQbazCmGRh9ffLyeuonPMZ XQR2hOsr7yaIPLplyCnyDjOCNqytYJwnEhqAqpsI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , Yang Yingliang , "David S. Miller" , Sasha Levin Subject: [PATCH 5.13 233/300] octeontx2-pf: cn10k: Fix error return code in otx2_set_flowkey_cfg() Date: Mon, 13 Sep 2021 15:14:54 +0200 Message-Id: <20210913131117.232313829@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210913131109.253835823@linuxfoundation.org> References: <20210913131109.253835823@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yang Yingliang [ Upstream commit 5e8243e66b4d80eeaf9ed8cb0235ff133630a014 ] If otx2_mbox_get_rsp() fails, otx2_set_flowkey_cfg() need return an error code. Fixes: e7938365459f ("octeontx2-pf: Fix algorithm index in MCAM rules with RSS action") Reported-by: Hulk Robot Signed-off-by: Yang Yingliang Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c index 25f84ad50dba..e0d1af9e7770 100644 --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c @@ -286,8 +286,10 @@ int otx2_set_flowkey_cfg(struct otx2_nic *pfvf) rsp = (struct nix_rss_flowkey_cfg_rsp *) otx2_mbox_get_rsp(&pfvf->mbox.mbox, 0, &req->hdr); - if (IS_ERR(rsp)) + if (IS_ERR(rsp)) { + err = PTR_ERR(rsp); goto fail; + } pfvf->hw.flowkey_alg_idx = rsp->alg_idx; fail: -- 2.30.2