Received: by 2002:a05:6a10:6d25:0:0:0:0 with SMTP id gq37csp1875378pxb; Mon, 13 Sep 2021 07:21:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwIaUDrhyV7GRBce+G9jTcxs43nebi2zBOJkOsPSr4GB+4cvtSwKN5k7ffY5EdPbUwxqccZ X-Received: by 2002:a5e:df0d:: with SMTP id f13mr9384724ioq.108.1631542886072; Mon, 13 Sep 2021 07:21:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631542886; cv=none; d=google.com; s=arc-20160816; b=T5sDzgUcBfD5MLbiol5AYk38cCmx8MfOI46fZrGFo6+7m8EuihA70bknUHias15GJr NnEFRr9sYq+v9xL39tXtkcY0rNv8CyDJ8bmQIpwJpHU7fpQsecl9+88qGW4V/NY7yyAY 2AI1xta8kiRgt48tolCNMLbz6f7pUeXkeYKi5oDuFE3DXG4AHSk4J3DdW9/bm5cK+liK Yx9ozRRLXHA2G2fC61j9YgnB4IGvTjcxIlZRRphf6OTTgu9wf893QEJag/ELusuYqf9r koL4D1X3iKGhmbUthrYWCILEPMhQT3M9nBfjsk8j997lTZMoK/3u6rdx6FOUGiE2XgJV wuag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=qnoARcdc+TqshNGglkZyf6nFu3TIHNQV91Ad9Y2eAcA=; b=IriEjFsmlSjgPYa++5HVqtB8pXVu9D+GB6eErFvAmy7DcbEE0EEWrExqdrzqAwYUSM uhM4EePIeK9UXHsblah8Uuytu2xzIe41iFVpXAVBWJNJoqElkDrd5byRc6HjCIvFFOT/ qb0ywHLNdzsvyVtQepXDbXnLJHR6BdZMcekAy9p6NF/R+nG1kXzMN54tZFkr5eiqoHzS 8s3folL79kLTdPxynuscjw6ArGWe70cPksQOBooDbZHG8JPEQO5RjHgaEnxaWTW2JveV RRNCHMVzwyfYOpe2mZqtgjelblAG7r0gPxfq2wsajI2f2Gq3o9dRcjTHGcel6fGVws1c rYew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=WxJuVO3M; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k17si7461690iow.29.2021.09.13.07.21.08; Mon, 13 Sep 2021 07:21:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=WxJuVO3M; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244629AbhIMOU7 (ORCPT + 99 others); Mon, 13 Sep 2021 10:20:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:37134 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244635AbhIMORN (ORCPT ); Mon, 13 Sep 2021 10:17:13 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C365D61B20; Mon, 13 Sep 2021 13:45:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631540706; bh=ws5SJ3anQ+TeFQPoYg7MBVQZsaB4l3rY9Sgfs8htfBY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WxJuVO3MEv/F9UIofQ8ZZtxEYTGAcVkmbqoL/fOnCq6JjyD9z2Yb7/QolUck7fzro rAf3mDi7k5vgIlulicOlP67XffiKTSY7/qDXA/4F+QjWiVvBkK8jq1hAq7TPHZiA7J guwdVB5JVnEobdwXB6/w17r1Bhr59Qe+3EjIb+Nw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jens Axboe Subject: [PATCH 5.13 270/300] io_uring: IORING_OP_WRITE needs hash_reg_file set Date: Mon, 13 Sep 2021 15:15:31 +0200 Message-Id: <20210913131118.461240893@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210913131109.253835823@linuxfoundation.org> References: <20210913131109.253835823@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jens Axboe commit 7b3188e7ed54102a5dcc73d07727f41fb528f7c8 upstream. During some testing, it became evident that using IORING_OP_WRITE doesn't hash buffered writes like the other writes commands do. That's simply an oversight, and can cause performance regressions when doing buffered writes with this command. Correct that and add the flag, so that buffered writes are correctly hashed when using the non-iovec based write command. Cc: stable@vger.kernel.org Fixes: 3a6820f2bb8a ("io_uring: add non-vectored read/write commands") Signed-off-by: Jens Axboe Signed-off-by: Greg Kroah-Hartman --- fs/io_uring.c | 1 + 1 file changed, 1 insertion(+) --- a/fs/io_uring.c +++ b/fs/io_uring.c @@ -990,6 +990,7 @@ static const struct io_op_def io_op_defs }, [IORING_OP_WRITE] = { .needs_file = 1, + .hash_reg_file = 1, .unbound_nonreg_file = 1, .pollout = 1, .plug = 1,