Received: by 2002:a05:6a10:6d25:0:0:0:0 with SMTP id gq37csp1884464pxb; Mon, 13 Sep 2021 07:30:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwonEy3f/lnVTSq2PWHpXHkxgZ6nlO9tIss5v49lTpnaiubO4JoN6n9qVjsonc9tKWiWMsX X-Received: by 2002:a17:906:3a58:: with SMTP id a24mr12703071ejf.109.1631543458169; Mon, 13 Sep 2021 07:30:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631543458; cv=none; d=google.com; s=arc-20160816; b=fmKwO6/PWuh8TxAqEcDE+stSypBpS1FGa/Ph0rsVguk2w2BLWgaM7iwQWsA/Oq7NfA aOYvTEYobvvn7pY+jUYVNjrz4MslSVAM25puIsT18+ixbD0IHEgSu1u76XbJgdQ+cgOf sH1NM5FuBqMK134PAvKD1dhCefwvNa7507TguBtJHUn26O1EFvDdos5IOZVq4GSBxmBu xisRuPJpqGIMtN3rnYReDflbNzWK2wrZQLtimSsRcseRH5j3Eh84kFCK3Qz/fbD2LHQM zitWPuKVlmvRG62Q7ZTR8aCfGzRA9pRF3XH6kUh7qTCmibu5LT4ct9t9nL6F41jxLG6n Zs/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=z7d7LOpmLb2d9u4ZFlJt+QHcVdPKHbZyEoyvZ76pkSE=; b=J0Og5wh7QSyUeTtzDhyf6zuXBTMFBwend4TgFV5AkH8c42Mun/3oNn7bNK5hHzEN2e 1AQDEPCG70qxbQbyZvfXCWjyI77UDnUcburEc1aYQHc+F6c4VrvN1JZjfkFkjd7AkC3Z 8OiRbaSJiSQgQG4lmehr00AaMJ/Tntn1gzooIYEB/RZQi1THdwAS/UZ9Fd9sdxhApYf1 IJOz5aEGnMxtG8XJA+osj0ItSxLNduUVYjww9Tzvkuf5v5plfTA6YGSCpIM6hR/lcD8Q MCkQpzZLQj9Kg4XkG0+uzRSbnUq9nKJ8iBC/GQf+YI2SYo+83mkcxmWewVWYSdjGk9PO QX1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=16merzpG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 11si8479620eje.729.2021.09.13.07.30.33; Mon, 13 Sep 2021 07:30:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=16merzpG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344729AbhIMO2b (ORCPT + 99 others); Mon, 13 Sep 2021 10:28:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:41890 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245199AbhIMOW2 (ORCPT ); Mon, 13 Sep 2021 10:22:28 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C6F3161351; Mon, 13 Sep 2021 13:47:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631540855; bh=zc6OHHgdY1q0VOzMawMuRHooyQ8mTXK/lwqpqDfksyQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=16merzpGNkBZxPcsTSbwfWS+kS9kC1qturnyGcB224yLYpZnzEfr/yI6zjnbpWSHc 2VlrBiJSBHJlszvcjxmzd7uTXFTZtYq+3cznYQgOv10pWiBbzwFwrBkvibK6TdgbJw 66uu2DoSQVriOjnYmmcmi2knZIMDoJC97zICXhws= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Giovanni Cabiddu , Marco Chiappero , Fiona Trahe , Herbert Xu , Sasha Levin Subject: [PATCH 5.14 030/334] crypto: qat - do not ignore errors from enable_vf2pf_comms() Date: Mon, 13 Sep 2021 15:11:24 +0200 Message-Id: <20210913131114.432709715@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210913131113.390368911@linuxfoundation.org> References: <20210913131113.390368911@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Giovanni Cabiddu [ Upstream commit 5147f0906d50a9d26f2b8698cd06b5680e9867ff ] The function adf_dev_init() ignores the error code reported by enable_vf2pf_comms(). If the latter fails, e.g. the VF is not compatible with the pf, then the load of the VF driver progresses. This patch changes adf_dev_init() so that the error code from enable_vf2pf_comms() is returned to the caller. Signed-off-by: Giovanni Cabiddu Reviewed-by: Marco Chiappero Reviewed-by: Fiona Trahe Signed-off-by: Herbert Xu Signed-off-by: Sasha Levin --- drivers/crypto/qat/qat_common/adf_init.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/qat/qat_common/adf_init.c b/drivers/crypto/qat/qat_common/adf_init.c index 744c40351428..02864985dbb0 100644 --- a/drivers/crypto/qat/qat_common/adf_init.c +++ b/drivers/crypto/qat/qat_common/adf_init.c @@ -61,6 +61,7 @@ int adf_dev_init(struct adf_accel_dev *accel_dev) struct service_hndl *service; struct list_head *list_itr; struct adf_hw_device_data *hw_data = accel_dev->hw_device; + int ret; if (!hw_data) { dev_err(&GET_DEV(accel_dev), @@ -127,9 +128,9 @@ int adf_dev_init(struct adf_accel_dev *accel_dev) } hw_data->enable_error_correction(accel_dev); - hw_data->enable_vf2pf_comms(accel_dev); + ret = hw_data->enable_vf2pf_comms(accel_dev); - return 0; + return ret; } EXPORT_SYMBOL_GPL(adf_dev_init); -- 2.30.2