Received: by 2002:a05:6a10:6d25:0:0:0:0 with SMTP id gq37csp1885487pxb; Mon, 13 Sep 2021 07:31:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzwuISj699wbA/2Ch/dub53fmyV4dMitlm9UwrL2vmbrp8eCmM1hTVwEX+9ZpSlSxnBo4OM X-Received: by 2002:a02:90d0:: with SMTP id c16mr10192623jag.106.1631543510492; Mon, 13 Sep 2021 07:31:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631543510; cv=none; d=google.com; s=arc-20160816; b=egZFuaFq+w8GAu+h2doj8UNNftutKVyo7Wzh8N4wqj8S60BuW6Y+W77adoi2Nv/R+i mXF/tF8JLsML1MlSdmzEZG6FjpyUDH8ix0AkQenpy99vccuFAZtqdOTfzC+oFfDOglA0 BSuNq5MsQLJhRmWwUmdKEWSyL6zAkVuLm86+ZFw75ZGsXKNo1Y5E7sbcRtDq3DisxEcc gweXlpKe3TMC6UX68tSe6rn3pK0ZcB9COVm3fuxfW7jnHsS/1FPMeS/G1KMdcyx9/6QX UHmEBikCxyCjwvsAn3iaBapgPZRHUD4EXC3zFc7CQkBLSdwLmo1WBxdpgMI+jMrI8r1i +56w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=MkkoIsBQeYQhat6x34WXloQf5IpFLGQtaeq5KcZjvos=; b=lPk2Po5M4NiAomivKefTx/xG6eaj/2kNxO+Lxn5eRZT5rHJIFWv3i+3d04xxyp0bqp uYhvaP/BqXJOoTzyGcTEo5qS5fyJsVLcwdruFlaZ9M58hK/N93TBvfksDSzf0RZPSl+n Mc5QOC6yhu9dA6CC7G4KlX5mlcERVgkACBKHwGA+rgvb05/UeQx+ofmsgNyWg8Bw3qZp H4znnLG2iPkXXEIG0VKZ7hbzZEEwFYulnJ9MxKbH702XJvOoL+SaY2JE7E61kNtdubD/ N4BciEfZ8aTZYACFnwlDCqvZQK3UMBFv25TThBE/OwqiPZFMnYSicDoFwH8p0l+j0suh BoIw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=yPp2O9pY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d8si7083989ila.45.2021.09.13.07.31.38; Mon, 13 Sep 2021 07:31:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=yPp2O9pY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346953AbhIMO37 (ORCPT + 99 others); Mon, 13 Sep 2021 10:29:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:47500 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241200AbhIMOZX (ORCPT ); Mon, 13 Sep 2021 10:25:23 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id EFCC161B48; Mon, 13 Sep 2021 13:48:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631540931; bh=lVDVoa1sP9R2MLoIob+fd5qtkGB87avFrZ2575JGRtQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=yPp2O9pYuN1wFsLVBnAamSh1I9PgKqun/2+qyqH3QinT1R6ZkEET9amjH/jiNit9U zM1Bp4Gvib8Pxlk3XP3oH3aUi83XO9xG4CnuJ2blxpUXa39nj1G6DzDRmfSXFX2a2s mXL7fo+8QRM7j2Uq+a/sRmVXxv2MWkp5K29wUd+k= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Julia Lawall , Daniel Vetter , Sasha Levin Subject: [PATCH 5.14 092/334] drm/of: free the right object Date: Mon, 13 Sep 2021 15:12:26 +0200 Message-Id: <20210913131116.494403307@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210913131113.390368911@linuxfoundation.org> References: <20210913131113.390368911@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Julia Lawall [ Upstream commit b557a5f8da5798d27370ed6b73e673aae33efd55 ] There is no need to free a NULL value. Instead, free the object that is leaking due to the iterator. The semantic patch that finds this problem is as follows: // @@ expression x,e; identifier f; @@ x = f(...); if (x == NULL) { ... when any when != x = e * of_node_put(x); ... } // Fixes: 6529007522de ("drm: of: Add drm_of_lvds_get_dual_link_pixel_order") Signed-off-by: Julia Lawall Signed-off-by: Daniel Vetter Link: https://patchwork.freedesktop.org/patch/msgid/20210709200717.3676376-1-Julia.Lawall@inria.fr Signed-off-by: Sasha Levin --- drivers/gpu/drm/drm_of.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c index ca04c34e8251..197c57477344 100644 --- a/drivers/gpu/drm/drm_of.c +++ b/drivers/gpu/drm/drm_of.c @@ -315,7 +315,7 @@ static int drm_of_lvds_get_remote_pixels_type( remote_port = of_graph_get_remote_port(endpoint); if (!remote_port) { - of_node_put(remote_port); + of_node_put(endpoint); return -EPIPE; } -- 2.30.2