Received: by 2002:a05:6a10:6d25:0:0:0:0 with SMTP id gq37csp1894339pxb; Mon, 13 Sep 2021 07:41:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyY6onuV2b1gdcluBGYTY+XivVhnByWbcyYC1cI9vszjoQxrZhCp1uAEyvvYuifFO4nfatq X-Received: by 2002:a50:eacb:: with SMTP id u11mr13431185edp.209.1631544072458; Mon, 13 Sep 2021 07:41:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631544072; cv=none; d=google.com; s=arc-20160816; b=Gce7scBoQFRQ1PH0gqei1l7PT7p1XgbVYtOZxB35cFK/SHlCnT96IhoS6PGGxJjix+ Yy3st2jy6yrwcATG1tn7zviUX/yo24zwtrl9wz/+QKDlEdfpiMODYPUMErmsTRjVjCZC c0xNlG3kCt5obPcvzJ+j7pYF2VJP+pGUlyo2S89lc+EoqBEJfut6YN4WfvRc/quIE4Fd 2+zrrkfCKj4JBJ1VGQSBTmsqY+le2RySIOyIt5Se45AnX7K5MCvAEj+V9KbB/K10Tbev bZT2QTxaHUw4GtojBXuszdWqzZPUuQ22k+qKipjhcwneQp5CWi2ExcCfQ4lO5GU1BIBy pkIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=JSAsLfaKdq7rTkSMuzZ5W7R0LFhGmSNB+uejKHAmz6c=; b=VIaptWSUgzjvxb1e/qkwRUJDjE8S545N4EZwtFxGAqC8RQhmFAj0S4GBdTmcgo3eb1 jpsaie4KexEoPJzpJ2Hp92hSyCyTzjkDKSxYyqrD1cglUJr2Q7SFaShPNRHWIRU+WsOX hL/2oGdYp3vM7zk4R7yYQw37SrMpsVtdQRRdPC5JPcxANvlHlWVWgHnXq37XXPamz3Z4 yrzrKdDRslDEl4j9HIge0/mEugAUK1whw7uRk5+aV4ww8YAwQQTvE7Hu50kWJoeXzatU qYM0XOjQpP2df2ydwDMCZX+rfAtXX5gsRb64NhUae2PwMwNemuyN3PBKd0tt8Tgb2TMa DA4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=LCxok4uF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z15si7937991ejr.28.2021.09.13.07.40.44; Mon, 13 Sep 2021 07:41:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=LCxok4uF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345458AbhIMOiy (ORCPT + 99 others); Mon, 13 Sep 2021 10:38:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:51890 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347481AbhIMOed (ORCPT ); Mon, 13 Sep 2021 10:34:33 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5893261BBE; Mon, 13 Sep 2021 13:52:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631541179; bh=05UkK0ig2uvtmKKXkG6BBmNtU1LU6hu1Oy8xHBzwNqI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LCxok4uFqYmw8OrGDegtTtlBexuxY5OsbmSQNWgqsSfvwAZGX8y4daEa0R7xPQkER 3dtnZG9EOJmR+vBVRhmYRfUDn+3VLB11yHuGEln1A3Irk5Jf9GLTGbvCmOi/FAQwd6 emP4BiUR86GOOl2mHN7p0NJdlwcFHdkeT697AWu0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Kuogee Hsieh , Stephen Boyd , Rob Clark , Sasha Levin Subject: [PATCH 5.14 195/334] drm/msm/dp: replug event is converted into an unplug followed by an plug events Date: Mon, 13 Sep 2021 15:14:09 +0200 Message-Id: <20210913131119.977252231@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210913131113.390368911@linuxfoundation.org> References: <20210913131113.390368911@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kuogee Hsieh [ Upstream commit 7e10bf427850f2d7133fd091999abd5fc1755cdb ] Remove special handling of replug interrupt and instead treat replug event as a sequential unplug followed by a plugin event. This is needed to meet the requirements of DP Link Layer CTS test case 4.2.1.3. Changes in V2: -- add fixes statement Changes in V3: -- delete EV_HPD_REPLUG_INT Fixes: f21c8a276c2d ("drm/msm/dp: handle irq_hpd with sink_count = 0 correctly") Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen Boyd Link: https://lore.kernel.org/r/1628196295-7382-5-git-send-email-khsieh@codeaurora.org Signed-off-by: Rob Clark Signed-off-by: Sasha Levin --- drivers/gpu/drm/msm/dp/dp_display.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index 8aca93309c1c..997fd67f7379 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -55,7 +55,6 @@ enum { EV_HPD_INIT_SETUP, EV_HPD_PLUG_INT, EV_IRQ_HPD_INT, - EV_HPD_REPLUG_INT, EV_HPD_UNPLUG_INT, EV_USER_NOTIFICATION, EV_CONNECT_PENDING_TIMEOUT, @@ -1119,9 +1118,6 @@ static int hpd_event_thread(void *data) case EV_IRQ_HPD_INT: dp_irq_hpd_handle(dp_priv, todo->data); break; - case EV_HPD_REPLUG_INT: - /* do nothing */ - break; case EV_USER_NOTIFICATION: dp_display_send_hpd_notification(dp_priv, todo->data); @@ -1165,10 +1161,8 @@ static irqreturn_t dp_display_irq_handler(int irq, void *dev_id) if (hpd_isr_status & 0x0F) { /* hpd related interrupts */ - if (hpd_isr_status & DP_DP_HPD_PLUG_INT_MASK || - hpd_isr_status & DP_DP_HPD_REPLUG_INT_MASK) { + if (hpd_isr_status & DP_DP_HPD_PLUG_INT_MASK) dp_add_event(dp, EV_HPD_PLUG_INT, 0, 0); - } if (hpd_isr_status & DP_DP_IRQ_HPD_INT_MASK) { /* stop sentinel connect pending checking */ @@ -1176,8 +1170,10 @@ static irqreturn_t dp_display_irq_handler(int irq, void *dev_id) dp_add_event(dp, EV_IRQ_HPD_INT, 0, 0); } - if (hpd_isr_status & DP_DP_HPD_REPLUG_INT_MASK) - dp_add_event(dp, EV_HPD_REPLUG_INT, 0, 0); + if (hpd_isr_status & DP_DP_HPD_REPLUG_INT_MASK) { + dp_add_event(dp, EV_HPD_UNPLUG_INT, 0, 0); + dp_add_event(dp, EV_HPD_PLUG_INT, 0, 3); + } if (hpd_isr_status & DP_DP_HPD_UNPLUG_INT_MASK) dp_add_event(dp, EV_HPD_UNPLUG_INT, 0, 0); -- 2.30.2