Received: by 2002:a05:6a10:6d25:0:0:0:0 with SMTP id gq37csp1902869pxb; Mon, 13 Sep 2021 07:51:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyxoJXHiAOt2atr9vQubAKL24WQpDZltdfwbtpPYl4F73F5+AloUk7wTkh41EqUC22ft1Az X-Received: by 2002:a05:6602:2e0c:: with SMTP id o12mr5050694iow.59.1631544692418; Mon, 13 Sep 2021 07:51:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631544692; cv=none; d=google.com; s=arc-20160816; b=hGKB/W9LfYm//kPsmJykOD0lQCRLYjuo9y/e8fYk213731AnUVugePW5/D4+20HyFD N43ucWY26DDaqU9bm1A10GvG/VvFJ0qqU8zdQ4CYO1OWeHgEliWOgQfQCOAUvaSOh7yF JP7ciA4x5bZkEg9H6NmHmiuefy2c5P7l8E13A5R4IZtqrC8idazS6ND/hHSHDx56CQYp 8jObIpywTxjdz5+L0iDAOMUJglCamMULgmXhsW9h/utYLcMeEBVQK710l+GyCY4/DgXI kK09psPYZjcfyjH34ziuUc092o2DhV+5CVDQyIRykGtncbdWRjIrxMC1Sy1vxfOHd1jK nwZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Wg1zj+TQ9zvoQmbS8c0ALthNOMy/E6d7hEr2y+Mijo8=; b=Cp9ujBOnHTEK+Dw24gZnSkmi6gvxJ1qsT1nJSaCLSHiHWSJcjjfXt71vc8LASlFwBR KxJDoJl3Epu5uC1PicB5l/m0v2ehijEpbtIplGjF4NsvNn20vtr6nqKTq1hdhCBtA69y xiU25gs5t695TNC0KxzGATOLpaf1LVNJjR/fgvLoyozDSrUh44wWr/NVlr4lJlZMwwe1 rnWt4ACbVjl8jGpD2g2uVF2bsHiYQ0dE5tnlmkcXpXFvyxjdQCtLyBNIKFuHFF7WsaS8 tFOYQWpbry4ZhyCJ5Ujh+Yukr7DG23YlZvp37bURA4z1g8+SOoPCOUYaUWI9nzRStTrU lw2Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="WY7TXF/B"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y28si6736648iot.48.2021.09.13.07.51.20; Mon, 13 Sep 2021 07:51:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="WY7TXF/B"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347348AbhIMOtQ (ORCPT + 99 others); Mon, 13 Sep 2021 10:49:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:58816 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347640AbhIMOoY (ORCPT ); Mon, 13 Sep 2021 10:44:24 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 73CEF61252; Mon, 13 Sep 2021 13:57:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631541456; bh=ltTlM8kQwC23/C31xh8uLeBVKUew/GJt+6ftzXrcJLg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WY7TXF/Bf9HyYnqEKSESSwJonrZPl+96kGGMyktdRisIoxVCAJSo7ze0Ur2SEuady l8AkWoZ3TsGmznDd7yArsdJsDCwBbJxEwSPWjuPXfzwkpFJecvVsRYOUzfmVogaRKf J+qgltIHXSK7O80QBtZ2y6jvJnnqxqXQGrYm6l8I= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Pavel Begunkov , Jens Axboe Subject: [PATCH 5.14 303/334] io_uring: fail links of cancelled timeouts Date: Mon, 13 Sep 2021 15:15:57 +0200 Message-Id: <20210913131123.665211460@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210913131113.390368911@linuxfoundation.org> References: <20210913131113.390368911@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pavel Begunkov commit 2ae2eb9dde18979b40629dd413b9adbd6c894cdf upstream. When we cancel a timeout we should mark it with REQ_F_FAIL, so linked requests are cancelled as well, but not queued for further execution. Cc: stable@vger.kernel.org Signed-off-by: Pavel Begunkov Link: https://lore.kernel.org/r/fff625b44eeced3a5cae79f60e6acf3fbdf8f990.1631192135.git.asml.silence@gmail.com Signed-off-by: Jens Axboe Signed-off-by: Greg Kroah-Hartman --- fs/io_uring.c | 2 ++ 1 file changed, 2 insertions(+) --- a/fs/io_uring.c +++ b/fs/io_uring.c @@ -1329,6 +1329,8 @@ static void io_kill_timeout(struct io_ki struct io_timeout_data *io = req->async_data; if (hrtimer_try_to_cancel(&io->timer) != -1) { + if (status) + req_set_fail(req); atomic_set(&req->ctx->cq_timeouts, atomic_read(&req->ctx->cq_timeouts) + 1); list_del_init(&req->timeout.list);