Received: by 2002:a05:6a10:6d25:0:0:0:0 with SMTP id gq37csp1902915pxb; Mon, 13 Sep 2021 07:51:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxQ56wST4WOu7iUi+bCCzR65J0LqnbggItKgHPNeByPjWX87pvlJrc2S9+R7YMz1G/V8ogE X-Received: by 2002:a17:906:8450:: with SMTP id e16mr13203212ejy.305.1631544696167; Mon, 13 Sep 2021 07:51:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631544696; cv=none; d=google.com; s=arc-20160816; b=iBl/pLszAeZDNIVLsVwmrqyLgvaPQhh4oBExSBGUopzsbUxtYeH64CvbqSu+s878Io wMosfmGSXavUu3r1HfyvGPZmk/XKVUYqGwgZBhgwDDK4UA1WLjsBw0JzwSpUMtOFSCe2 sCd0hhwNy5MVIfYvsyXExalBvznosCyVxRfSoC4q4X0tY9a4IY6O7GWntpog+alhWLrZ pCP1llVdIS+sRF/huaQ2G10P61YwJXrZh9KMmTlrX0MnsEfEUEXLo5lXAuhaL5wvtm/0 NoVLKIbiiOA+F5keJK0pcw+fTvjYjLfyGXmcnX62la5kxFZC1GeS9fR0/6AS9JDAmjE+ YK6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=neTIy/ocRfWwybCJjMMgnSxvKJgwv/Cz6pwUx7jQP58=; b=KYj5SXOpDCJi/K23z7CBu7wMTUHFBWpisvfj8UtRhubETR4CQlAa7qJI6/LbkFwti6 49SJhiFRIPtkMfwk5w0+jyE3MbLvSUN9QCIGcDPPEv18Vn/5XIY+AOaQb6j/5b6iF/4U ZeYQKDUOSYWpXUOZGdIYjQI961QybNQ8rghQgNUT0fyZZsvBUOwpV5phgZGU6vZCNj68 dhpwLeTz/Fs9OfUGJ/ICpBRWTTI9ENMVVy+2FZfMjkRbqndNa9vcRpht7dTUQiywLVme 7iY9LdssG02ti4Zaq7r8LalDQ64Rl1TzRfiOCUxtIMdlNfUVjdBlBnaQFaaR5NOUDG83 9iIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=F1GmrfTu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n12si6217647edx.124.2021.09.13.07.51.11; Mon, 13 Sep 2021 07:51:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=F1GmrfTu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347958AbhIMOuA (ORCPT + 99 others); Mon, 13 Sep 2021 10:50:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:58910 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347929AbhIMOof (ORCPT ); Mon, 13 Sep 2021 10:44:35 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 656FF63221; Mon, 13 Sep 2021 13:57:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631541478; bh=PXziJmtkl+XFcSM8POICp1CVLjPKdzoifA5qF9uW2m4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=F1GmrfTuqYvP++Fz8kaU54Vi9yTt52L1sOa63iCjxtmZdLLeFqDeFjBZvUTgYS+Ai YsIb72PcnmzWiTMdZtBdezMgvJysAXAL5DAe7e+mebySboYUXW0lThEN7KbRvUyo42 9D511tZMoQO1IoSIIk2eSIxq8O2n0whOsP490bd8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dmytro Linkin , Roi Dayan , Saeed Mahameed , Sasha Levin Subject: [PATCH 5.14 272/334] net/mlx5e: Use correct eswitch for stack devices with lag Date: Mon, 13 Sep 2021 15:15:26 +0200 Message-Id: <20210913131122.614610595@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210913131113.390368911@linuxfoundation.org> References: <20210913131113.390368911@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dmytro Linkin [ Upstream commit f9d196bd632b8b79261ec3366c30ec3923ea9a02 ] If link aggregation is used within stack devices driver rejects encap rules if PF of the VF tunnel device is down. This happens because route resolved for other PF and its eswitch instance is used to determine correct vport. To fix that use devcom feature to retrieve other eswitch instance if failed to find vport for the 1st eswitch and LAG is active. Fixes: 10742efc20a4 ("net/mlx5e: VF tunnel TX traffic offloading") Signed-off-by: Dmytro Linkin Reviewed-by: Roi Dayan Signed-off-by: Saeed Mahameed Signed-off-by: Sasha Levin --- .../net/ethernet/mellanox/mlx5/core/en_tc.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c index d273758255c3..6eba574c5a36 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c @@ -1338,6 +1338,7 @@ bool mlx5e_tc_is_vf_tunnel(struct net_device *out_dev, struct net_device *route_ int mlx5e_tc_query_route_vport(struct net_device *out_dev, struct net_device *route_dev, u16 *vport) { struct mlx5e_priv *out_priv, *route_priv; + struct mlx5_devcom *devcom = NULL; struct mlx5_core_dev *route_mdev; struct mlx5_eswitch *esw; u16 vhca_id; @@ -1349,7 +1350,24 @@ int mlx5e_tc_query_route_vport(struct net_device *out_dev, struct net_device *ro route_mdev = route_priv->mdev; vhca_id = MLX5_CAP_GEN(route_mdev, vhca_id); + if (mlx5_lag_is_active(out_priv->mdev)) { + /* In lag case we may get devices from different eswitch instances. + * If we failed to get vport num, it means, mostly, that we on the wrong + * eswitch. + */ + err = mlx5_eswitch_vhca_id_to_vport(esw, vhca_id, vport); + if (err != -ENOENT) + return err; + + devcom = out_priv->mdev->priv.devcom; + esw = mlx5_devcom_get_peer_data(devcom, MLX5_DEVCOM_ESW_OFFLOADS); + if (!esw) + return -ENODEV; + } + err = mlx5_eswitch_vhca_id_to_vport(esw, vhca_id, vport); + if (devcom) + mlx5_devcom_release_peer_data(devcom, MLX5_DEVCOM_ESW_OFFLOADS); return err; } -- 2.30.2