Received: by 2002:a05:6a10:6d25:0:0:0:0 with SMTP id gq37csp1903137pxb; Mon, 13 Sep 2021 07:51:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxFJEEjY6nb3zHBXXv/7JMZ+JQh5shYsxfoc3cTscrzQs4OjLJkcLarEY3tkPN20bd5ZqBf X-Received: by 2002:a17:906:a08d:: with SMTP id q13mr13042500ejy.465.1631544712958; Mon, 13 Sep 2021 07:51:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631544712; cv=none; d=google.com; s=arc-20160816; b=ggSFLuiolYOu+lfblm3+ZUg4A3ZsJfTJTh4JcPGtq4NKW/O25RTKEXjbccOXDejnzM Wgdc+rDkNh+X6n418NFkfCEprGXjKBTWtEmwQNaGs94F+1Ry7/hdWKQYKZRF3JPj4jDD SyUCvvXIdiS2/1H35y7tKrhBcsvHe8OUFJ/kYEQzSUeeZViX4XGkm8+/CQDhTpm8DtnA qiqDOICiugSzScsrCjwh6omFVwTQuUPh+LYHNPhrBW05glDiBNkrzSil+9Eme3LSVw9o SCk4RpvYozRio+X53e5l+YV4mSaZQXG5Tlynrv2vIAeWrQMJFjwFEsEEfXhRNXGWE7dq NyqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=SbmzYMKEyXH7lT/6CdH3GFG+i05ggd5OQbVFnrgRZtA=; b=KD2Kp/soE76cF6kQh08jxYQF5ZVWKexo97UdJiaJG4E4A2664uKresQJI5dfCInm53 IVoIRcdrr/u2j39ZI9aNXAvHi8sSjeonyhjzJ65ZKpT8HQ2UmYuoAS0JsM3zcKLctBuZ UAfftLQdFYXPdAzMsxJxyMksWi5BiUAF6fE6dTqqY54rCVGjAX+Zvqjpr5qt/TlWU69O /jsFKAjDSSOIe386tnXa9ZQGs0pBj/Z9WL1CbrzTpHxVVkZgKQgIU1qux/Bulx8J52cH 5zDlXz+Eb/SGMtv31iT725HpVOhKxYNZE+j7hgsMssooK/Byq1xfRDmCJPG3nuP0HSI1 OiKQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=IOWXqd1Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h14si7379196ejl.480.2021.09.13.07.51.27; Mon, 13 Sep 2021 07:51:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=IOWXqd1Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348012AbhIMOuB (ORCPT + 99 others); Mon, 13 Sep 2021 10:50:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:60784 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347914AbhIMOof (ORCPT ); Mon, 13 Sep 2021 10:44:35 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 110A463222; Mon, 13 Sep 2021 13:57:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631541476; bh=XF0uZ/NJuhtO93oLxSrCmNBUZFUFZrktfskP+lMO9hw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IOWXqd1Q5vEbfzEoTNnMEFT6mjXO0YNtpqUQtKE2t7P6bH5iznD4fsLDXRA4AYm+n xv45F+j3Y3+k7wmkMxrILViNJQUP8V/WpykKbhon0mrwdg5DY6GeGb00fgGV6BCKPU OLVrIiFaz1ub8YLA+nfvBRD4szJx3a4RrQyu/bWM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sudarsana Reddy Kalluru , Igor Russkikh , "David S. Miller" , Sasha Levin Subject: [PATCH 5.14 281/334] atlantic: Fix driver resume flow. Date: Mon, 13 Sep 2021 15:15:35 +0200 Message-Id: <20210913131122.930027092@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210913131113.390368911@linuxfoundation.org> References: <20210913131113.390368911@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sudarsana Reddy Kalluru [ Upstream commit 57f780f1c43362b86fd23d20bd940e2468237716 ] Driver crashes when restoring from the Hibernate. In the resume flow, driver need to clean up the older nic/vec objects and re-initialize them. Fixes: 8aaa112a57c1d ("net: atlantic: refactoring pm logic") Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Igor Russkikh Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c b/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c index 59253846e885..f26d03735619 100644 --- a/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c +++ b/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c @@ -417,6 +417,9 @@ static int atl_resume_common(struct device *dev, bool deep) pci_restore_state(pdev); if (deep) { + /* Reinitialize Nic/Vecs objects */ + aq_nic_deinit(nic, !nic->aq_hw->aq_nic_cfg->wol); + ret = aq_nic_init(nic); if (ret) goto err_exit; -- 2.30.2