Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 13 Sep 2021 15:32:21 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Iskren Chernev <iskren.chernev@gmail.com>
Cc:     Bjorn Andersson <bjorn.andersson@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
        phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [RFC PATCH 2/2] regulator: qcom_smd: Add PM6125 regulator support
Message-ID: <20210913143221.GG4283@sirena.org.uk>
References: <20210828115654.647548-1-iskren.chernev@gmail.com>
 <20210828115654.647548-3-iskren.chernev@gmail.com>
 <20210903152331.GK4932@sirena.org.uk>
 <b02e3ba5-b3fe-8963-8457-62304a39e100@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="iAL9S67WQOXgEPD9"
Content-Disposition: inline
In-Reply-To: <b02e3ba5-b3fe-8963-8457-62304a39e100@gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--iAL9S67WQOXgEPD9
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Sep 03, 2021 at 10:49:52PM +0300, Iskren Chernev wrote:
> On 9/3/21 6:23 PM, Mark Brown wrote:
> > On Sat, Aug 28, 2021 at 02:56:54PM +0300, Iskren Chernev wrote:

> >> NOTE: The sources haven't been determined, so currently each regulator
> >> has it's own source.

> > It would probably be safer to just leave them unspecified for now and
> > then add them as people figure out what's going on rather than putting
> > something incorrect into the DT bindings.

> I didn't expect this patch to be mergeable, so I didn't add the dt-bindings.

If you skip out on basic smell tests like having DT bindings that's
going to inhibit the amount of review you get, once things obviously
aren't going to be merged review tends to get a lot more high level.

> So should I add bindings and just ignore all the sources (add them later)?

Yes.

--iAL9S67WQOXgEPD9
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmE/YPQACgkQJNaLcl1U
h9DfmQf+LEQSFvSlXylnotKOPeYGqgofaL3EbkdZDLOzCJ8i1NXog9E0ADq4it5V
to8oYtTXoa2/d+GA5N0UvFnU+GPZNf3/Z6HMmdeyB+Qxgz7vX0pKVZ9qVetqCkYJ
L+UR9tWU0TudQ7vSOMuSeXJ2mvL0bmuayULj+gERN3EmCKl1yVeAchGI/5vLG2aD
wScIW3UXSktks3zx6k1frFDWTZTDifSDO1V0lWgxbTejWwt2Ya70AmRsDIeONf7b
1xFJA3C4Fx3HqavE4R10/e7J42FUsAV90JSlFyuuF5JMRwGMjzlHv68ZiaCJ/Uh7
I+tkyJ4mcXUjFmrQgrG4F3lW56zaGg==
=UcBp
-----END PGP SIGNATURE-----

--iAL9S67WQOXgEPD9--