Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Himanshu Madhani <himanshu.madhani@oracle.com>
To:     Li Feng <fengli@smartx.com>
CC:     Martin Petersen <martin.petersen@oracle.com>,
        "open list:SCSI TARGET SUBSYSTEM" <linux-scsi@vger.kernel.org>,
        "open list:SCSI TARGET SUBSYSTEM" <target-devel@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scsi: target: Remove unused argument of some functions
Thread-Topic: [PATCH] scsi: target: Remove unused argument of some functions
Thread-Index: AQHXqHm1T22SJlgZ4UujJ/ItcGPz8quiDjmA
Date:   Mon, 13 Sep 2021 14:56:54 +0000
Message-ID: <A621E579-9D72-4C26-9F40-BB132CCD5A90@oracle.com>
References: <20210913083045.3670648-1-fengli@smartx.com>
In-Reply-To: <20210913083045.3670648-1-fengli@smartx.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9pw6YTGPeDV1dMaihhpyaP8/JpOh7OLuoNZ9Pdq/2Nw73PuPjUiiNI9WAa/F?=
 =?us-ascii?Q?QfZfv5amtSG6JIYXa4EDB4c2Ha6CnkcWi7wek5eNgW7rY2iYH5wP4fCdWTJ1?=
 =?us-ascii?Q?yEoOlI+m4q5/cQ52ecg9PrUAa/tcWziqa6fYlUDTr1zBmhTRuTK0ORDxPuLd?=
 =?us-ascii?Q?HRGj5caLEhmKu9DSFoayuMs5qhPIjnGP2wsyzHMFjrZ2jWK8tMrTgth5QqBA?=
 =?us-ascii?Q?bWpgRT+yyIuIA/5siIUdcG6CgZuYJsSWaB+NbLahnGaoyxGH1NV4LF/JP5Ha?=
 =?us-ascii?Q?AAmw0POdOLE8j0wuq8MUUAEMWLs1Fawyo2QjP89BEqhAGvlw5swaq3jvkUfB?=
 =?us-ascii?Q?rzNWodDIWNGW4iTEKK7fxQhpwYGzCtl1ZimNlpQf+uiOJpLoGSa1//DXAXEQ?=
 =?us-ascii?Q?9yKBML/YEiD9HSdl8G7hwH2vlyPlDfSbi6+2uTkuU8TbT1k1j4D39hWaEK2x?=
 =?us-ascii?Q?diFRrO/Wv7gBBhXjRM028FWCgCOrgfMVtT5Qb5P4sb1DJfgpDQ13Zi8MFXZf?=
 =?us-ascii?Q?SmBOELr5qStD4PHjuaygfmtGH6IbF6X03OsIyX9o5aMjE88Ih9NNGKUIeI8j?=
 =?us-ascii?Q?6D48SRnapHLjO7h9+VV63cdw6LXTLvWsiBchYM/TEzBwFAg6+mAPiuSazSdv?=
 =?us-ascii?Q?oJWP8a/fB7xECJI3qshNY8Jx04LC8nJixVcVdSFqEwklQcvGuFvJCznftmoV?=
 =?us-ascii?Q?Upwttyl7uDeoTGAFPf2xavyhuVmRDNXGsAC+xDx9FEyLcYS6rJT1M7lyRAlV?=
 =?us-ascii?Q?MmO45ELZwZCSEF1oRnpBkqGRkoCBpv5pimgbUQzAeMeya4f6KBGu0Q5cFJzZ?=
 =?us-ascii?Q?zVe1QALgUuT5nQtbvjXTIfN40+MzIgHyCCC6pQNjRvEhc2v4rCbvKbiV6gva?=
 =?us-ascii?Q?nYoLJyVwYRNG977elw80lhAq6UO8tUW3nYyglBNJ/Y5QcVRHuYz9K2+Q1aCp?=
 =?us-ascii?Q?9lTUO4S+Cm9CBAc1mbO8bF86mzfGvS3hjITWDCkKUITnyN4pIwZyGnVzkzeT?=
 =?us-ascii?Q?49Ib/2+MRTicJhoQZ9R+LZ6Std7BuuVchtbaDTe3cPG/o5shFxa5SIp51/0k?=
 =?us-ascii?Q?UuyfIm07SjlcwG7VTNQtF2dg2dPf8B3nxnQ0Q5mT85yvTJB8MHJe9nprkcJD?=
 =?us-ascii?Q?OZ4AtYHVR/JQMRJZdxswFOOBuugSK2GfJS/fQ+X0BzL/fJ1J1GgkHrvugqnM?=
 =?us-ascii?Q?I95RaNMAmC/T5TwClQ1r1VyZuuyNw+tob3mox/PnfhGWr6BnyP5OQJ0jp477?=
 =?us-ascii?Q?aXw/ohC6TW8pwL+EeSWFKUvML/rd9HMKdW9qDrSTOua53Ktkyl90u1Nx1CdE?=
 =?us-ascii?Q?1YKR8z9fpjadHXSF+M1sU4rn8UxUr49iFHTcjianVG8kGw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1ABD278BE3566747AFC48D1964CF7AAE@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BL0PR10MB2932.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 78b8a672-d91f-43d7-208e-08d976c6b9d5
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Sep 2021 14:56:54.1571
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: fBtalyEdMPoUU/qC1PIX4hPvRG4R7m+JXhpsDz+2LaUfwbUy/whlE2nbMvKQ3qsY+xy4MFsEzhgeLki/DnPYHH+9hTt0Wy4LBpY1J85Btpo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4096
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10105 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 malwarescore=0
 adultscore=0 mlxscore=0 mlxlogscore=999 suspectscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109030001
 definitions=main-2109130099
X-Proofpoint-ORIG-GUID: i6gXFZsgwUaFxK5abRL90Vg6cUCmL57Q
X-Proofpoint-GUID: i6gXFZsgwUaFxK5abRL90Vg6cUCmL57Q
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Sep 13, 2021, at 3:30 AM, Li Feng <fengli@smartx.com> wrote:
>=20
> The se_cmd is unused in these functions, just remove it.
> Signed-off-by: Li Feng <fengli@smartx.com>
> ---
> drivers/target/target_core_xcopy.c | 14 ++++++--------
> 1 file changed, 6 insertions(+), 8 deletions(-)
>=20
> diff --git a/drivers/target/target_core_xcopy.c b/drivers/target/target_c=
ore_xcopy.c
> index d4fe7cb2bd00..6bb20aa9c5bc 100644
> --- a/drivers/target/target_core_xcopy.c
> +++ b/drivers/target/target_core_xcopy.c
> @@ -295,8 +295,7 @@ static int target_xcopy_parse_target_descriptors(stru=
ct se_cmd *se_cmd,
> 	return -EINVAL;
> }
>=20
> -static int target_xcopy_parse_segdesc_02(struct se_cmd *se_cmd, struct x=
copy_op *xop,
> -					unsigned char *p)
> +static int target_xcopy_parse_segdesc_02(struct xcopy_op *xop, unsigned =
char *p)
> {
> 	unsigned char *desc =3D p;
> 	int dc =3D (desc[1] & 0x02);
> @@ -332,9 +331,9 @@ static int target_xcopy_parse_segdesc_02(struct se_cm=
d *se_cmd, struct xcopy_op
> 	return 0;
> }
>=20
> -static int target_xcopy_parse_segment_descriptors(struct se_cmd *se_cmd,
> -				struct xcopy_op *xop, unsigned char *p,
> -				unsigned int sdll, sense_reason_t *sense_ret)
> +static int target_xcopy_parse_segment_descriptors(struct xcopy_op *xop,
> +				unsigned char *p, unsigned int sdll,
> +				sense_reason_t *sense_ret)
> {
> 	unsigned char *desc =3D p;
> 	unsigned int start =3D 0;
> @@ -362,7 +361,7 @@ static int target_xcopy_parse_segment_descriptors(str=
uct se_cmd *se_cmd,
> 		 */
> 		switch (desc[0]) {
> 		case 0x02:
> -			rc =3D target_xcopy_parse_segdesc_02(se_cmd, xop, desc);
> +			rc =3D target_xcopy_parse_segdesc_02(xop, desc);
> 			if (rc < 0)
> 				goto out;
>=20
> @@ -840,8 +839,7 @@ static sense_reason_t target_parse_xcopy_cmd(struct x=
copy_op *xop)
> 	 */
> 	seg_desc =3D &p[16] + tdll;
>=20
> -	rc =3D target_xcopy_parse_segment_descriptors(se_cmd, xop, seg_desc,
> -						    sdll, &ret);
> +	rc =3D target_xcopy_parse_segment_descriptors(xop, seg_desc, sdll, &ret=
);
> 	if (rc <=3D 0)
> 		goto out;
>=20
> --=20
> 2.31.1
>=20

Looks fine.=20

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>

--
Himanshu Madhani	 Oracle Linux Engineering