Received: by 2002:a05:6a10:6d25:0:0:0:0 with SMTP id gq37csp1934706pxb; Mon, 13 Sep 2021 08:29:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxXluUw+mT+goaXYsAbdd5rlgpVel1R3NKJhgqIyXQeWVrp5XwmxLGBvickJDi5UgRGrlsf X-Received: by 2002:aa7:cdd1:: with SMTP id h17mr14127026edw.346.1631546941472; Mon, 13 Sep 2021 08:29:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631546941; cv=none; d=google.com; s=arc-20160816; b=aS/LMYyjpudJ5LnMT960PwsLfjimyK+JP3POH2ZYkJRaD0mID8xVa8YDvayW23NpO7 I0YphV9ASFmxJlOKbWWF/11puC2zp40Pndw/JfLo6jEzBUKAeN3YEnfJtOPPSqitNa1H w33rI+LVA2VBOk0BNtBBmWYh67eHmGG0jDi7OU7cUiPnqnn9Mx6icuQ27gwjL5juxbKu essnF4GTB87tYL9vpm8TOLf2AzEqPCGEzLLNidyDi7NoaQmvqg9mpQs7OAcFRmW29STJ 33dM9KHFE4FFX2nHlTYZ22p9ps0QeYvk6jQeoDpW4k9mI1eB3UqweiDWM78FPk7a8pj/ kOtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:sender:dkim-signature; bh=Cc3rfqH5qwQXfY+9743ExBqMLbOukLsqMfSk7T1TjH8=; b=NSlHlOp5ca/R18v+J+wrZ7mzTKEkRPHMZhUHCnqQlkrIoH9okKwCr2HrNL3hqn2mZ9 Ae5GO+pFnMLwEW5bIy1MGyXjV7KnmyUOpQBXVUUHl8QYdQjY3heloFmDLQddDiQ+FgN9 dF7RoopYL2DQR1PdBeSUdw41omJhulwJBGcXvZ0J5C0ozIwhEYM7kNwo6vF85YX28lmh Kq3ICRhSavgqPA3eJTjf27VRCoN44AQ6blY5oa7lvP0dWXfxAKf8RAPeVbhSJ4Y9RkZp nq3vvLBTIAV9lhLrs9Fca3Bz3prvOysN87xkFydHKSivfD5nYwDbV6bcg1XYQCx4bV0V OtOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=ctacHN8t; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c19si7992294ejj.716.2021.09.13.08.28.36; Mon, 13 Sep 2021 08:29:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=ctacHN8t; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244199AbhIMP1g (ORCPT + 99 others); Mon, 13 Sep 2021 11:27:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245118AbhIMP13 (ORCPT ); Mon, 13 Sep 2021 11:27:29 -0400 Received: from mail-ot1-x334.google.com (mail-ot1-x334.google.com [IPv6:2607:f8b0:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 803B1C0F976B; Mon, 13 Sep 2021 07:24:32 -0700 (PDT) Received: by mail-ot1-x334.google.com with SMTP id a20-20020a0568300b9400b0051b8ca82dfcso13524078otv.3; Mon, 13 Sep 2021 07:24:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Cc3rfqH5qwQXfY+9743ExBqMLbOukLsqMfSk7T1TjH8=; b=ctacHN8t8zTfoxyXUZTopSmEK0Jayf7mBV/9AielDiwbwEv+8uoLJOsK1D6E5P/R8y LwItjjhdJ/cLEF3jYMzxsTKo9BwSYs23FV+bDh8egrKd8RIKFj153I/m0tIa0qvwWwbS 4AMc0+yr2y/qSVXrwWcCJED7v7U/ICrFzOPK99OpJEc9dCMKO6g6zmJhRHIwRvL/c/Nh 6CKJL4H553g6s5f/UW4LutcrgJc9KJRPKMqR+p4jntw9tV9QJPVOfaHQH30ztfPPQjw7 dGGEBxCUZIWFZg9AZ4JGF7eDdsESzEn1mnSjnXP5n9sO4J1Eytb8fCm68Hly2k9pDjwf N96g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Cc3rfqH5qwQXfY+9743ExBqMLbOukLsqMfSk7T1TjH8=; b=So6BYJTiUlHlbQ6pdsfdfkq6zBsEQ/2ZPalgb1etXkFxdYwskx0sysXWCog5z8VvZz SDnVj7Y0g++OnMUPcevZaJEW7FACtCmNRi4MOGiUmOhUuYfTYE3jWpNpR0YtaIgTi0D+ 5nLEOzcqoTAtSxy44FcR7j0iWyR940Jq8oZQCyQsX7KLiQRX4K1Ipt9DCzT/jwgwBaRT 2j22RiISiTlStY1YauHydqma7E7ClXoM96wK68X/vzIZ3vuVoANC0fwDvGTQ00p6O3+U 1+lJIPYs2cY98GEasOALz+iGWdXXRdesztgIrNHGcairXl51KXdzcCPu71UCevmQQ/YJ rt0g== X-Gm-Message-State: AOAM532ms7Sa5ZCRyOzGy0hOoRRpCEf7A/hU8ocbMgrROIlV5j1QDolT PIjjcjz6/thgrO1jT/tsfqU= X-Received: by 2002:a9d:63cf:: with SMTP id e15mr9946401otl.172.1631543071900; Mon, 13 Sep 2021 07:24:31 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id v5sm1869559oos.17.2021.09.13.07.24.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Sep 2021 07:24:31 -0700 (PDT) Sender: Guenter Roeck Subject: Re: [PATCH v3 1/2] scsi: ufs: Probe for temperature notification support To: Avri Altman , "James E . J . Bottomley" , "Martin K . Petersen" Cc: "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Bart Van Assche , Adrian Hunter , Bean Huo References: <20210912131919.12962-1-avri.altman@wdc.com> <20210912131919.12962-2-avri.altman@wdc.com> <8abe6364-9240-bcaf-c17f-1703243170cb@roeck-us.net> From: Guenter Roeck Message-ID: Date: Mon, 13 Sep 2021 07:24:29 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/13/21 12:49 AM, Avri Altman wrote: >>>> The "enable" attribute only makes sense if it can be used to actually >>>> enable or disable a specific sensor, and is not tied to limit >>>> attributes but to the actual sensor values. >>> See explanation above. >>> Will make it writable as well. >>> >> >> That only makes sense if the information is passed to the chip. What is going to >> happen if the user writes 0 into the attribute ? > Will turn off the temperature exception bits, so that Tcase is no longer valid, > and the device will always return Tcase = 0. > Ok. Then attempts to read the temperature should return -ENODATA, not -EINVAL, if Tcase == 0. Guenter