Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 13 Sep 2021 17:52:43 +0200
From:   Eugene Syromiatnikov <esyr@redhat.com>
To:     Jens Axboe <axboe@kernel.dk>
Cc:     Pavel Begunkov <asml.silence@gmail.com>, io-uring@vger.kernel.org,
        linux-kernel@vger.kernel.org, "Dmitry V. Levin" <ldv@strace.io>,
        linux-api@vger.kernel.org
Subject: Re: [PATCH v2] io-wq: expose IO_WQ_ACCT_* enumeration items to UAPI
Message-ID: <20210913155243.GA23359@asgard.redhat.com>
References: <20210913104101.GA29616@asgard.redhat.com>
 <872209f5-d11c-1b80-6146-5646206e22cb@kernel.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <872209f5-d11c-1b80-6146-5646206e22cb@kernel.dk>
User-Agent: Mutt/1.5.23 (2014-03-12)
Precedence: bulk

On Mon, Sep 13, 2021 at 07:28:11AM -0600, Jens Axboe wrote:
> This is really the same thing as before, just the names have changed.
> What I suggested was keeping the enum in io_uring, then just adding
> 
> enum {
> 	IO_WQ_BOUND,
> 	IO_WQ_UNBOUND,
> };
> 
> to uapi header. The ACCT stuff is io-wq specific too, that kind of naming
> shouldn't be propagated to userspace.

My apologies, I've overlooked the fact that the proposed names
are different.  Updated and resent[1].

[1] https://lore.kernel.org/lkml/20210913154415.GA12890@asgard.redhat.com/

> A BUILD_BUG_ON() could be added for them being different, but honestly
> I don't think that's worth it.