Received: by 2002:a05:6a10:6d25:0:0:0:0 with SMTP id gq37csp1988349pxb; Mon, 13 Sep 2021 09:32:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyCNUnsbamv4SUOPMfy1pcNs89acpoiInkV7IymSg4UjpL1Bu7qJxM5eq5pw7AAmcDWa8am X-Received: by 2002:a50:cc48:: with SMTP id n8mr7167826edi.304.1631550765297; Mon, 13 Sep 2021 09:32:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631550765; cv=none; d=google.com; s=arc-20160816; b=tCf+SrUaQtzWX1netl3U2KZAwvLGVRXl/qpHlYjbBbNzxR/Q/GgVucBxFX9Qny7Ssy 3jMCdTd4gTZOjHgKjptMVpfQlkVpM7bZ5mDXUecSjnx7SmeaD0ljCtyE80dLh2ldkkwe hChNwbvko6+x67Bb00O55POqYwZHNlXqdu6C7HM3WEmd6uTpobft1w5FHYKdS6huWjQL xmtdg7WY7YxlvvYN7cT/1XbZ34TXZVFoXkm74z4jYhSSNmRKazoi5Tej2bkcWN2RUqLO JJXhpjyqSnbV8STLoNnSvzOIbW7G9xFPsOefjpQG24QX1OzCHtzRFJEcL60o2SzNKoXj oJVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature:dkim-signature; bh=Dfx9ZUh8IlSB114cbG4XVpLALI8W+1SZrDn37ByerEE=; b=TAatY9ToCVHGQZEOCEpJxlgL5Sc43HD71ocnka6d/qIyzpezJEczLZydMubQt9JzOc 4450HbRAgR3Leob7ggt2XP9Ucqnjp5iSR2OBjYYn14JDoEpJU+zq/iKPtCmknl71E2MK Kn0Qguhgl42bvC1QCg1EQejQ6cHclVWrssNyRmFuNwfigbLFU38+znZ64cynaGaC8xhA OQS4bf313fEClqIEpTr0Q17CEF6EFPVBEAN0wjY3AUgKAAUXuFQuVsvLuS652EBv5sIP 3LwS8rME9lrWRoiOgt3FOLIn1u5iwKx0+qCJ7o4z+/sd29v4iCmkCEL8rxEC5Tojd0Bw E+tw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=kXjOO0iC; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x2si10070246ejy.385.2021.09.13.09.32.21; Mon, 13 Sep 2021 09:32:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=kXjOO0iC; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237839AbhIMQcG (ORCPT + 99 others); Mon, 13 Sep 2021 12:32:06 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:45182 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237856AbhIMQb7 (ORCPT ); Mon, 13 Sep 2021 12:31:59 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 442AF22028; Mon, 13 Sep 2021 16:30:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1631550642; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Dfx9ZUh8IlSB114cbG4XVpLALI8W+1SZrDn37ByerEE=; b=kXjOO0iCMoAKWnt6Opb8FFJugDUYZQ7DbzsDLuetsyrCbmiPllf/mkVR8VmNl9tWNWifs5 AoAoMzVmklJPB54/L4D4Nt4WVKMicnbLDU0dz1hPR58BymiqSOPOwFmy/LivFcuSEnZXFQ kL2G2EhSzQDHiZwB4Uru3KeH19XW7Gw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1631550642; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Dfx9ZUh8IlSB114cbG4XVpLALI8W+1SZrDn37ByerEE=; b=p64ujeY8XFsknqbEvjCTX1PfdqHjFQyxjmZkXXN2V0N30oiXhDFZdJNuK4dhWHt2m/z6RN c/ccMMs18608KnBQ== Received: from localhost.localdomain (colyli.tcp.ovpn1.nue.suse.de [10.163.16.22]) by relay2.suse.de (Postfix) with ESMTP id A9A4BA3B81; Mon, 13 Sep 2021 16:30:36 +0000 (UTC) From: Coly Li To: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-raid@vger.kernel.org, nvdimm@lists.linux.dev Cc: antlists@youngman.org.uk, Coly Li , Dan Williams , Hannes Reinecke , Jens Axboe , NeilBrown , Vishal L Verma Subject: [PATCH v2 0/7] badblocks improvement for multiple bad block ranges Date: Tue, 14 Sep 2021 00:30:09 +0800 Message-Id: <20210913163016.10088-1-colyli@suse.de> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is the second effort to improve badblocks code APIs to handle multiple ranges in bad block table. There are 2 changes from previous version, - Fixes 2 bugs in front_overwrite() which are detected by the user space testing code. - Provide the user space testing code in last patch. There is NO in-memory or on-disk format change in the whole series, all existing API and data structures are consistent. This series just only improve the code algorithm to handle more corner cases, the interfaces are same and consistency to all existing callers (md raid and nvdimm drivers). The original motivation of the change is from the requirement from our customer, that current badblocks routines don't handle multiple ranges. For example if the bad block setting range covers multiple ranges from bad block table, only the first two bad block ranges merged and rested ranges are intact. The expected behavior should be all the covered ranges to be handled. All the patches are tested by modified user space code and the code logic works as expected. The modified user space testing code is provided in last patch. The testing code detects 2 defects in helper front_overwrite() and fixed in this version. The whole change is divided into 6 patches to make the code review more clear and easier. If people prefer, I'd like to post a single large patch finally after the code review accomplished. This version is seriously tested, and so far no more defect observed. Coly Li Cc: Dan Williams Cc: Hannes Reinecke Cc: Jens Axboe Cc: NeilBrown Cc: Vishal L Verma --- Coly Li (6): badblocks: add more helper structure and routines in badblocks.h badblocks: add helper routines for badblock ranges handling badblocks: improvement badblocks_set() for multiple ranges handling badblocks: improve badblocks_clear() for multiple ranges handling badblocks: improve badblocks_check() for multiple ranges handling badblocks: switch to the improved badblock handling code Coly Li (1): test: user space code to test badblocks APIs block/badblocks.c | 1599 ++++++++++++++++++++++++++++++------- include/linux/badblocks.h | 32 + 2 files changed, 1340 insertions(+), 291 deletions(-) -- 2.31.1