Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210913163547.5156-1-will@kernel.org>
In-Reply-To: <20210913163547.5156-1-will@kernel.org>
From:   Linus Torvalds <torvalds@linux-foundation.org>
Date:   Mon, 13 Sep 2021 10:05:32 -0700
Message-ID: <CAHk-=whF01ZS30vQAEjY9K4RM_QNjZ0mTCTt8SY4KuER-2d14w@mail.gmail.com>
Subject: Re: [PATCH] x86/uaccess: Fix 32-bit __get_user_asm_u64() when CC_HAS_ASM_GOTO_OUTPUT=y
To:     Will Deacon <will@kernel.org>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "the arch/x86 maintainers" <x86@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Bill Wendling <morbo@google.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Sep 13, 2021 at 9:36 AM Will Deacon <will@kernel.org> wrote:
>
> Use the existing '__gu_ptr' source pointer to unsigned int for 32-bit
> __get_user_asm_u64() instead of the original pointer.

Heh. And by "existing" you mean "the one that exists _purely_ for this
exact reason and that wasn't used" ;)

What a silly bug. And it's existed for a year, which I think shows
just how little 32-bit x86 is used these days (*).

            Linus

(*) but also probably how few 64-bit user accesses we do - the fact
that the bug was actually found by the "copy_from_kernel_nofault" code
that just shares the infrastructure on x86 rather than any user access
code is kind of interesting.