Received: by 2002:a05:6a10:6d25:0:0:0:0 with SMTP id gq37csp2032708pxb; Mon, 13 Sep 2021 10:26:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzurEhzDznk92r5wQ/HaxYTCIR4LObE5JnSQvh1NcP7OAGM9wGpvK4CD+r5DjIi1RyOkDeL X-Received: by 2002:a92:c041:: with SMTP id o1mr9137098ilf.193.1631553999246; Mon, 13 Sep 2021 10:26:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631553999; cv=none; d=google.com; s=arc-20160816; b=Tzm+JbyHn7nIg0Lvb+ZGaatQ/pG1n1zWsW49xjoGzpwCAM4hY5s+57lHziKCSc6JHU 7ho/DzDz7xDiZgvtPBzsIqRYSX5S6kgA6Q+rH9XS+O4weOQmvSXLWzWVmWekBx4qRpQN dykjhR4njtwHo52ITKgxazjMFTQ2uEMcrzaVKkwQM7o9OvtiulX2rCnwI0y76vJPB7YL u7Ue3rC/OrVFMHraiOijeoT5yFYod//mtfXHQb3sqVYjmv+rf/cD/IIYd69gIdgGQ3gX HZ4HnBf6Lqb5RS111PIrZ115Ba9V8tO4SOe4fGaKGKvKz2z5u/fg8TwlK+miD/SSNwrS i4Lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=rol5r7oJODMPFUGcdcPAXQzw0cOzJ6J05+UigCiWU2Y=; b=vjos501eKcbmiA6J3yTWoZdCszQvQ8lOlAH5cSt5r7TTjeCOb6UT8HOe88A2apIwp0 zu0n/bC5+7KRzXapaTeFZFoztxo9FUMZ6yfyv08t2UrCwwSC+0rdiDiqHMQvyUsIBuac 8anouuzzcXWR95DTd8agGa88ZC9fR+ioQ0G4TosG99+v+b+vSYqi2yVD5Jr30+auY0sz Eo7jMl8U9R5oRf8VezU2hqR4NgX6v/IZl5idecNrXejG+EmYywowDsUPQQ8lSpHjNyEr B6cJA4uCx9tiTEj6KJwgLyrHfvPO8ZYNYuGyJENdOFhsOo+JHzvs3lLiKFEWXQEFIWAE 8xLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Tm0K3R4j; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n38si7341956jaf.72.2021.09.13.10.26.22; Mon, 13 Sep 2021 10:26:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Tm0K3R4j; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237818AbhIMR0z (ORCPT + 99 others); Mon, 13 Sep 2021 13:26:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:59278 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235123AbhIMR0y (ORCPT ); Mon, 13 Sep 2021 13:26:54 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id EAE5560ED8; Mon, 13 Sep 2021 17:25:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631553938; bh=vRZtqSJKoBInU3ECzYfOutpLY0p8fHJj9qP1b5Quywg=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=Tm0K3R4jZV+b4GK94Vi/PQliu6YS5icQl7MaPkxARWHZ9FsbR0KR7tx9aUD0TcJs2 wBkSI9WifQ1j99+mMrfFGrhv1Fe6N1MtLpEI1foOGUVWySA5irmzA07I60r0ctZqis wPYN0WLkzNw0/YSN/7DiU8iZpE9MfhgaqAxPC2P/gqnAZGkKsgezfFKUNFpEUwl5li xHQY4DtsayGJTs5/FkVpjdXjwJmw2RtQWBwie19T5pAD9ize3KJZkZqXZ8TkrTohK7 F/jAEcaysBDOGR4nOQxoB8pWFRuxHBTTE8gLYYAOsk2DBQUri2wPlKJx65+DCXCUtq /Su+qFG1pdwXQ== Subject: Re: [mcgrof-next:20210908-firmware-builtin-v4 2/11] drivers/base/firmware_loader/builtin/main.c:36:6: error: no previous prototype for function 'firmware_is_builtin' To: Luis Chamberlain Cc: kernel test robot , llvm@lists.linux.dev, kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Borislav Petkov References: <202109101524.pjY4q0Dy-lkp@intel.com> From: Nathan Chancellor Message-ID: <993e03a8-b07c-a8d8-8c9f-75bfbab00f0e@kernel.org> Date: Mon, 13 Sep 2021 10:25:35 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/13/2021 8:56 AM, Luis Chamberlain wrote: > On Fri, Sep 10, 2021 at 06:52:03PM -0700, Nathan Chancellor wrote: >> On Fri, Sep 10, 2021 at 05:48:23PM -0700, Luis Chamberlain wrote: >>> On Fri, Sep 10, 2021 at 03:41:31PM +0800, kernel test robot wrote: >>>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git 20210908-firmware-builtin-v4 >>>> head: 1c69d6a17750179d68bcaf6b16f9a08d2e475989 >>>> commit: 79e9fce20ee88ffe37542a66277628e6c53dde14 [2/11] firmware_loader: formalize built-in firmware API >>>> config: hexagon-buildonly-randconfig-r004-20210910 (attached as .config) >>>> compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 261cbe98c38f8c1ee1a482fe76511110e790f58a) >>>> reproduce (this is a W=1 build): >>>> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >>>> chmod +x ~/bin/make.cross >>>> # https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/commit/?id=79e9fce20ee88ffe37542a66277628e6c53dde14 >>>> git remote add mcgrof-next https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git >>>> git fetch --no-tags mcgrof-next 20210908-firmware-builtin-v4 >>>> git checkout 79e9fce20ee88ffe37542a66277628e6c53dde14 >>>> # save the attached .config to linux build tree >>>> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=hexagon >>>> >>>> If you fix the issue, kindly add following tag as appropriate >>>> Reported-by: kernel test robot >>>> >>>> All errors (new ones prefixed by >>): >>>> >>>>>> drivers/base/firmware_loader/builtin/main.c:36:6: error: no previous prototype for function 'firmware_is_builtin' [-Werror,-Wmissing-prototypes] >>>> bool firmware_is_builtin(const struct firmware *fw) >>> >>> This is a lie though its defined on drivers/base/firmware_loader/firmware.h >> >> Unless I am missing something, you don't include the firmware_loader >> copy of firmware.h in builtin/main.c (only the linux one)? Isn't that >> the source of the warning? > > You would think, but nope, its there: > > #include "firmware.h" I see that in drivers/base/firmware_loader/main.c but the warning is complaining about drivers/base/firmware_loader/builtin/main.c, where I only see #include Sorry for the issues with reproducing. For what it's worth, I can reproduce this locally and adding #include "../firmware.h" to drivers/base/firmware_loader/builtin/main.c fixes it for me. Cheers, Nathan