Received: by 2002:a05:6a10:6d25:0:0:0:0 with SMTP id gq37csp2052229pxb; Mon, 13 Sep 2021 10:53:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwTZRZCgTMC+aIRot4BoXFjj2e+oeE0E6uGyGmOXKHTSNB+EdK0LZ9A86J3V0MoE5tzIjPN X-Received: by 2002:a50:cd9d:: with SMTP id p29mr14348751edi.30.1631555619065; Mon, 13 Sep 2021 10:53:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631555619; cv=none; d=google.com; s=arc-20160816; b=GfSbK62Yi46GiK+9K20wP5HGa4s6R3Pfyq9aiZ1Ch5JCaYltsgKASkQFI0ir31Pgn4 HdmVelh817+tVJqaBWDO7wiABZ4UaoegXa7fwdi/HTSd9r8mvLmlXauen+yNCFav/N8e 3pbbFSsjvdcSZQnml8oy83B3wD4TO0kLi6Nd8hp7LYd2ZyBviXoCD2ufmcBaYHB4vFR8 njYE5n8CEF4gyuZBIezBYCSBNQ72v2/zw+piCgb6dGkASjvpXYPRfqkjj1DFiDt5hcPk JHCT5pP9qzlMVErlCA1a7AjrPIqUZlM0f1ZORdVkFfBuj1lVXX1deuYpmoqbG4XZVaq0 5UEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:references:mime-version :message-id:in-reply-to:date:dkim-signature; bh=heQI9hJRYZNN0F3wqdwBsNM0iszmJ1+UNOx43ei/BCA=; b=maj29nunK6heYIh8MF1pNj7fn/FbcyadK4dJnysI688wZdIe8UnpVSJoXbXLG2VkDo ryEWWzg3RB7i0eMdTDTGaKnDei3N09ukxPRbaWZLmKgxYZ6ZLUGJ91Ly9fzkGdeplZmC GWjNDb0TkpxLlz9F7kN1ub3xC9UdTt2JURfOIKeQoZ/zPk7joh5KmNeNXaV1YZ7LDXUB NiMkGUqCj9fJyJcWktW0t038FCYoeJZ3+osTKVTPGglairbM4V3lPAp9QbRRNYOTrR6U /mYbGdtHWEFlhyRB+c+Nd1+1qhSO2t0imZTIdT/gD0zAxb1P3lG9oTC8E1MkGcTfCcD5 6Wpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=i2hbw8Fe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hd17si7140101ejc.727.2021.09.13.10.53.14; Mon, 13 Sep 2021 10:53:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=i2hbw8Fe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239563AbhIML1x (ORCPT + 99 others); Mon, 13 Sep 2021 07:27:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239555AbhIML1s (ORCPT ); Mon, 13 Sep 2021 07:27:48 -0400 Received: from mail-qv1-xf49.google.com (mail-qv1-xf49.google.com [IPv6:2607:f8b0:4864:20::f49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C596EC061574 for ; Mon, 13 Sep 2021 04:26:32 -0700 (PDT) Received: by mail-qv1-xf49.google.com with SMTP id a11-20020a0ca98b000000b0037855a1171fso55550277qvb.12 for ; Mon, 13 Sep 2021 04:26:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=heQI9hJRYZNN0F3wqdwBsNM0iszmJ1+UNOx43ei/BCA=; b=i2hbw8Fe7sVHU566q0FLXy62ugeDqkJJyt5CZ0CRDVVlErfT6R2EnyiQMD2UU2/8b0 ScsIl8ZafYdGmTDU17WrkZjAdWMBTxCG84VNlB90cTj1wPLvAbpdRu5MzsQCort61cMg 62WdBVzIcnTrZR5wU6SLRHuQPFSjZNCt/uUuQfyR84h4tq6uZoRPBXGeR6Bt69NhJd/8 nn7Kd4Bl1ctKe69OVC4+J5P9F+lHpQcq2TthmzMBZKOs7YMXnuXxKLh2KJ/WGDKyXb/C eMBlk2cF39wbq6Z8BALvgLIF4+TBDj+vD93yBLW4fvWl0PLVrsDqhQhFeBcpTMwHL6lg PW1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=heQI9hJRYZNN0F3wqdwBsNM0iszmJ1+UNOx43ei/BCA=; b=CJ3cY3wqrpJkIfDZE9IPGh5did6i9h48fIAKDWWme1qSozdrLyX8x/cxvSFQwopnBH cfdrwC+IyQvQrt4mqcT3pvKl/Hrbj+WP07cAh0Y9k4cGdfLRq7fLFz5VhznDMQ8ULvSO VoEQZ4dAg3pWdlN6LaQaBYwThsJhFbCnepVKy3zrlSJHZCMUBb1DZ5DP4k0UdNhEBrIl xydNrn0Tf/Ir/RWGUiZ+chQ8ssusByVpL8A3RZmCXfvBs8FHWizaISeuIpz9ymd3YtKp bzbqfaIKPccazVSg0bKblPX+ZcB4+kNUnW9EyFSjC+epF8O6su9LdTLyxm0iOtO3FDTg ICqQ== X-Gm-Message-State: AOAM531qvlTXIV+FCAL5SHpjN8C4D2uqtNL2k1h5mc09ijcKTSjykVWx kqM4Gib05e9JEbA+7N4P7kNJBD0jQg== X-Received: from elver.muc.corp.google.com ([2a00:79e0:15:13:1f19:d46:38c8:7e48]) (user=elver job=sendgmr) by 2002:a05:6214:250f:: with SMTP id gf15mr10095078qvb.2.1631532391965; Mon, 13 Sep 2021 04:26:31 -0700 (PDT) Date: Mon, 13 Sep 2021 13:26:05 +0200 In-Reply-To: <20210913112609.2651084-1-elver@google.com> Message-Id: <20210913112609.2651084-3-elver@google.com> Mime-Version: 1.0 References: <20210913112609.2651084-1-elver@google.com> X-Mailer: git-send-email 2.33.0.309.g3052b89438-goog Subject: [PATCH v2 2/6] lib/stackdepot: remove unused function argument From: Marco Elver To: elver@google.com, Andrew Morton Cc: Shuah Khan , Tejun Heo , Lai Jiangshan , Andrey Konovalov , Walter Wu , Sebastian Andrzej Siewior , Thomas Gleixner , Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Vijayanand Jitta , Vinayak Menon , "Gustavo A. R. Silva" , kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Aleksandr Nogikh , Taras Madan Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org alloc_flags in depot_alloc_stack() is no longer used; remove it. Signed-off-by: Marco Elver Tested-by: Shuah Khan Acked-by: Sebastian Andrzej Siewior --- lib/stackdepot.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/lib/stackdepot.c b/lib/stackdepot.c index 0a2e417f83cb..c80a9f734253 100644 --- a/lib/stackdepot.c +++ b/lib/stackdepot.c @@ -102,8 +102,8 @@ static bool init_stack_slab(void **prealloc) } /* Allocation of a new stack in raw storage */ -static struct stack_record *depot_alloc_stack(unsigned long *entries, int size, - u32 hash, void **prealloc, gfp_t alloc_flags) +static struct stack_record * +depot_alloc_stack(unsigned long *entries, int size, u32 hash, void **prealloc) { struct stack_record *stack; size_t required_size = struct_size(stack, entries, size); @@ -309,9 +309,8 @@ depot_stack_handle_t stack_depot_save(unsigned long *entries, found = find_stack(*bucket, entries, nr_entries, hash); if (!found) { - struct stack_record *new = - depot_alloc_stack(entries, nr_entries, - hash, &prealloc, alloc_flags); + struct stack_record *new = depot_alloc_stack(entries, nr_entries, hash, &prealloc); + if (new) { new->next = *bucket; /* -- 2.33.0.309.g3052b89438-goog