Received: by 2002:a05:6a10:6d25:0:0:0:0 with SMTP id gq37csp2056675pxb; Mon, 13 Sep 2021 11:00:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx8YtZI2/yBYOrQDEidLv5aCR4h29bMhJLoZiWoCmo8pyUxIOuqgmWymTJ4bhk8mRcJr84l X-Received: by 2002:a17:906:c20d:: with SMTP id d13mr14335305ejz.259.1631556049359; Mon, 13 Sep 2021 11:00:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631556049; cv=none; d=google.com; s=arc-20160816; b=KUiZK7J11mGS2PNuNfnIngtDXd5T+DdRQt2RclhgWxjYINcMxuaZMlPKFrmakiQXS7 Tzf9doNavJe3K4PLePlAqVi0wuv2mKU5q/m8/48r8fdD95GZsLXp4dh5zfLuqCs+gZlJ 5vysRtEBTTZ2qgjc0g2ZSXtzzkUIovC+mmjjTpRGmJNsFvIGYS1TH5cShcqQTIWrK/yq qz1rqGCXyo8wzdYq0yhlGRnr2nlt6Ssw5iKyTSs0RuqfyaYNKMrWC08URHzTX23LwBnm FKKps4Yt1i3Y/TG/kbFqHdwFhupZvry3Favth9KqaJiAdh/QCEzEiu7BDsE6OpbMR3rQ B1vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:message-id:references:in-reply-to :subject:cc:to:from:date:content-transfer-encoding:mime-version; bh=XjxYZoXyK2ENUfaBKP1bbMD84YtAKz8MDU9nJFFdIu0=; b=G97++IWf8ep990fKMGja3PL2NMq5tl24k9EBXQvZduzhTTene2V0Z22a94QP1VlS4a 3N/CU17GsSPHxog324u7SBiAyFJXKDj+D4vfHVDePWvIzvujB/hnLJdqFC691051Ckqx LGeKPTh8t0xDlvcvmEGe4H3hLkd2gQiUBzSVRj8PaY1w5GNISdxRwi3CH7FfY9fnjgjo h1LftOzrADOkXB4f53N40kiw35b3GNz/XW/BpEtpDxjEotfNgLk2ooHbsCJNVrhB9WVv 0n1xTBr2VPf4mFzhijLmSDh3e5cBdGMQKNgy6gel5BruEekUDLAWOyeeKtoF/2t2QcJ7 c0xg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hq33si7019190ejc.437.2021.09.13.11.00.25; Mon, 13 Sep 2021 11:00:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239985AbhIMM0r (ORCPT + 99 others); Mon, 13 Sep 2021 08:26:47 -0400 Received: from mxout70.expurgate.net ([91.198.224.70]:26312 "EHLO mxout70.expurgate.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235143AbhIMM0q (ORCPT ); Mon, 13 Sep 2021 08:26:46 -0400 Received: from [127.0.0.1] (helo=localhost) by relay.expurgate.net with smtp (Exim 4.92) (envelope-from ) id 1mPkhy-000OBp-TL; Mon, 13 Sep 2021 14:05:10 +0200 Received: from [195.243.126.94] (helo=securemail.tdt.de) by relay.expurgate.net with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mPkhy-000OA6-9M; Mon, 13 Sep 2021 14:05:10 +0200 Received: from securemail.tdt.de (localhost [127.0.0.1]) by securemail.tdt.de (Postfix) with ESMTP id E0D66240042; Mon, 13 Sep 2021 14:05:09 +0200 (CEST) Received: from mail.dev.tdt.de (unknown [10.2.4.42]) by securemail.tdt.de (Postfix) with ESMTP id 6B451240041; Mon, 13 Sep 2021 14:05:09 +0200 (CEST) Received: from mail.dev.tdt.de (localhost [IPv6:::1]) by mail.dev.tdt.de (Postfix) with ESMTP id 009F320110; Mon, 13 Sep 2021 14:05:08 +0200 (CEST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 13 Sep 2021 14:05:08 +0200 From: Florian Eckert To: Jason Gunthorpe Cc: peterhuewe@gmx.de, jarkko@kernel.org, Eckert.Florian@googlemail.com, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tpm/tpm_i2c_infineon: Fix init endian vendor check In-Reply-To: <20210908134002.GY1200268@ziepe.ca> References: <20210908133416.12408-1-fe@dev.tdt.de> <20210908134002.GY1200268@ziepe.ca> Message-ID: <03fd525968fcd8443a96e5ad441140ab@dev.tdt.de> X-Sender: fe@dev.tdt.de User-Agent: Roundcube Webmail/1.3.16 X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail.dev.tdt.de X-purgate: clean X-purgate-type: clean X-purgate-ID: 151534::1631534710-0001D4F7-557544FE/0/0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> By converting the vendor ID with ie32_to_cpus() to the correct format, >> the TPM chip is recognised by the driver and works as expected. >> >> Signed-off-by: Florian Eckert >> --- >> drivers/char/tpm/tpm_i2c_infineon.c | 2 ++ >> 1 file changed, 2 insertions(+) > > vendor should be marked as a __le32 and so forth Thanks for your feedback. I will push a v2. > > Jason