Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp143545pxb; Mon, 13 Sep 2021 15:22:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwYC5hMMgyDEPcc4FlL+9EKrlFNe6Jver7A8T0bYjcn3BxAKZ20qszLC0kYk+stSAtkVgBW X-Received: by 2002:a17:906:c20d:: with SMTP id d13mr15463232ejz.259.1631571735132; Mon, 13 Sep 2021 15:22:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631571735; cv=none; d=google.com; s=arc-20160816; b=B5nQlQiIrHmzCRh8coYybtaI1TEyKqg/AYQJQtQYEn3ssCKveQTk6XdRrE7ilp19/j 1ETtB+NOXVF7yZTJivgI+XkGZfdDoVP9LQpe6WPVw1elYEfAQd8tq6zf9v7PRY+bxFww qKebAmC+7lZTMT7iFC7kHq9PFjqqme1OTxgJ7NJdDEzPlG5riNdObSCXN0lLO36ab0UL mW29l3HhoAv9hFGcZtHlu/ra8CUgsguAOqxu9xYvpbS+h5AUD59mWgtyIwAs2RAwOssV hOXOskKeaHPBxoa7A0068pCYxJ8S7U6zhOH/LUG78Idhmw7mjZeiFtY2WN9vv2q687/D iAlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=kkY6hOj6poNMNgasvqy7n8W6KmI2H+lit88YbYgMkJo=; b=oDilgOs3ua8K2DuqKAsqKO/x5yXg9wzmd+GpSstwuqRoVIWnnGaqrkrizPf6PcMdf+ +1/xRWUnarGg1KF4DtHnl+5/PGTmnELUjHMo6DOgX8wQDb5hcNF4qF8M6yIB/r1LBc6Q 1m3BIHqNc/3EsARTDj6ynCJ3m1vNz9SShZqSWblSWe9NmvnMhPZq7K18GcO1RuF5tjWz VzNCf6AVj464zu54j8O83lUIamTLY6UJptoHC4SxTyvIluU2B/NdPwaSiAqDhTLOgVOa 180b5X0YfrU6DrmsJ3rS5BQvxDHgSRt00Tskh4hdKhmgUS8NfvA6CBUEPfyTv2sqpEo9 G5rQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=HFUv6UsJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v28si10153920ejk.276.2021.09.13.15.21.49; Mon, 13 Sep 2021 15:22:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=HFUv6UsJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243203AbhIMN76 (ORCPT + 99 others); Mon, 13 Sep 2021 09:59:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:46242 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343698AbhIMN4o (ORCPT ); Mon, 13 Sep 2021 09:56:44 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E749261980; Mon, 13 Sep 2021 13:36:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631540172; bh=B6CnmDKNiz/YeE4W4DuU3Bd7xg2Uamg9jbmgauASUws=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HFUv6UsJKVyqqjZIrOokl/rd6+MJ0C0r3HL/0EryNvhpZlArOH54XDDKHTwzZwp9n cFzov9eXSs6YZA/9/edN8PAeLvJ8b7GWucDdnz82j8r5mo42w+1NzkMoXLvkpYwt1u 5ADRaIKmzLsw0N8FtOFq4uUNawvidAU6byUzrgc8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , Wei Yongjun , Steven Price , Sasha Levin Subject: [PATCH 5.13 081/300] drm/panfrost: Fix missing clk_disable_unprepare() on error in panfrost_clk_init() Date: Mon, 13 Sep 2021 15:12:22 +0200 Message-Id: <20210913131112.109245217@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210913131109.253835823@linuxfoundation.org> References: <20210913131109.253835823@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wei Yongjun [ Upstream commit f42498705965bd4b026953c1892c686d8b1138e4 ] Fix the missing clk_disable_unprepare() before return from panfrost_clk_init() in the error handling case. Fixes: b681af0bc1cc ("drm: panfrost: add optional bus_clock") Reported-by: Hulk Robot Signed-off-by: Wei Yongjun Reviewed-by: Steven Price Signed-off-by: Steven Price Link: https://patchwork.freedesktop.org/patch/msgid/20210608143856.4154766-1-weiyongjun1@huawei.com Signed-off-by: Sasha Levin --- drivers/gpu/drm/panfrost/panfrost_device.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/panfrost/panfrost_device.c index fbcf5edbe367..9275cd0b2793 100644 --- a/drivers/gpu/drm/panfrost/panfrost_device.c +++ b/drivers/gpu/drm/panfrost/panfrost_device.c @@ -54,7 +54,8 @@ static int panfrost_clk_init(struct panfrost_device *pfdev) if (IS_ERR(pfdev->bus_clock)) { dev_err(pfdev->dev, "get bus_clock failed %ld\n", PTR_ERR(pfdev->bus_clock)); - return PTR_ERR(pfdev->bus_clock); + err = PTR_ERR(pfdev->bus_clock); + goto disable_clock; } if (pfdev->bus_clock) { -- 2.30.2