Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp150061pxb; Mon, 13 Sep 2021 15:34:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJys8V4qGAOYEVX041zV/NKYW+7o336IrbnSzP6sgOMlD7kQ0sih1wTslwwk03wQSP8+n7un X-Received: by 2002:a17:906:7047:: with SMTP id r7mr14774554ejj.342.1631572469002; Mon, 13 Sep 2021 15:34:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631572468; cv=none; d=google.com; s=arc-20160816; b=j9VTa1+BnBLQDlZaRDxpX9PXZxhaBcm3EAygz8ObeGlCYMQEdmhJu/P0uYJHvFit5/ A+dorXykYYiFjh/Cz7rkC9rCvJrNYYcqqv20LGgGFxlXJckNSca6jKtnStQPDsbC9Xcz 00jo5SzLlxd2HITVIC2yuJumv+YMniF7iFz6UdxSlKlH7Hs+g465mjWoKKTQJn2ej4ZV EM4bPCGCXYo7VgMBc1ETXtAg4623ZaHrc8uO3i6iIVgdzKya3KeeyZmN3QBria60ZKDW qc8penEzKRRUHVP9Iv9DvGkEeohEyXMPbix2FFiVilGE5fhShp/xhguN0I8aRTBZW7aR 6zzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=T1rMFQJMGHoJyI+PS7SrA76UH1+g9dVleR1azte/c9Q=; b=nelce3ZDaMLx262dseq9eqWf609VPqHNlxtgMJKf7Y/1+BMHkrqLjRhjI84/lGnGXp RdHxUk/XT1GjFxDtb6u25DodE+taZ6nzc46S3nAN+yjO45QkPKMZAo44I7D7/BEJp8RW HAzMeUXJEItIaCalTeg8UYDFw8LXgpuVSPKau4Z8Q8CaYjMPCtg0pgqL4jQeU74gq4LI jbrc0sLv/+0D+uNtsmym4w9oAQUwa17V4CVhMl0MeSHNqu6eWwygpHjTiA2lopxa/1YS M12F36MK8w/SzOmHi381kfZOM9OXoeEWyP2uYFBxP/NDxZheJoDkQn0Ht3msaj1NUc8r AbgA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=XsPNjeqJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y13si9665496edm.398.2021.09.13.15.34.02; Mon, 13 Sep 2021 15:34:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=XsPNjeqJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242880AbhIMOAO (ORCPT + 99 others); Mon, 13 Sep 2021 10:00:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:40482 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245562AbhIMN5m (ORCPT ); Mon, 13 Sep 2021 09:57:42 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8E4E2619F9; Mon, 13 Sep 2021 13:36:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631540192; bh=yZD8SegFW9VZXM1gnQs7nsGAbgf53JK5MyEPkIN/eAk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XsPNjeqJm6sSbfcVKY7m1P/lnzuczN5aqekjSZdG432zllcdlQnBI/oteZbx2m8un FFQStkvLo9mlSqMMzMbMxuOGYNy7bSvSovPRZtDAE8WTjX8YqsqwkWE/EqMpiudJlA BL2tY62JZo88TMhclDsLMqzz2VGingIBrsYbXz6c= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sanchayan Maity , Vladimir Oltean , Peter Ujfalusi , Vinod Koul , Tony Lindgren , Mark Brown , Sasha Levin Subject: [PATCH 5.13 058/300] spi: spi-fsl-dspi: Fix issue with uninitialized dma_slave_config Date: Mon, 13 Sep 2021 15:11:59 +0200 Message-Id: <20210913131111.325748437@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210913131109.253835823@linuxfoundation.org> References: <20210913131109.253835823@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tony Lindgren [ Upstream commit 209ab223ad5b18e437289235e3bde12593b94ac4 ] Depending on the DMA driver being used, the struct dma_slave_config may need to be initialized to zero for the unused data. For example, we have three DMA drivers using src_port_window_size and dst_port_window_size. If these are left uninitialized, it can cause DMA failures. For spi-fsl-dspi, this is probably not currently an issue but is still good to fix though. Fixes: 90ba37033cb9 ("spi: spi-fsl-dspi: Add DMA support for Vybrid") Cc: Sanchayan Maity Cc: Vladimir Oltean Cc: Peter Ujfalusi Cc: Vinod Koul Signed-off-by: Tony Lindgren Acked-by: Vladimir Oltean Link: https://lore.kernel.org/r/20210810081727.19491-1-tony@atomide.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/spi/spi-fsl-dspi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/spi/spi-fsl-dspi.c b/drivers/spi/spi-fsl-dspi.c index fb45e6af6638..fd004c9db9dc 100644 --- a/drivers/spi/spi-fsl-dspi.c +++ b/drivers/spi/spi-fsl-dspi.c @@ -530,6 +530,7 @@ static int dspi_request_dma(struct fsl_dspi *dspi, phys_addr_t phy_addr) goto err_rx_dma_buf; } + memset(&cfg, 0, sizeof(cfg)); cfg.src_addr = phy_addr + SPI_POPR; cfg.dst_addr = phy_addr + SPI_PUSHR; cfg.src_addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES; -- 2.30.2