Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp171409pxb; Mon, 13 Sep 2021 16:12:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzfyMKt7aKkE4qfYaXsrt8l0uw4td+HXN3q+mVX41lCmvrhj+z16GpFoYL3HFhPMJBekyk4 X-Received: by 2002:a05:6e02:eaf:: with SMTP id u15mr2577883ilj.313.1631574729923; Mon, 13 Sep 2021 16:12:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631574729; cv=none; d=google.com; s=arc-20160816; b=OMAlsEvWzoXvbjQnFgD73sL0zcLgnCgV904nqBAY9GA16zMYY59isuy4HRrgIevFYY CEM28iNZ2LYdPX3XIp6mGC9LTk5EinUl9Pe7pbvyZLnrUxs0e+4M3NoZIFlnHnYjFPm4 /FIutDnHW7ZPKzPYWAsKny6SrQWLsVtR9lZnhJAmbVhkvxXAWOJGAlfKlLb/nvYnJ8p+ 38+bKfzjoFYJanEAnFIAjgNlZnuPGd/VlSUnODLaDQ4i1Pc3B/zJUHGLqTiUKplUXaaN eNas6LM1C6dnJlLbEg6RZu9vWcM16shiWRpVOTTOUjr4TYnn3GcBZpsuAC41m1NiNmE7 qoVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=bUgJuh2bjcAtR+7nbPUh9CPjhziQuqwEPOodbspa4+M=; b=X66s3iIIv2FTzqmIHLZCE87XPActYdvfir6xfczih4wMScn/inf76iVAIwUYYjC1E2 iFZGzvbDOqxHd6qbNp/xB5TmEt3yMCbGUwutei+pf4vsmWMjBZlZxowfXg1TS3RiMLKG 5jJh7J6/DxXUgIjBa+zMhSl7fbMCalHWxpkubMMZ9UVOvPv0zB1S7RKjkoWMqmMGwGl2 SmEqau9MS4B0ltLF7HUrqXbmOxsAKiU+NBc2WDh/ffEswePYFk0nmwEiJoWp1Yuy93lr 2JOquha9p2DORxNEfHJm6mUf+1hGRQyssy9Usg0KDjXrnK90085svKXKNXLmbmQwxly5 Mydw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=eMy+CLYR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n2si10401063jaj.35.2021.09.13.16.11.58; Mon, 13 Sep 2021 16:12:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=eMy+CLYR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243646AbhIMOkg (ORCPT + 99 others); Mon, 13 Sep 2021 10:40:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:55798 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347646AbhIMOfR (ORCPT ); Mon, 13 Sep 2021 10:35:17 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id AF876617E1; Mon, 13 Sep 2021 13:53:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631541202; bh=uuZMw6J5hMtC9lRbJ1wg88tUyZpGYzYRmpNXWwfNY5U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eMy+CLYRY02v+Q2mEES1YlHnHe+TM6+5KPzoLbCsOIyztj5nJcMDsr5yppzoop5sq GjbJlAl4eG6LGC4OvckQA+4x/gG8nyVYeN1opjaKWy2wzZk0E7lEaEncpTXfgtTpd1 DFxowW/lDr+5TmWPJ0L1eKbOEO49U6ldjxxMD5Ug= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Colin Ian King , Marcel Holtmann , Sasha Levin Subject: [PATCH 5.14 172/334] Bluetooth: increase BTNAMSIZ to 21 chars to fix potential buffer overflow Date: Mon, 13 Sep 2021 15:13:46 +0200 Message-Id: <20210913131119.167547268@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210913131113.390368911@linuxfoundation.org> References: <20210913131113.390368911@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King [ Upstream commit 713baf3dae8f45dc8ada4ed2f5fdcbf94a5c274d ] An earlier commit replaced using batostr to using %pMR sprintf for the construction of session->name. Static analysis detected that this new method can use a total of 21 characters (including the trailing '\0') so we need to increase the BTNAMSIZ from 18 to 21 to fix potential buffer overflows. Addresses-Coverity: ("Out-of-bounds write") Fixes: fcb73338ed53 ("Bluetooth: Use %pMR in sprintf/seq_printf instead of batostr") Signed-off-by: Colin Ian King Signed-off-by: Marcel Holtmann Signed-off-by: Sasha Levin --- net/bluetooth/cmtp/cmtp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bluetooth/cmtp/cmtp.h b/net/bluetooth/cmtp/cmtp.h index c32638dddbf9..f6b9dc4e408f 100644 --- a/net/bluetooth/cmtp/cmtp.h +++ b/net/bluetooth/cmtp/cmtp.h @@ -26,7 +26,7 @@ #include #include -#define BTNAMSIZ 18 +#define BTNAMSIZ 21 /* CMTP ioctl defines */ #define CMTPCONNADD _IOW('C', 200, int) -- 2.30.2