Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp171445pxb; Mon, 13 Sep 2021 16:12:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyfpT5iz5igPKvSV+JxOXaZK15wxzm3gc6E8dLMIXp7XU71Dtj+h1fH1R05hGCKe41jaeAl X-Received: by 2002:a5d:935a:: with SMTP id i26mr10950503ioo.79.1631574733217; Mon, 13 Sep 2021 16:12:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631574733; cv=none; d=google.com; s=arc-20160816; b=09fJp6KyauWXrLkH6Nqz7yYYYf3YJUBSf0y7hbho1B0kFYKPtzo8HRnlHC348V2pHF d7hLPnqNy8bhyWC5lrt0/I8696vLpRC/mo0AjVBGrGbJjmzO89mmRqlTkQitUw5EfgPi wQCXvdlBFUXZGOSq/39gRoWsILvEkjeyot+SbwLqGG5CD+84o6vZG7zzEP0mMzPI47g2 k2iC1bLLQNG44V1PobroSTLmjRJsgFmMJN9xt/wSakDL5K1aP3RTCjWlgNoVs7I4qx9b qjFo6+YYFF62SKenZ/oMu3/xTF6LoVeAehDiOVuEeSJZZJ4JcBr3lC/MOMexRLspscyl fnMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=JnrleraATE27E4z7XALpfivGrrAvGshap3pUaIvMCW4=; b=xB0tOtj6FEkrgQ/7yyZ5dccfsELdtesnpKGpg0RiVFAUJdT4PQOSs4TkcqHaVHAh8R L0TUwvGS/Jcnk2T+JlpCBOmM5y/0kNQVsaTc2h73C9Q+EyaX7AeUNemuW/CBW6ESMpwN aJNpStg6zVsb6NPRi1bEqBHnS26xmiFWbb8d3rTAvFHjJwCzzODdjn4+FBA2NXKrI7pp ZkIO5AjkZ45S0BhsH0MTKXhvly/Zp0I2ERr8L/0joEhhoVyk3y8Rdxjn/GQHY0BRSC4G 2ZxilGMLZm7uH43mBJT0kpkzNPxhrAwAX+BLl9NlN43YjRxLz4qtA3qQTER+jlC5rXXa m6rg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=0kmmM24G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n3si1869795ilj.23.2021.09.13.16.12.01; Mon, 13 Sep 2021 16:12:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=0kmmM24G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344660AbhIMOko (ORCPT + 99 others); Mon, 13 Sep 2021 10:40:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:55828 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347690AbhIMOfV (ORCPT ); Mon, 13 Sep 2021 10:35:21 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2EF73617E3; Mon, 13 Sep 2021 13:53:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631541209; bh=k7R7caureSstJbIJr1FTSSD6NyAVWVoz5kkbTZepus4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=0kmmM24GI1Uj6smXYRP4omNJpG4YXFiAhsl1Q8ydOtnjPm10AXIp9oknn+DluzhKl n2gMH30lCHLQjtrkv4O5d+pK6+JdzWR/nloefLKGv6OMMD5T0v7MO6d0mhuUm4b+to JZ8wrCWJzi/ia7t6hrSDPpNiNL/9qczFKIxsTMXo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Robert Foss , Jernej Skrabec , Sasha Levin Subject: [PATCH 5.14 175/334] drm: bridge: it66121: Check drm_bridge_attach retval Date: Mon, 13 Sep 2021 15:13:49 +0200 Message-Id: <20210913131119.263275770@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210913131113.390368911@linuxfoundation.org> References: <20210913131113.390368911@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Robert Foss [ Upstream commit bd03d440e2589b9c328f40ce60203adf2b19d2e2 ] The return value of drm_bridge_attach() is ignored during the it66121_bridge_attach() call, which is incorrect. Fixes: 988156dc2fc9 ("drm: bridge: add it66121 driver") Signed-off-by: Robert Foss Acked-by: Jernej Skrabec Link: https://patchwork.freedesktop.org/patch/msgid/20210805185039.402178-1-robert.foss@linaro.org Link: https://patchwork.freedesktop.org/patch/msgid/20210805185039.402178-1-robert.foss@linaro.org Signed-off-by: Sasha Levin --- drivers/gpu/drm/bridge/ite-it66121.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c index 7149ed40af83..2f2a09adb4bc 100644 --- a/drivers/gpu/drm/bridge/ite-it66121.c +++ b/drivers/gpu/drm/bridge/ite-it66121.c @@ -536,6 +536,8 @@ static int it66121_bridge_attach(struct drm_bridge *bridge, return -EINVAL; ret = drm_bridge_attach(bridge->encoder, ctx->next_bridge, bridge, flags); + if (ret) + return ret; ret = regmap_write_bits(ctx->regmap, IT66121_CLK_BANK_REG, IT66121_CLK_BANK_PWROFF_RCLK, 0); -- 2.30.2