Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp173257pxb; Mon, 13 Sep 2021 16:15:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxOvnRTGNt7uerIWdlramrkq9AJipRiZX5erRn7a08oT0PhIoPB5TslLSrdwamdCC5jfuIG X-Received: by 2002:a92:2a10:: with SMTP id r16mr9618634ile.309.1631574903764; Mon, 13 Sep 2021 16:15:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631574903; cv=none; d=google.com; s=arc-20160816; b=DuspNKuySRltWshaOECTkMJRiwrkyWl+Ut4uShbfZ1MEttyDydEAXlTZBbj61Nh4ll K5uu5DrfSF9C8+wFFXcSS9XNNgP2XgRY5Jtjr+opUMqzH3V04/BOZDf+sxN1KzMYEhUM ykPdukCm5q8jkw5UB+F1ViHRLSFuFykmm0+zCQYB60aq2l4YLZxkW9l4fRHB1s5gEbfM Ex9iQL19gKVxvVHKtlBx0FFabc1a1+wVvRHpuWXsRZFY1ckEojEgylF1Km0pIG8kLwi3 UTds1hXmjFZ42cax/pbVvBV7vcWSIZwsn/zddyHVV9/WiU9NDSFUYNHjRqCvjj81amdL j/cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=6OWJZGFubShjVmEEWRrSR4j70SxgIz92SKzecssqWUQ=; b=E1DWyZA1I0y4VSNmDh+q3e1zLRxyN1xTjkP9dYhK3dmp7OlcX5EQPTACDv1N8HWqga wOYHz5F8IxrkCAEQ4irkKKXzKo8OfEWsIfmtyhazEY3N2XvK/gQUIx+SRAeEz/FZ1yvY KhFmlPl5c9exoPbfv3IhyQXynEPrGZlf8SleM9zdgb5WTIC4lODhrHbMEUw4deB2ApRY jt4gU+mZX+J8AqYarvzm7RSKVSf/0L+2+G+FEFml7Jfb/f78ghSO5DVPoEIqmXZ9mV+p nRCoI21gsFXn0+g4Nw7HOQlxpxusj7KRvBEN92EU+Yu+yI2j2DmGgrdWN///XaP08+yV jvrQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=lk5d38t4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p33si7807727jac.94.2021.09.13.16.14.52; Mon, 13 Sep 2021 16:15:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=lk5d38t4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348153AbhIMOox (ORCPT + 99 others); Mon, 13 Sep 2021 10:44:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:57712 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346806AbhIMOjl (ORCPT ); Mon, 13 Sep 2021 10:39:41 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 94BB460698; Mon, 13 Sep 2021 13:55:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631541329; bh=m+rTPqoENtqtj2TZXeW4E1SejdlqGNQUDAe2NhIqw9o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lk5d38t4Q956uUyOKb977XqptOrxEbltThmNqkviF9YX3SFSLR1wI078k7whaVxWx DzB6RrJg4uxmtwa5o6lkD9k68NXGdNG7g5AeMCE608QzLpDomU6Uz9iBQf1al3WoQO hO7CHn+9vhFNJvZo+ljNfr1wvmQJnCttihb3xzpI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Vitaly Kuznetsov , Michael Kelley , Wei Liu , Sasha Levin Subject: [PATCH 5.14 255/334] hv_utils: Set the maximum packet size for VSS driver to the length of the receive buffer Date: Mon, 13 Sep 2021 15:15:09 +0200 Message-Id: <20210913131122.031369469@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210913131113.390368911@linuxfoundation.org> References: <20210913131113.390368911@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vitaly Kuznetsov [ Upstream commit 9d68cd9120e4e3af38f843e165631c323b86b4e4 ] Commit adae1e931acd ("Drivers: hv: vmbus: Copy packets sent by Hyper-V out of the ring buffer") introduced a notion of maximum packet size and for KVM and FCOPY drivers set it to the length of the receive buffer. VSS driver wasn't updated, this means that the maximum packet size is now VMBUS_DEFAULT_MAX_PKT_SIZE (4k). Apparently, this is not enough. I'm observing a packet of 6304 bytes which is being truncated to 4096. When VSS driver tries to read next packet from ring buffer it starts from the wrong offset and receives garbage. Set the maximum packet size to 'HV_HYP_PAGE_SIZE * 2' in VSS driver. This matches the length of the receive buffer and is in line with other utils drivers. Fixes: adae1e931acd ("Drivers: hv: vmbus: Copy packets sent by Hyper-V out of the ring buffer") Signed-off-by: Vitaly Kuznetsov Reviewed-by: Michael Kelley Link: https://lore.kernel.org/r/20210825133857.847866-1-vkuznets@redhat.com Signed-off-by: Wei Liu Signed-off-by: Sasha Levin --- drivers/hv/hv_snapshot.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hv/hv_snapshot.c b/drivers/hv/hv_snapshot.c index 2267bd4c3472..6018b9d1b1fb 100644 --- a/drivers/hv/hv_snapshot.c +++ b/drivers/hv/hv_snapshot.c @@ -375,6 +375,7 @@ hv_vss_init(struct hv_util_service *srv) } recv_buffer = srv->recv_buffer; vss_transaction.recv_channel = srv->channel; + vss_transaction.recv_channel->max_pkt_size = HV_HYP_PAGE_SIZE * 2; /* * When this driver loads, the user level daemon that -- 2.30.2