Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp173283pxb; Mon, 13 Sep 2021 16:15:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwSprr9o0SNpiFCF7QavcYlX9dnLxTJrnh59f+MzSXsq8pYrLLPpL+SdhX6/Q0Vt2JnIUiw X-Received: by 2002:a92:c26f:: with SMTP id h15mr9765775ild.47.1631574905945; Mon, 13 Sep 2021 16:15:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631574905; cv=none; d=google.com; s=arc-20160816; b=BEadOA8hPoc+GL+StaP3BH7SNwwXK3WMJKveNL0uxcPChKywSs+YDuCtdoMzIiH+eI pJ2GUFwN95KOcMDPgyBgzpzG0OTnoHpCm5TVZf/TQrUAWX0MBKEUMHC3f1FuVypr27sR OYfl0QrgNr8KaZRIO8fvgw5sAVuJRsXiTzUdqOt6pmWmQ51xEjtuGezyPApv5EuN6OSV HxYaSZ5LezXc+xOW08OI6SwNXdmoorwlTi8CGITb9NJr8JjJILqDsyLJUGBUJWA97NDV pCo5GdVDNpccruEag6782s3TTPWsbYTjkY0oxO0zjG7edrrtifGDwMIqHtcPhks7+Kp8 JV3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=HnvKCXMHzp5CP55wB6NkqpHqsZTBLJGIJ1a7cezoaGQ=; b=oZRxld7XKag0cs8SWeswWHJzVCHQTS3ZaR47aM5LVjFy/B+2MfsMKcD1uFWIYqOBEC Ni6k5vcC05NjMz1U14AyCB18AM30ShtuTGDBvoKxI6xSFV2Sj3XWx7GnGDpjL38qPg7Q auFYS5NOrBoTFowLFdz+ZyogjDMay41Ex7lNTVrcxbVIxg3txyqdzAPXLksspCrL0cUX IKFKYDJ+Uika0b823GArBhl3EI3EVbiskPclTqOVHbmJhiV+lWnNyWAuz8wUtwIyt4YE Xv5Mh74f+FUDOUQOaC7x5c1dvSWVfhIFQjs9oCUEdpXemuhnTrQCjqlsnIMCVTbefyDF +oIQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=va3TTilf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n16si10169047jan.32.2021.09.13.16.14.55; Mon, 13 Sep 2021 16:15:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=va3TTilf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346088AbhIMOpn (ORCPT + 99 others); Mon, 13 Sep 2021 10:45:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:58768 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346992AbhIMOkK (ORCPT ); Mon, 13 Sep 2021 10:40:10 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0813C6124F; Mon, 13 Sep 2021 13:55:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631541341; bh=ZuOlyXCbnPphzapEKkJdCeBERI2GBkkUVQ3dxg0NZlg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=va3TTilfdS7UGHidaR2tj35JIqzKzSNq3C7jf24TQKzbxn22syVisJjo45MijeH8R pNP2Neepsr45P2vUlcSgBpY3vLlkvcu9HEAXab7pxEyxySDYYlmzd9a0uOnzCZb6kn DAQ6T7q08/Bf5pZKZf/CQfsms6yj7QBCbiIlDEGQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , Yang Yingliang , "David S. Miller" , Sasha Levin Subject: [PATCH 5.14 259/334] octeontx2-pf: cn10k: Fix error return code in otx2_set_flowkey_cfg() Date: Mon, 13 Sep 2021 15:15:13 +0200 Message-Id: <20210913131122.163396352@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210913131113.390368911@linuxfoundation.org> References: <20210913131113.390368911@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yang Yingliang [ Upstream commit 5e8243e66b4d80eeaf9ed8cb0235ff133630a014 ] If otx2_mbox_get_rsp() fails, otx2_set_flowkey_cfg() need return an error code. Fixes: e7938365459f ("octeontx2-pf: Fix algorithm index in MCAM rules with RSS action") Reported-by: Hulk Robot Signed-off-by: Yang Yingliang Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c index a6210b020a57..94dfd64f526f 100644 --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c @@ -289,8 +289,10 @@ int otx2_set_flowkey_cfg(struct otx2_nic *pfvf) rsp = (struct nix_rss_flowkey_cfg_rsp *) otx2_mbox_get_rsp(&pfvf->mbox.mbox, 0, &req->hdr); - if (IS_ERR(rsp)) + if (IS_ERR(rsp)) { + err = PTR_ERR(rsp); goto fail; + } pfvf->hw.flowkey_alg_idx = rsp->alg_idx; fail: -- 2.30.2