Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp180945pxb; Mon, 13 Sep 2021 16:24:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwBMNRib1Rp27AN4b3GuwY4XN1RXWOwnqhDrzE0tKf0nfgxVj9O+/1pIjiWgzOGf0CdWMvE X-Received: by 2002:a17:906:504:: with SMTP id j4mr15039813eja.245.1631575481804; Mon, 13 Sep 2021 16:24:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631575481; cv=none; d=google.com; s=arc-20160816; b=R2QxjTGgH7sG3wuosy3Gd1JzpwAjNpkghqQJUsoXFvMY4AgAHdM8Vpmkd2Ie65GJcx J3qVcOq2CeE705s5nfyQ463Y3/U2LDSaa9qDxh/7gn8vFYsrxhzDC7W3FnlGPenGTCcw hdvchDT4sv1JNYSKFYCuljr3WmzukIiqUlxo8L1GRfKIsOQ9ededtfB5YOcuf3b0hhm+ owfG05YqwAf7H2d2RPMueKdY29frwuNaY5PC0zzkbGWDN5TNEgFg4DNUoYoWDGoInfME IQbr76h/qDHJao5RGP8QaAolMGCqdIlauFBNR5HaLdSdpxtGozqYg7zyunZwQj7Hl75e azZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=zayEXA/2kR90cPU/ha6k5hr7TN0fbwUPfbqq25my7Ck=; b=hsgqWAla3RJc0J+7TuKAHEf2gjzPGNN6S69/q5xqncVeDYfiJWUjOQOYLM3rfcgL+o C5eWzsleGlysVY8kTWjAKXdzSVLC9g9wKXq82d+NXBC+tvju8N0owbQ/qKSA+9wsKCIe 6XL2GghRjeITLdM/zQZPovmYcZ3XsfN226NV++0h8D6nGzUUBnRVpWoHd7uEjR6alyAM U09OCFVttKFWpTzHLE1jzj7cEljHxu0BB/DDTQvvhiOUoVY0RYLVwkgXjzbEsREc4Jyx jiGij7XHERdBQoo8qYyUsKAIhGu782iRF/+r33qZK8eqIXh+PPZ51wVXj4eepP3iTKla o9MQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="n+5bdL/3"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id nd8si8929868ejc.657.2021.09.13.16.24.15; Mon, 13 Sep 2021 16:24:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="n+5bdL/3"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346467AbhIMOtG (ORCPT + 99 others); Mon, 13 Sep 2021 10:49:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:60466 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345648AbhIMOoK (ORCPT ); Mon, 13 Sep 2021 10:44:10 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 25B14619E2; Mon, 13 Sep 2021 13:57:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631541448; bh=SqIuV8oXHv+E0TqpWZ4DPCfC5A0hNkfW2BZvnVmA8eI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=n+5bdL/3vuIYIuE5gUdB4f7tELwjfuMgT50AUdB1EPJXoYW17ZM/ieUVPGfGJRsMK OlTHTPi02NFo4tyQSP3U094UJko/A2wFA0DVRpNquaYobkoGCpBXWPYdnQub1j8SGP kP6gdHQx36hIg/3c293pMksKz/o8sV7bauE9RTj8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jens Axboe Subject: [PATCH 5.14 301/334] io_uring: IORING_OP_WRITE needs hash_reg_file set Date: Mon, 13 Sep 2021 15:15:55 +0200 Message-Id: <20210913131123.597544850@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210913131113.390368911@linuxfoundation.org> References: <20210913131113.390368911@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jens Axboe commit 7b3188e7ed54102a5dcc73d07727f41fb528f7c8 upstream. During some testing, it became evident that using IORING_OP_WRITE doesn't hash buffered writes like the other writes commands do. That's simply an oversight, and can cause performance regressions when doing buffered writes with this command. Correct that and add the flag, so that buffered writes are correctly hashed when using the non-iovec based write command. Cc: stable@vger.kernel.org Fixes: 3a6820f2bb8a ("io_uring: add non-vectored read/write commands") Signed-off-by: Jens Axboe Signed-off-by: Greg Kroah-Hartman --- fs/io_uring.c | 1 + 1 file changed, 1 insertion(+) --- a/fs/io_uring.c +++ b/fs/io_uring.c @@ -1001,6 +1001,7 @@ static const struct io_op_def io_op_defs }, [IORING_OP_WRITE] = { .needs_file = 1, + .hash_reg_file = 1, .unbound_nonreg_file = 1, .pollout = 1, .plug = 1,