Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp216574pxb; Mon, 13 Sep 2021 17:24:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyQzfsK7480BBO/2eOYvNfTLY2VJEfvJ28JEE5wd13MQJkmfqLRY09Is3EHZZPnRUf8nkHw X-Received: by 2002:a05:6402:493:: with SMTP id k19mr16504822edv.386.1631579048158; Mon, 13 Sep 2021 17:24:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631579048; cv=none; d=google.com; s=arc-20160816; b=C1RBXLH7tegiALm5cagcJjF2tmzWvnUozk4dr/kFYNrv/eS2ITl87Qc8FveCa1sy+g 6QRTUK35qEthQU2r8IRdZntcgrT78oqSNjNWfaQz53e0y46TdpfcHjFB0I//zFUW12LL rCl6NjcqN6XwOEKfWk2yvUmRSDzrsfz0yAEKPsj/VgqwXix54+At20clBJEVzBpqiIU/ x8RzUxGdi6fh1dUbqFB3+nEd+M2V5JCWpL+H7c9Gg5CP3tfAPhbcEyKVJo11bRIm7rG/ hUnU6D7J9DUeFodqlWgNjvV0eKsciMcTky87Kyft+qsgKjA9bTg5FyMaN+PnQSktEH26 hU1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=UTTAIY+eEtlxCdE2IlMd8ctpAcgTRDYsdOS5B6lpYzg=; b=P74zABBK9SSMYe1GSY9WYjDmdL8S+sdvlT5FNKQETUic12GDtK1HXF8td5LsmX2HOx TH7lCZGIThg6yRFuly9kXLIJh9HiS6g+jHJMq6vD4Vpd4TgJmzCdYtQz1k3p0jTp7rzL 4PCvMLjTay5yIkuC23OW8TZZPIedY7CLi8st3652ChgFDl6shiRUPXc4mLJA0ofdfvPC fwbZ4h6rV1vwhRrvet6XvLueoD4Rv3JOzLeRaXjWbkKi+yB9KF5jGeObAzGNJGKjBZ2m aQT/z06s1FOgZvsqV1Glk6MYaEARCw6Mt0C8IDKA71oArj1PG+SwSphVKBE6v2NTIgm4 zKAg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=MxZLp1HN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w9si10007232edx.466.2021.09.13.17.23.43; Mon, 13 Sep 2021 17:24:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=MxZLp1HN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344838AbhIMOJZ (ORCPT + 99 others); Mon, 13 Sep 2021 10:09:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:55954 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244090AbhIMOGV (ORCPT ); Mon, 13 Sep 2021 10:06:21 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 136C361A7B; Mon, 13 Sep 2021 13:39:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631540395; bh=jB4fAYwVb+zmMgGrVACNJ7TvNKDY2o01HUgun9n2NrY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MxZLp1HNYGYzefVi3cblIH4VR4RJzzulvbBNe+F9NQORfbrglLobObG/R55MapMr5 riauuFExHVMSPBx59Qp0CBxPC9zM4ke679PtJW+gni1Gln6IoaA81FhhZm9MWFSv+a ScW4qMR71xPUrkXIjoFDRXMsNHdv4zMn90xXhVVk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Parav Pandit , Jiri Pirko , Leon Romanovsky , "David S. Miller" , Sasha Levin Subject: [PATCH 5.13 176/300] net/mlx5: Fix unpublish devlink parameters Date: Mon, 13 Sep 2021 15:13:57 +0200 Message-Id: <20210913131115.341518284@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210913131109.253835823@linuxfoundation.org> References: <20210913131109.253835823@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Parav Pandit [ Upstream commit 6f35723864b42ec9e9bb95a503449633395c4975 ] Cleanup routine missed to unpublish the parameters. Add it. Fixes: e890acd5ff18 ("net/mlx5: Add devlink flow_steering_mode parameter") Signed-off-by: Parav Pandit Reviewed-by: Jiri Pirko Reviewed-by: Leon Romanovsky Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/mellanox/mlx5/core/devlink.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/devlink.c b/drivers/net/ethernet/mellanox/mlx5/core/devlink.c index 44c458443428..4794173f8fdb 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/devlink.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/devlink.c @@ -664,6 +664,7 @@ params_reg_err: void mlx5_devlink_unregister(struct devlink *devlink) { mlx5_devlink_traps_unregister(devlink); + devlink_params_unpublish(devlink); devlink_params_unregister(devlink, mlx5_devlink_params, ARRAY_SIZE(mlx5_devlink_params)); devlink_unregister(devlink); -- 2.30.2