Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp218026pxb; Mon, 13 Sep 2021 17:26:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxhu5SJNLVlRJ4bZogoy6w+xNiCcs+vp1E/tMoEg0lpn82I4UIU9MqSxtvF1Frc+/EnO2FY X-Received: by 2002:a5d:9319:: with SMTP id l25mr4844161ion.208.1631579182135; Mon, 13 Sep 2021 17:26:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631579182; cv=none; d=google.com; s=arc-20160816; b=VyMgd3PQfpMCeN4I8GhnSll3WiANwDmSrwV1xefd8zBMejA5ZfOI+EuMTWNI783/Js DKo1sgB5GErWhHG+ABcYHLhEnUAAsv4mK/VL3s2fLwUlcuIqDZgsPlQzvd/AGb2xvOfo ZpR2lsvPPwJ9VU4RDGJ4I7Pak/ILhk1mSE6KKax1CB0RH8JqBp5jzKMFHvROl/CJJhRk pjpoM02D30MLihKWk5719It5RKXey8SsU/wbwfBCKEQcY5FQDeqKYIO9GN0xaX+rhidk WunO/JOncilBeijDJGUaBspxRwCsvowdud6PdFmf5Mlj15Dtr1ANAuSAJLKnEfpWpG8t DM+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ruozxrUE3BuAqMKeHcgBs/0WZt175PAxo82gwAHb0Ek=; b=qCqDCwSQ6VlVe1zi2wrgMjLhiq9quTyXJendLefR2aqamaw9MyV1PuOwRc13xt36pE Yz4CJURJoUPLcJNOHqGhKymAEcswh7BrzTqTXi9SnZmshMNs3Zytx+eQgptQB9phDHt9 sQt3s3HLOsqtT5/5Aec++U6LK63jep/eHMxsr81435VlHfgm2vXiNLcTmVj4Jx+4VYf7 2cyl+xaRL7jxVIsm6nSNw7AC2mKIlz7TSrXWC12c6G2ZJner30NFWQSjY6LGh/WprTgC IgjYF+T+iX2a+PlQ+4cT5Wi/jm55WVhmYRWymaexyLzOLb29ldtmTFD2VOldVtI4bV9j CWhQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=aq0yZv8H; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j8si656494jat.1.2021.09.13.17.26.10; Mon, 13 Sep 2021 17:26:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=aq0yZv8H; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344263AbhIMOLP (ORCPT + 99 others); Mon, 13 Sep 2021 10:11:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:59952 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344155AbhIMOIs (ORCPT ); Mon, 13 Sep 2021 10:08:48 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 15223613CF; Mon, 13 Sep 2021 13:41:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631540462; bh=/d29cnrykMJAM59XlqfxgJ4cJ/6LbmA653H3HbDyPWc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aq0yZv8HNvBSyo/KHuEr2DVi5oUHaBHQaEq+L0JN+2UWlU3scgwWl0Hk0ugdOtoSn 1zqDcuB5UzQt1UxVDvLBQ3PQDOT11WRxiSx1ja7K+q6sRxcHFtTly4rGI8lP0DsGRU 9r0u7Xwu2i/qOyCK7xnNrkcybaxQa+41xcU+RPcU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Chris Packham , Guenter Roeck , Sasha Levin Subject: [PATCH 5.13 204/300] hwmon: (pmbus/bpa-rs600) Dont use rated limits as warn limits Date: Mon, 13 Sep 2021 15:14:25 +0200 Message-Id: <20210913131116.259565724@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210913131109.253835823@linuxfoundation.org> References: <20210913131109.253835823@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chris Packham [ Upstream commit 7a8c68c57fd09541377f6971f25efdeb9a926c37 ] In the initial implementation a number of PMBUS_x_WARN_LIMITs were mapped to MFR fields. This was incorrect as these MFR limits reflect the rated limit as opposed to a limit which will generate warning. Instead return -ENXIO like we were already doing for other WARN_LIMITs. Subsequently these rated limits have been exposed generically as new fields in the sysfs ABI so the values are still available. Fixes: 15b2703e5e02 ("hwmon: (pmbus) Add driver for BluTek BPA-RS600") Signed-off-by: Chris Packham Link: https://lore.kernel.org/r/20210812014000.26293-2-chris.packham@alliedtelesis.co.nz Signed-off-by: Guenter Roeck Signed-off-by: Sasha Levin --- drivers/hwmon/pmbus/bpa-rs600.c | 25 ------------------------- 1 file changed, 25 deletions(-) diff --git a/drivers/hwmon/pmbus/bpa-rs600.c b/drivers/hwmon/pmbus/bpa-rs600.c index 2be69fedfa36..be76efe67d83 100644 --- a/drivers/hwmon/pmbus/bpa-rs600.c +++ b/drivers/hwmon/pmbus/bpa-rs600.c @@ -12,15 +12,6 @@ #include #include "pmbus.h" -#define BPARS600_MFR_VIN_MIN 0xa0 -#define BPARS600_MFR_VIN_MAX 0xa1 -#define BPARS600_MFR_IIN_MAX 0xa2 -#define BPARS600_MFR_PIN_MAX 0xa3 -#define BPARS600_MFR_VOUT_MIN 0xa4 -#define BPARS600_MFR_VOUT_MAX 0xa5 -#define BPARS600_MFR_IOUT_MAX 0xa6 -#define BPARS600_MFR_POUT_MAX 0xa7 - static int bpa_rs600_read_byte_data(struct i2c_client *client, int page, int reg) { int ret; @@ -81,29 +72,13 @@ static int bpa_rs600_read_word_data(struct i2c_client *client, int page, int pha switch (reg) { case PMBUS_VIN_UV_WARN_LIMIT: - ret = pmbus_read_word_data(client, 0, 0xff, BPARS600_MFR_VIN_MIN); - break; case PMBUS_VIN_OV_WARN_LIMIT: - ret = pmbus_read_word_data(client, 0, 0xff, BPARS600_MFR_VIN_MAX); - break; case PMBUS_VOUT_UV_WARN_LIMIT: - ret = pmbus_read_word_data(client, 0, 0xff, BPARS600_MFR_VOUT_MIN); - break; case PMBUS_VOUT_OV_WARN_LIMIT: - ret = pmbus_read_word_data(client, 0, 0xff, BPARS600_MFR_VOUT_MAX); - break; case PMBUS_IIN_OC_WARN_LIMIT: - ret = pmbus_read_word_data(client, 0, 0xff, BPARS600_MFR_IIN_MAX); - break; case PMBUS_IOUT_OC_WARN_LIMIT: - ret = pmbus_read_word_data(client, 0, 0xff, BPARS600_MFR_IOUT_MAX); - break; case PMBUS_PIN_OP_WARN_LIMIT: - ret = pmbus_read_word_data(client, 0, 0xff, BPARS600_MFR_PIN_MAX); - break; case PMBUS_POUT_OP_WARN_LIMIT: - ret = pmbus_read_word_data(client, 0, 0xff, BPARS600_MFR_POUT_MAX); - break; case PMBUS_VIN_UV_FAULT_LIMIT: case PMBUS_VIN_OV_FAULT_LIMIT: case PMBUS_VOUT_UV_FAULT_LIMIT: -- 2.30.2