Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp220013pxb; Mon, 13 Sep 2021 17:29:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyvsVH/8ieWEZKow9bUJVvaCy71NMJK+VN5OUaAnu37RomELCMPBcYIaxrVte0KkbGsLJYo X-Received: by 2002:a17:906:b0c8:: with SMTP id bk8mr15912707ejb.412.1631579378926; Mon, 13 Sep 2021 17:29:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631579378; cv=none; d=google.com; s=arc-20160816; b=jBWoerY0Ei6EETRfoNAUriv7JKX4WakDHI+KSAvykeKEE2A41qQVuRmsNvVtFzuP9z Ari6sXzZVr+JV1QnIEcUWMwLytjz975Ss3FPr9bIE2uQR65eBAX7aYLj+gAFJQTyy0Cx eZ0wFK9qH+TJmezI1xsPIxehI6e57DIOmqsPETPujEuGeyoiNT5Qz7+zsFEIjyCyiMBX DvllBpTOUpT71LL9GAe+31YzkjPBEWjnb+vbfAYtnW+zG4rN2Oqfx26C7+CDzPKh/jM7 OxVY9+IslfA4S7AdjDdVP+UjEAAqOVlv20d7kNMuXoS1h0/8A6Jw3hscd2gnXwbcvHVO ssxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=O+embdr+DV4JjkwDA5R4WXfX0DvPvgmm6IGdGr7tt+g=; b=NSJSkKn1Iwywt7GtNyR0EQ6WYWlpn5WHuGTIw599Xo/0qA9bAxclScppuMPDhQlrAU 7wM/RcESl2mnXff1Xih3w7G8W45dtJfIU9GHUosvsQMIWIXDx4CsNHJih2Z29rGzsfnx oe2DhfuOSUtC4TZjbfFV/h0awKIjPMvJuwGWBBRqCH/Tevgvp/XpWIP5F8RYwTPt3axF d8wKU0yuglefXbasNOuS1qMMvtyMXWyNvQQ4lxTdYsVCu0kzgq8vrPnyTYNHR9hVI5vO vM+wYpjhLwGosQ+Mw9z0X7jjbC/inGd6b7ajuS+NM07cPdLYm/kR/w8YBz/6NED4ohou Rfqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=pT+H3Dld; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w21si8351987ejk.187.2021.09.13.17.29.07; Mon, 13 Sep 2021 17:29:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=pT+H3Dld; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344835AbhIMOP2 (ORCPT + 99 others); Mon, 13 Sep 2021 10:15:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:59952 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244031AbhIMOMA (ORCPT ); Mon, 13 Sep 2021 10:12:00 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id CDDBA61ACE; Mon, 13 Sep 2021 13:42:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631540550; bh=ew6QFRbpjf61wu36p4LAqhVfJLhKx4rYLGyQkXg1Dp4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pT+H3DldxCjCn5b87yUyYkcbBwWmAV8NBdyEZ4qg+u0060ndYfy4cuLgkJ2nMXnfr 2i+xZs73sN60/LqMiUj7qQrvQzucqz8gu+C0R/dznv3Q5Oof0wdC42/VKlyovgtVZl ly9KIuE0aNDco+v41ttjfarAE217/oDTPdOgN9uY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christophe JAILLET , Mark Brown , Sasha Levin Subject: [PATCH 5.13 240/300] ASoC: wcd9335: Disable irq on slave ports in the remove function Date: Mon, 13 Sep 2021 15:15:01 +0200 Message-Id: <20210913131117.463083548@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210913131109.253835823@linuxfoundation.org> References: <20210913131109.253835823@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe JAILLET [ Upstream commit d3efd26af2e044ff2b48d38bb871630282d77e60 ] The probe calls 'wcd9335_setup_irqs()' to enable interrupts on all slave ports. This must be undone in the remove function. Add a 'wcd9335_teardown_irqs()' function that undoes 'wcd9335_setup_irqs()' function, and call it from the remove function. Fixes: 20aedafdf492 ("ASoC: wcd9335: add support to wcd9335 codec") Signed-off-by: Christophe JAILLET Message-Id: <8f761244d79bd4c098af8a482be9121d3a486d1b.1629091028.git.christophe.jaillet@wanadoo.fr> Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/wcd9335.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c index 47fe68edea3a..d885ced34f60 100644 --- a/sound/soc/codecs/wcd9335.c +++ b/sound/soc/codecs/wcd9335.c @@ -4076,6 +4076,16 @@ static int wcd9335_setup_irqs(struct wcd9335_codec *wcd) return ret; } +static void wcd9335_teardown_irqs(struct wcd9335_codec *wcd) +{ + int i; + + /* disable interrupts on all slave ports */ + for (i = 0; i < WCD9335_SLIM_NUM_PORT_REG; i++) + regmap_write(wcd->if_regmap, WCD9335_SLIM_PGD_PORT_INT_EN0 + i, + 0x00); +} + static void wcd9335_cdc_sido_ccl_enable(struct wcd9335_codec *wcd, bool ccl_flag) { @@ -4878,6 +4888,7 @@ static void wcd9335_codec_remove(struct snd_soc_component *comp) struct wcd9335_codec *wcd = dev_get_drvdata(comp->dev); wcd_clsh_ctrl_free(wcd->clsh_ctrl); + wcd9335_teardown_irqs(wcd); } static int wcd9335_codec_set_sysclk(struct snd_soc_component *comp, -- 2.30.2