Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp220493pxb; Mon, 13 Sep 2021 17:30:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzVrtNhDWjuDtq91aIJXVMa1wu6Q0legARsL+aO+JD/sj2dDpnytieB0uYHsFi8eXFOkbTN X-Received: by 2002:a5d:9d01:: with SMTP id j1mr11535920ioj.27.1631579426916; Mon, 13 Sep 2021 17:30:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631579426; cv=none; d=google.com; s=arc-20160816; b=dG70+7rmEpdXzaXBVI2I2eSRMubXOOHqBA+3zObiJ86j47ZeHKGupg6BWOgNg2QzCY LrwzmEyJTUJiuYdVZK5iaXp18DlmQYbQTwRmcqT/QI9IWBi1dolkvrWzSZrkSyibcM8z beD4x58VmJbgrY+i5Dy8rt/tjcDSEa2SkwjkykD49CLE51laY4UKppkOVWsvbzJ0aP7c o+6w9BYmuv0iOyZi1VjL2fOlID+7beW10bRiqSDlG+CfURSCFnK5Xb/ViM7OPsSx8J7+ NOcnGvaKJkpZBM4Mad85VJhLRywF7dKCXK0mFVnSn4dvZHVLSGu2CrkFYuFkWL/RGd81 MemQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=SbmzYMKEyXH7lT/6CdH3GFG+i05ggd5OQbVFnrgRZtA=; b=h6pKcwpQhtk6btO3VW4WWzAxvAmR8fGBEgNxejyOO3ALHbEir0V36h5D9pWrSO59zD ssHe2U+qYhqhpZsQ3DyxKmIkVTYVU+V00WHmUp++vrGqdjBLqAKd24D3kanviOHGzUqV xzaXuCFWda3lot9Hj3NUZevw+pH+hwaLKOt0nTiRNmI/oAvAnH8oKvdNyKtaMGzwnwQi 3U09CahEYhSdtwsJXEX8iRdjrF2jppawTkPf7B1U/1MugdfYT0rerLxaj1BkfgrlEscn N4tKkml7gZHAP9ADiHpjJm43vMtP7R6XheXgetA97baJ39t0pMHHhY68j9AuuOCuek2O /9JA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=h6HXxUBV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k35si8275062jac.46.2021.09.13.17.30.16; Mon, 13 Sep 2021 17:30:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=h6HXxUBV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343834AbhIMOSC (ORCPT + 99 others); Mon, 13 Sep 2021 10:18:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:34312 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245733AbhIMONE (ORCPT ); Mon, 13 Sep 2021 10:13:04 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A9C0F6128C; Mon, 13 Sep 2021 13:42:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631540575; bh=XF0uZ/NJuhtO93oLxSrCmNBUZFUFZrktfskP+lMO9hw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=h6HXxUBVZaKb1ANWkhOGqhYpjLWUmYL6WXtDjEPuV+2fKKg3uz9ScJ9T0ENOaYJfQ 50q74sQqmWAYVxctsFSYAvi2tTM2CLsfTudB+4+juIdjZgZNTwhg6za+FFkxctrXgK xHTzA/lW9C/pB755jFjqxD/AoRnMcpB2mU0CO0TM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sudarsana Reddy Kalluru , Igor Russkikh , "David S. Miller" , Sasha Levin Subject: [PATCH 5.13 249/300] atlantic: Fix driver resume flow. Date: Mon, 13 Sep 2021 15:15:10 +0200 Message-Id: <20210913131117.763001058@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210913131109.253835823@linuxfoundation.org> References: <20210913131109.253835823@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sudarsana Reddy Kalluru [ Upstream commit 57f780f1c43362b86fd23d20bd940e2468237716 ] Driver crashes when restoring from the Hibernate. In the resume flow, driver need to clean up the older nic/vec objects and re-initialize them. Fixes: 8aaa112a57c1d ("net: atlantic: refactoring pm logic") Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Igor Russkikh Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c b/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c index 59253846e885..f26d03735619 100644 --- a/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c +++ b/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c @@ -417,6 +417,9 @@ static int atl_resume_common(struct device *dev, bool deep) pci_restore_state(pdev); if (deep) { + /* Reinitialize Nic/Vecs objects */ + aq_nic_deinit(nic, !nic->aq_hw->aq_nic_cfg->wol); + ret = aq_nic_init(nic); if (ret) goto err_exit; -- 2.30.2