Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp222723pxb; Mon, 13 Sep 2021 17:34:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxvMwRPe01PggAYrJHbc9txcluk+8Swr28I6rtM9U5rEOYE0ZTvwGK14AcRwIiVAoFt4beH X-Received: by 2002:a6b:8f4e:: with SMTP id r75mr11579301iod.172.1631579671838; Mon, 13 Sep 2021 17:34:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631579671; cv=none; d=google.com; s=arc-20160816; b=jWJdRP8/pf3xghIVaTrGdBMKzcX+GAwC+j4fcTd5fpy49KLopyfvyKPvqRStKlUbY9 Dm+hMFFi5SSTYifMMJL3rrIXkiEtiff9hmG4QDcWOmAal9b0hXiBhbWOCVhOogSHSrO2 uJJjAyKOea3Az7FeLK7iKXI2zf9cF9OO4r1KhDV6B5iddJlJjK18QraQkzKkpvtpzNuN KaiTabQI9SutvkjW2K/UsMtrhcx62nhfYEbS69m7jb1ypQNAJ1ToWiY49uO82Cry0Na9 epEzhCy6Wvepg1CqydrQPtiOBTNpx0H61v06Ybl7PZqadrsO43mEQM4LiAQkt6g1FJWn ymzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=OPHlzM8OPMkOvwQS6ggVvSZ3iSnadZlzuhC34kkCdDU=; b=XhQCREampbYR8ToB9DTsuu1KZLozffK5QwVATVZpbX4CqN8wgNGANvTlllRjIrpigE NvjTRT9RzD5XoHWp+jOQUCtMWq0/wFyMnre5g3m0EsIRz+WOBY6s92QitccIsg6uoztq qQtCD+ohK8/3hUxmc4jKT770GKyorXjJPwwzU8dQlEo7RkDySaOnw3KYolJOhd+PAuQp woMb5odrmvQYBXIbpDqYgDKfra9qdZhOQyb+9ZaMZ7FGp5o3KWDEPkzcM5C5ht8oiOBA 9uFLYe1eekCZrIa7vu2RVDS8Nis8O8z7qZPmx3jPYQ+/HaZd4tIhnhMEScFmdvZK/1Dc BRXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=nUh3Ff1X; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a3si8004006ioc.79.2021.09.13.17.34.20; Mon, 13 Sep 2021 17:34:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=nUh3Ff1X; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241711AbhIMOnf (ORCPT + 99 others); Mon, 13 Sep 2021 10:43:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:56362 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344253AbhIMOiL (ORCPT ); Mon, 13 Sep 2021 10:38:11 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id DA31E6112E; Mon, 13 Sep 2021 13:54:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631541283; bh=ZJe7jnB1GWaJqSwLnCr04Nl2/MgqFHUp/pe6OZWi7sk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nUh3Ff1XMbGor8AiYdb/ueCqEoi/zkcPHIUojx2a+mbVGCCgHK07ShTrclOY3Tja3 02v3cX7Xzi3EJuvBqM/F987vtXhsPoljNdOWHkT4RKh9EXCcHMKig8wY2kax7Zn7Vl PAK4SoGaJAqD9vJo13TcsnMNwCg5ewGotOY+xYrM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sergey Shtylyov , Wolfram Sang , Sasha Levin Subject: [PATCH 5.14 235/334] i2c: hix5hd2: fix IRQ check Date: Mon, 13 Sep 2021 15:14:49 +0200 Message-Id: <20210913131121.362071914@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210913131113.390368911@linuxfoundation.org> References: <20210913131113.390368911@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sergey Shtylyov [ Upstream commit f9b459c2ba5edfe247e86b45ad5dea8da542f3ea ] Iff platform_get_irq() returns 0, the driver's probe() method will return 0 early (as if the method's call was successful). Let's consider IRQ0 valid for simplicity -- devm_request_irq() can always override that decision... Fixes: 15ef27756b23 ("i2c: hix5hd2: add i2c controller driver") Signed-off-by: Sergey Shtylyov Signed-off-by: Wolfram Sang Signed-off-by: Sasha Levin --- drivers/i2c/busses/i2c-hix5hd2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-hix5hd2.c b/drivers/i2c/busses/i2c-hix5hd2.c index aa00ba8bcb70..61ae58f57047 100644 --- a/drivers/i2c/busses/i2c-hix5hd2.c +++ b/drivers/i2c/busses/i2c-hix5hd2.c @@ -413,7 +413,7 @@ static int hix5hd2_i2c_probe(struct platform_device *pdev) return PTR_ERR(priv->regs); irq = platform_get_irq(pdev, 0); - if (irq <= 0) + if (irq < 0) return irq; priv->clk = devm_clk_get(&pdev->dev, NULL); -- 2.30.2