Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp222949pxb; Mon, 13 Sep 2021 17:34:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzZVToXkPu8sNtjmDyqIPHNiv3dVRnWEXuJ+ofBpNykWKI5mV3ET5kcroSMMLvv6MeywcVu X-Received: by 2002:a17:906:417:: with SMTP id d23mr16035625eja.383.1631579692073; Mon, 13 Sep 2021 17:34:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631579692; cv=none; d=google.com; s=arc-20160816; b=Tb2Zp1nEWZLSqfmu00JySCTPLf5evW4YpKC8mpZcu8bEEMGkgJ+Q0Q4+pezzqwMn45 I2RLOZ7ipmCoJUU2HfcNFbkvyyyDvxzp62XTRFlbHNZHAnjIFX1HSpAcB7tysJHXPeN1 4aYPRkzNTxVNUpyYc5lfqGrpoGwpI1YSn5GR9U7eV4hRvVbsbIFjwxb4PGEbXsfMbtee 79bG8V8EC09ypI3UIiD5SwoHgXs31GXnioCyhwIN2/RjzduHI5SbTwiSAp2D/CuBT0gn QGPdvCh84Iot3Wk2VPIgxkBUKPxb7UkuLeaSRhCBHLyrvh3AJD2S0/Gd736P4gD+TVG8 7JJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=F2ZbBreUDxiMclOu7i7o6yVVn87L4Lk+Gzr0fTlMnNg=; b=yP4g6X/e1N0qBzv34lTQHXFcxEjyZjLOLROEHo4fParQnyqu53ES+mPG//tduxoqz9 tF8JPZiCBcy05giMkezfHkN3wt3BGS/p2O/X6mv/9/3fEI5+d1a9VKZwtR0JkN9Kxj0y 5QT9A0YJHtsoG1sFoHRu/Dm10UAGIsqUVabTTFQvlNFzgW9MFSWRhLj9hJfTqKh1hzAI sznrxZyttfc5VPzS0JZyiOXHuKr0OVsz7qUpq+W+cCkH40/sbYAIUe4u3Ly03EXrarnY 9eCv0PWph1bjm1qUs7kZloI5N2uiuDzULBQ7TWZJ8N/rjrvQAjNcW4fmG8HmOgsm+nyU bOPg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=RAyQhIrB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id de23si8060217ejc.342.2021.09.13.17.34.23; Mon, 13 Sep 2021 17:34:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=RAyQhIrB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347820AbhIMOfd (ORCPT + 99 others); Mon, 13 Sep 2021 10:35:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:47500 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347122AbhIMOaQ (ORCPT ); Mon, 13 Sep 2021 10:30:16 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9C98A61B98; Mon, 13 Sep 2021 13:51:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631541075; bh=5mJ3Vh4DFqEpbhgjatt+KHU+ltW1SZdkbGGb41choXo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RAyQhIrBuRi+EUp3eVsQtz8a2bjXSh+BOBT1h1LL3VEc/IPW7sUYw2cUFjkDW+RBj Z7TBMpJ2nxK26l8Zjsh9UYUEme9JBobHV5RHVZ05wH8VkC6WFBiq5MK4uFsy0ncnk6 KgNxHF8jdFCpysTplgmtF2363NKKZ64E/Yy/mKJY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Abaci Robot , Jiapeng Chong , Leon Romanovsky , Saeed Mahameed , Sasha Levin Subject: [PATCH 5.14 152/334] net/mlx5: Fix missing return value in mlx5_devlink_eswitch_inline_mode_set() Date: Mon, 13 Sep 2021 15:13:26 +0200 Message-Id: <20210913131118.497657167@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210913131113.390368911@linuxfoundation.org> References: <20210913131113.390368911@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jiapeng Chong [ Upstream commit bcd68c04c7692416206414dc8971730aa140eba7 ] The return value is missing in this code scenario, add the return value '0' to the return value 'err'. Eliminate the follow smatch warning: drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c:3083 mlx5_devlink_eswitch_inline_mode_set() warn: missing error code 'err'. Reported-by: Abaci Robot Fixes: 8e0aa4bc959c ("net/mlx5: E-switch, Protect eswitch mode changes") Signed-off-by: Jiapeng Chong Reviewed-by: Leon Romanovsky Signed-off-by: Saeed Mahameed Signed-off-by: Sasha Levin --- drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c index 3bb71a186004..fc945945ae33 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c @@ -3091,8 +3091,11 @@ int mlx5_devlink_eswitch_inline_mode_set(struct devlink *devlink, u8 mode, switch (MLX5_CAP_ETH(dev, wqe_inline_mode)) { case MLX5_CAP_INLINE_MODE_NOT_REQUIRED: - if (mode == DEVLINK_ESWITCH_INLINE_MODE_NONE) + if (mode == DEVLINK_ESWITCH_INLINE_MODE_NONE) { + err = 0; goto out; + } + fallthrough; case MLX5_CAP_INLINE_MODE_L2: NL_SET_ERR_MSG_MOD(extack, "Inline mode can't be set"); -- 2.30.2