Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp222965pxb; Mon, 13 Sep 2021 17:34:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzSiYA/nLSbkmmKvzzgPr90jNXMLryq6QBYkL4Clz+tdR1fdI2xODMu7Ne54wRwQyqW6okv X-Received: by 2002:a05:6402:3459:: with SMTP id l25mr8838639edc.55.1631579693766; Mon, 13 Sep 2021 17:34:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631579693; cv=none; d=google.com; s=arc-20160816; b=PJZ4KkLHIs7hKEJLTLZgu+PN9yS6qaI0XasZfeElW+lOz2FZLEL/XK4kdn4f5LVnLd NzkMW3s1Gk1FmGjs/fNgyXaWYkwgqR4h+LSE/jQD10EvpexcwBWQSSOLRtwgDKVzEmvO zJWCHY/bKnqYYuCD6SqmoF97Fra6KRxJXWjPuqsykOpMrAiBbXVgeN8jT+rRmZpOOzV6 k795xTet4txJnKbBCcE/vuMFM3QCvBH7WURoLrD9HIV6zl/tzJtvHD6GlzBTjC8wdLaF IWzt2bnVR2V72h+mJCTANBmi4lhcvqcG0PFHK2oEdWYIUmpOQ6YmFjhOKyXVOsMz5PAJ roXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=aHP0gYlNEYQDDjSphCfrRdbngHXixx4in1gUa2o6wuE=; b=wvuRXer9CuDKD2dslu1h6+Tt7G7RqsbtAjyHdb6Ao9784YSyvKGVEDTxceNqwATIR3 ynVJInjPcv66PnUQ1d2c4qTSzF+d9xhbDWBU3V+Vnvnzv1FAR4TblAlqixFRDuW8cScg ditcfqn4FsXd+dvxdbOFogAHnqzeh+NEAU0LnPIQLDeQxMppAmI1yh9KjVP6m3b7a2nJ qjWou2U9YgWSynqEfsAcdXI8mSSPKnNWFequUmSzhwLqOsDY9NNy19pmeMdCFatXDD+y gxH4/CS6CeUL6MY74HtW8cgBBDZceWrx0a/ocyRtQrjfBMINvPreTtNUu5+bk2eNG5SF BSGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=noZUH8Pp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s4si12541826ejm.735.2021.09.13.17.34.30; Mon, 13 Sep 2021 17:34:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=noZUH8Pp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345721AbhIMOnB (ORCPT + 99 others); Mon, 13 Sep 2021 10:43:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:55842 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346072AbhIMOhV (ORCPT ); Mon, 13 Sep 2021 10:37:21 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6314D619E0; Mon, 13 Sep 2021 13:54:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631541270; bh=jtgoBIX27zlNb/u9W6fYZxseeXTsFRaB5+H2GQJiUMk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=noZUH8Ppa2Gd6fgbjUQWsajArxR/YWXAlTwrpbcGWXKoghnYd2Me731c1dCs1wBHt eDuRpfHixRJcYTIgj0JUxeTs85AV8utnJf2VF5/cW9WsPUlc3kfW7t/exw2fYx97hm gMbYm1iXd07id7Mwu6gu03Dsr1TgcI+WThOT4iSU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Florian Fainelli , Sergey Shtylyov , Sasha Levin Subject: [PATCH 5.14 204/334] usb: misc: brcmstb-usb-pinmap: add IRQ check Date: Mon, 13 Sep 2021 15:14:18 +0200 Message-Id: <20210913131120.309382498@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210913131113.390368911@linuxfoundation.org> References: <20210913131113.390368911@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sergey Shtylyov [ Upstream commit 711087f342914e831269438ff42cf59bb0142c71 ] The driver neglects to check the result of platform_get_irq()'s call and blithely passes the negative error codes to devm_request_irq() (which takes *unsigned* IRQ #), causing it to fail with -EINVAL, overriding an original error code. Stop calling devm_request_irq() with the invalid IRQ #s. Fixes: 517c4c44b323 ("usb: Add driver to allow any GPIO to be used for 7211 USB signals") Reviewed-by: Florian Fainelli Signed-off-by: Sergey Shtylyov Link: https://lore.kernel.org/r/806d0b1a-365b-93d9-3fc1-922105ca5e61@omp.ru Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/misc/brcmstb-usb-pinmap.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/misc/brcmstb-usb-pinmap.c b/drivers/usb/misc/brcmstb-usb-pinmap.c index 336653091e3b..2b2019c19cde 100644 --- a/drivers/usb/misc/brcmstb-usb-pinmap.c +++ b/drivers/usb/misc/brcmstb-usb-pinmap.c @@ -293,6 +293,8 @@ static int __init brcmstb_usb_pinmap_probe(struct platform_device *pdev) /* Enable interrupt for out pins */ irq = platform_get_irq(pdev, 0); + if (irq < 0) + return irq; err = devm_request_irq(&pdev->dev, irq, brcmstb_usb_pinmap_ovr_isr, IRQF_TRIGGER_RISING, -- 2.30.2