Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp223057pxb; Mon, 13 Sep 2021 17:35:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyhjBBkpj1/MvANVMWRmShsBFndWRto2s1Hdp8+NMwRjfZFZS/5/0dUzL3rJfcJosP4mEwS X-Received: by 2002:a05:6402:c10:: with SMTP id co16mr2260900edb.327.1631579703497; Mon, 13 Sep 2021 17:35:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631579703; cv=none; d=google.com; s=arc-20160816; b=0AP0PubHB5CpVWlaOtsv/BcliMc1JK85vM4pdY4ipeBMXkPqX4sPn8ZaFhMP+U2lBm qw2Tf2gNENpbcIYbpVzeLPKA2H2bsxBBcxWMpcw2ScDPgI7X4PE7lpZT4FUeQPpsM6Wh uxjWQy2oj4YltAbh0cRlZXzqSrpyOfjbi3gw9UEvCZbpoWGOm2KL2ee4tP1QrqBV/1FV v5rmrCjWe+obMIwS8Nsoc3xe5/SDVFGGv3KHLCNKRUBaH8rOAM6FjYyZSaf9nFXJ6KxL XD+o/uYnlo/brcBcv55ExvVWY4ofPMA+jYTdLlYzdNPh+YoexeRlMnXytlGQ2v0xYBvi t79A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=VIfLI32ikmzSPWoBrrRLAqq9mxbq3MomW/ypafAQ9h8=; b=O5+BVNMQY0LQu8FJzxjZgHaD12ivNzbUamDVCvtFdBmSH+PTBufCd5LUAwEY7Eb+xR QWCoJ4cNcAnkA0CL1L7u+MeR5d8/MBvUzdGBoDfcVrBUtwX799UDMeLSVvmF3/ZRn/d7 1w7JV2xmzUwACiuuDeKFY/qj4DphD6qmdP6vq3PxFpq1xA4lxoJQmwu3g8zTsNrIQeVS K/lUZZFMu5I1rgpnTq83GCgMZ7aJEKumC507mp9nlsepFIundmHc3aDWGhWdiULPaVLn 9L9YmEi2EOAsMXyQyQQ8+JQJKCxJVYMJQBbnjbNMRSbClesRdKD/yVn0dRGYg9S30ZKC GGfw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=zQZ8jBrk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m18si8629815ejl.243.2021.09.13.17.34.38; Mon, 13 Sep 2021 17:35:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=zQZ8jBrk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347289AbhIMOlh (ORCPT + 99 others); Mon, 13 Sep 2021 10:41:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:54212 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347948AbhIMOfm (ORCPT ); Mon, 13 Sep 2021 10:35:42 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id EFE6A61BA8; Mon, 13 Sep 2021 13:53:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631541227; bh=d9tOvY4GPK1jKWMaBSPHaYQUFYgLGzNJbCmnl5KHBLY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zQZ8jBrkarVjyjAYN0PpP5cVnRJB1Opc1QYUUOVLOpgyCaL3jIYQVJkcfPP2PBQvz nWqcCEZGstZDK70+niGHbay3E1N2l9+hPYN+QOhdOdaOCwOJmb+ytYOP/NLUPU1g8g X56WJ3vyq5RAWDxGxlxWCS+EPeqIHkY1DLHEPkf8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Felipe Balbi , Sergey Shtylyov , Sasha Levin Subject: [PATCH 5.14 215/334] usb: phy: tahvo: add IRQ check Date: Mon, 13 Sep 2021 15:14:29 +0200 Message-Id: <20210913131120.693114405@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210913131113.390368911@linuxfoundation.org> References: <20210913131113.390368911@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sergey Shtylyov [ Upstream commit 0d45a1373e669880b8beaecc8765f44cb0241e47 ] The driver neglects to check the result of platform_get_irq()'s call and blithely passes the negative error codes to request_threaded_irq() (which takes *unsigned* IRQ #), causing it to fail with -EINVAL, overriding an original error code. Stop calling request_threaded_irq() with the invalid IRQ #s. Fixes: 9ba96ae5074c ("usb: omap1: Tahvo USB transceiver driver") Acked-by: Felipe Balbi Signed-off-by: Sergey Shtylyov Link: https://lore.kernel.org/r/8280d6a4-8e9a-7cfe-1aa9-db586dc9afdf@omp.ru Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/phy/phy-tahvo.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy-tahvo.c b/drivers/usb/phy/phy-tahvo.c index baebb1f5a973..a3e043e3e4aa 100644 --- a/drivers/usb/phy/phy-tahvo.c +++ b/drivers/usb/phy/phy-tahvo.c @@ -393,7 +393,9 @@ static int tahvo_usb_probe(struct platform_device *pdev) dev_set_drvdata(&pdev->dev, tu); - tu->irq = platform_get_irq(pdev, 0); + tu->irq = ret = platform_get_irq(pdev, 0); + if (ret < 0) + return ret; ret = request_threaded_irq(tu->irq, NULL, tahvo_usb_vbus_interrupt, IRQF_ONESHOT, "tahvo-vbus", tu); -- 2.30.2