Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp226958pxb; Mon, 13 Sep 2021 17:42:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz9Y9Obh113uLp3EVRQDifezAXknNq8nsN47nRqs/pP77+2sA+8WbYnU14Uy+SvmmGWp4W6 X-Received: by 2002:a92:d2ca:: with SMTP id w10mr2087729ilg.222.1631580131022; Mon, 13 Sep 2021 17:42:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631580131; cv=none; d=google.com; s=arc-20160816; b=iiO1EkCdA6HOF8INbcSYeBTDoH9mkYblR4hcxx1puJ6J1jpLQylY+Kc/bJrA2/VrAH WTmLf8Gkg7ejs3uxbX+gp+CcaW4ddw+T090SOE3HnqLfG3AgynDpzXAm8c3Bdh7gcwZy Ft9DHoTUWbzWLPVeH1YjIroRiqEcYVHtOCMHDtA2sXIIFVcwhBRz4kixlqvH5w2vRmJ4 m22FCLogsrtERQTc20PWkItI0mfCCJOs+0FejVhB/PI0JnxAmich8mNiXugfUTlIZBgc 3q6W/Y4nejqGMfuXx8dcAhdLIQC14dMt3Imh/2+KR5T21VAOcR++wrhfEYOI0dC88GhM aYqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=f7W68sIGdsF4sb+eCGZgRFHof5BQujqnmQiX0z6wBSE=; b=jgznHCpgTSwxXlzAjGDOGhcQ6vT93dvlbow6CT+nZjh9fa9uUuKgX3coswuKdT6k8V lGmWU0ziXeXg7S98wC7EJMpa6WaZdFqEXhy5OfvVwp0UWLC3slh+ZowyKen+pPabxMz9 quno6Wq7DeUISU10U7DZySMs0wOrfjCIb90NoYSRB69zhnS+c46tsBs7fUzYId8Po0E2 3Hx8l9G5aYw39aaKppdKNQa9Bmf3oeVgATFLiHPU3cGLlhz5iG1AUQYRoIDnxTP+rqjT I+oUOpdcAHLTGdoFLMIOUhdRdBUnayYht7dFuooD/h5UCn/eagpxtdpZraVpHBicWZTS StcA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nYFQxeHb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s186si8854425ios.107.2021.09.13.17.41.59; Mon, 13 Sep 2021 17:42:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nYFQxeHb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237544AbhIMQ2w (ORCPT + 99 others); Mon, 13 Sep 2021 12:28:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:58544 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229542AbhIMQ2v (ORCPT ); Mon, 13 Sep 2021 12:28:51 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A2D3760E76; Mon, 13 Sep 2021 16:27:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631550455; bh=+JU75Xr+8q9kiFLxr1qYENZSbwe5QYQ0hiW2ZF5UCD0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nYFQxeHb0GejwY1c9Wp9liAY4sMkenPKpjRCTclr2YunjCOr2wzwBBi9vD2HLuJqZ 3IggVeQkyIqLwrVt3TtoTcy1sxq3XNWr1A7EoQ19iUO4AiDMtfw7dRIDzG5S9R/ErQ Virp4+/ZMn77Wme4xWVuK6Tu0KOI5CrCApWRGLtE4bUotf+nENo1Dp2HzucqOyfds4 Cba13pYZKZZRD1iF0CGMasAJpGr9AEYYFMv2aJok+Sxg6guc6WB7HbFHtkdAOLL1ab lD5nLJ2m1ZC9wCVnN2Hsq3gLWEbNML9M0RDKvaoivMQMQFL5Tc/sYjsUHN4DOdrtYN 41BPrC2M6gogQ== Date: Mon, 13 Sep 2021 12:27:34 -0400 From: Sasha Levin To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Phillip Potter , kernel test robot , linux-staging@lists.linux.dev Subject: Re: [PATCH AUTOSEL 5.14 044/252] staging: rtl8188eu: remove rtw_wx_set_rate handler function Message-ID: References: <20210909114106.141462-1-sashal@kernel.org> <20210909114106.141462-44-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 09, 2021 at 01:48:49PM +0200, Greg Kroah-Hartman wrote: >On Thu, Sep 09, 2021 at 07:37:38AM -0400, Sasha Levin wrote: >> From: Phillip Potter >> >> [ Upstream commit ac5951a6e3d50cfa861ea83baa2ec15d994389cb ] >> >> Remove rtw_wx_set_rate handler function, which currently handles the >> SIOCSIWRATE wext ioctl. This function (although containing a lot of >> code) set nothing outside its own local variables, and did nothing other >> than call a now removed debugging statement repeatedly. Removing it and >> leaving its associated entry in rtw_handlers as NULL is therefore the >> better option. Removing this function also fixes a kernel test robot >> warning. >> >> Reported-by: kernel test robot >> Signed-off-by: Phillip Potter >> Link: https://lore.kernel.org/r/20210625191658.1299-1-phil@philpotter.co.uk >> Signed-off-by: Greg Kroah-Hartman >> Signed-off-by: Sasha Levin >> --- >> .../staging/rtl8188eu/os_dep/ioctl_linux.c | 75 ------------------- >> 1 file changed, 75 deletions(-) > >This whole driver is now gone in 5.15-rc1, so no need for doing anything >like this for older kernels. Please drop this patch from all branches. Dropped, thanks! -- Thanks, Sasha